Re: [Libguestfs] [PATCH 1/7] v2v: check next free oem%d.inf in /Windows/Inf

2016-04-05 Thread Cedric Bosdonnat
On Tue, 2016-04-05 at 13:04 +0100, Richard W.M. Jones wrote: > On Tue, Apr 05, 2016 at 01:47:27PM +0200, Cédric Bosdonnat wrote: > > + let oem_inf = set_free_oem_inf g root scsi_adapter_guid > > "viostor.inf" driverdir in > > Seems better if it was called *get_next*_free_oem_inf? Yes, sounds

Re: [Libguestfs] [PATCH 1/7] v2v: check next free oem%d.inf in /Windows/Inf

2016-04-05 Thread Cedric Bosdonnat
On Tue, 2016-04-05 at 15:13 +0300, Roman Kagan wrote: > On Tue, Apr 05, 2016 at 01:47:27PM +0200, Cédric Bosdonnat wrote: > > It seems that checking for oem%d.inf in the DeviceIds registry > > entry > > doesn't always list all oemXX.inf files. For example we may have > > oem1.inf free in the

Re: [Libguestfs] [PATCH 1/7] v2v: check next free oem%d.inf in /Windows/Inf

2016-04-05 Thread Richard W.M. Jones
On Tue, Apr 05, 2016 at 02:24:33PM +0200, Cedric Bosdonnat wrote: > On Tue, 2016-04-05 at 13:04 +0100, Richard W.M. Jones wrote: > > On Tue, Apr 05, 2016 at 01:47:27PM +0200, Cédric Bosdonnat wrote: > > > + let oem_inf = set_free_oem_inf g root scsi_adapter_guid > > > "viostor.inf" driverdir in >

Re: [Libguestfs] [PATCH 1/7] v2v: check next free oem%d.inf in /Windows/Inf

2016-04-05 Thread Roman Kagan
On Tue, Apr 05, 2016 at 01:47:27PM +0200, Cédric Bosdonnat wrote: > It seems that checking for oem%d.inf in the DeviceIds registry entry > doesn't always list all oemXX.inf files. For example we may have > oem1.inf free in the registry key, but used in another one. In my experiments this name

Re: [Libguestfs] [PATCH 1/7] v2v: check next free oem%d.inf in /Windows/Inf

2016-04-05 Thread Richard W.M. Jones
On Tue, Apr 05, 2016 at 01:47:27PM +0200, Cédric Bosdonnat wrote: > + let oem_inf = set_free_oem_inf g root scsi_adapter_guid "viostor.inf" > driverdir in Seems better if it was called *get_next*_free_oem_inf? > >(* There should be a key > * HKLM\SYSTEM\ControlSet001\Control\Class\

[Libguestfs] [PATCH 1/7] v2v: check next free oem%d.inf in /Windows/Inf

2016-04-05 Thread Cédric Bosdonnat
It seems that checking for oem%d.inf in the DeviceIds registry entry doesn't always list all oemXX.inf files. For example we may have oem1.inf free in the registry key, but used in another one. Also extract this into a separate function for later use to setup another driver. ---