Re: [Libguestfs] [PATCH libnbd v2 10/10] generator: Check requirements for BytesPersistIn/Out and completion callbacks.

2019-08-15 Thread Eric Blake
On 8/15/19 7:07 AM, Richard W.M. Jones wrote: > On Thu, Aug 15, 2019 at 07:01:49AM -0500, Eric Blake wrote: >> We still had another potential API change to squeeze into 0.9.8: >> Right now, the API is overloading 'command': >> nbd_connect_command/nbd_kill_command >> vs. >> nbd_aio_command_completed

Re: [Libguestfs] [PATCH libnbd v2 10/10] generator: Check requirements for BytesPersistIn/Out and completion callbacks.

2019-08-15 Thread Richard W.M. Jones
On Thu, Aug 15, 2019 at 07:01:49AM -0500, Eric Blake wrote: > We still had another potential API change to squeeze into 0.9.8: > Right now, the API is overloading 'command': > nbd_connect_command/nbd_kill_command > vs. > nbd_aio_command_completed/nbd_aio_peek_command_completed > > Keeping nbd_conn

Re: [Libguestfs] [PATCH libnbd v2 10/10] generator: Check requirements for BytesPersistIn/Out and completion callbacks.

2019-08-15 Thread Eric Blake
On 8/15/19 4:56 AM, Richard W.M. Jones wrote: > --- > generator/generator | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/generator/generator b/generator/generator > index 1252bdb..13cb0b9 100755 > --- a/generator/generator > +++ b/generator/generator > @@ -312

[Libguestfs] [PATCH libnbd v2 10/10] generator: Check requirements for BytesPersistIn/Out and completion callbacks.

2019-08-15 Thread Richard W.M. Jones
--- generator/generator | 25 + 1 file changed, 25 insertions(+) diff --git a/generator/generator b/generator/generator index 1252bdb..13cb0b9 100755 --- a/generator/generator +++ b/generator/generator @@ -3121,6 +3121,31 @@ let () = failwithf "%s: first_version m