Re: [Libguestfs] [PATCH nbdkit 10/10] XXX docs: Remove references to -U - when it is implicit
This series, minus the delayed documentation patch, plus the --dump-config patch, was pushed as: ff3c9eb0e..868954b23 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH nbdkit 10/10] XXX docs: Remove references to -U - when it is implicit
On Mon, Sep 11, 2023 at 09:34:50AM -0500, Eric Blake wrote: > On Sat, Sep 09, 2023 at 02:57:58PM +0100, Richard W.M. Jones wrote: > > XXX NOTE XXX > > > > I would not apply this patch immediately, since online documentation > > will get updated as soon as I do that. Best to wait until after 1.36 > > is released at least. > > At the earliest, on the day that we are ready to cut 1.36 (I don't see > a problem with the docs being updated once the tarball will be ready, > rather than having to wait yet longer to 1.36.1). But I agree that we > aren't quite ready for the stable release yet. > > > > > XXX END NOTE XXX > > --- > > docs/nbdkit-captive.pod | 6 +++--- > > filters/cacheextents/nbdkit-cacheextents-filter.pod | 2 +- > > filters/checkwrite/nbdkit-checkwrite-filter.pod | 6 +++--- > > filters/pause/nbdkit-pause-filter.pod | 2 +- > > filters/retry/nbdkit-retry-filter.pod | 2 +- > > plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 4 ++-- > > plugins/nbd/nbdkit-nbd-plugin.pod | 2 +- > > plugins/random/nbdkit-random-plugin.pod | 2 +- > > plugins/sparse-random/nbdkit-sparse-random-plugin.pod | 2 +- > > plugins/torrent/nbdkit-torrent-plugin.pod | 6 +++--- > > plugins/vddk/nbdkit-vddk-plugin.pod | 4 ++-- > > BENCHMARKING | 4 ++-- > > Unless I'm mistaken, BENCHMARKING is the only file in this list that > is not live on the website, and therefore which could be hoisted into > 9/10 if desired. But I see no harm in leaving it here. > > Obviously, we'd better not forget to apply this at the correct later > date, and you'll have to touch up the commit message at that point. > But once we are ready, feel free to add > > Reviewed-by: Eric Blake I now have a special local branch called '2023-run-U-push-after-1.36-is-released' :-) Thanks for the reviews. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
Re: [Libguestfs] [PATCH nbdkit 10/10] XXX docs: Remove references to -U - when it is implicit
On Sat, Sep 09, 2023 at 02:57:58PM +0100, Richard W.M. Jones wrote: > XXX NOTE XXX > > I would not apply this patch immediately, since online documentation > will get updated as soon as I do that. Best to wait until after 1.36 > is released at least. At the earliest, on the day that we are ready to cut 1.36 (I don't see a problem with the docs being updated once the tarball will be ready, rather than having to wait yet longer to 1.36.1). But I agree that we aren't quite ready for the stable release yet. > > XXX END NOTE XXX > --- > docs/nbdkit-captive.pod | 6 +++--- > filters/cacheextents/nbdkit-cacheextents-filter.pod | 2 +- > filters/checkwrite/nbdkit-checkwrite-filter.pod | 6 +++--- > filters/pause/nbdkit-pause-filter.pod | 2 +- > filters/retry/nbdkit-retry-filter.pod | 2 +- > plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 4 ++-- > plugins/nbd/nbdkit-nbd-plugin.pod | 2 +- > plugins/random/nbdkit-random-plugin.pod | 2 +- > plugins/sparse-random/nbdkit-sparse-random-plugin.pod | 2 +- > plugins/torrent/nbdkit-torrent-plugin.pod | 6 +++--- > plugins/vddk/nbdkit-vddk-plugin.pod | 4 ++-- > BENCHMARKING | 4 ++-- Unless I'm mistaken, BENCHMARKING is the only file in this list that is not live on the website, and therefore which could be hoisted into 9/10 if desired. But I see no harm in leaving it here. Obviously, we'd better not forget to apply this at the correct later date, and you'll have to touch up the commit message at that point. But once we are ready, feel free to add Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
[Libguestfs] [PATCH nbdkit 10/10] XXX docs: Remove references to -U - when it is implicit
XXX NOTE XXX I would not apply this patch immediately, since online documentation will get updated as soon as I do that. Best to wait until after 1.36 is released at least. XXX END NOTE XXX --- docs/nbdkit-captive.pod | 6 +++--- filters/cacheextents/nbdkit-cacheextents-filter.pod | 2 +- filters/checkwrite/nbdkit-checkwrite-filter.pod | 6 +++--- filters/pause/nbdkit-pause-filter.pod | 2 +- filters/retry/nbdkit-retry-filter.pod | 2 +- plugins/linuxdisk/nbdkit-linuxdisk-plugin.pod | 4 ++-- plugins/nbd/nbdkit-nbd-plugin.pod | 2 +- plugins/random/nbdkit-random-plugin.pod | 2 +- plugins/sparse-random/nbdkit-sparse-random-plugin.pod | 2 +- plugins/torrent/nbdkit-torrent-plugin.pod | 6 +++--- plugins/vddk/nbdkit-vddk-plugin.pod | 4 ++-- BENCHMARKING | 4 ++-- 12 files changed, 21 insertions(+), 21 deletions(-) diff --git a/docs/nbdkit-captive.pod b/docs/nbdkit-captive.pod index 248f9df28..4f9740bc9 100644 --- a/docs/nbdkit-captive.pod +++ b/docs/nbdkit-captive.pod @@ -46,7 +46,7 @@ When guestfish exits, nbdkit is killed. Running nbdkit captive under nbdsh for unit testing: - nbdkit -U - memory 1 --run 'nbdsh -u "$uri" -c "print(h.pread(1, 0))"' + nbdkit memory 1 --run 'nbdsh -u "$uri" -c "print(h.pread(1, 0))"' The following shell variables are available in the I<--run> argument: @@ -104,7 +104,7 @@ Captive nbdkit + L can be used to copy data into and out of nbdkit plugins. For example L contains an embedded disk image. To copy it out: - nbdkit -U - example1 --run 'qemu-img convert $nbd disk.img' + nbdkit example1 --run 'qemu-img convert $nbd disk.img' If the source suffers from temporary network failures L or L may @@ -114,7 +114,7 @@ To overwrite a file inside an uncompressed tar file (the file being overwritten must be the same size), use L like this: - nbdkit -U - file data.tar --filter=tar tar-entry=disk.img \ + nbdkit file data.tar --filter=tar tar-entry=disk.img \ --run 'qemu-img convert -n disk.img $nbd' =head1 EXIT WITH PARENT diff --git a/filters/cacheextents/nbdkit-cacheextents-filter.pod b/filters/cacheextents/nbdkit-cacheextents-filter.pod index 77dc680c8..a2b2aa519 100644 --- a/filters/cacheextents/nbdkit-cacheextents-filter.pod +++ b/filters/cacheextents/nbdkit-cacheextents-filter.pod @@ -17,7 +17,7 @@ only one extent at a time (such as S>), but where the plugin can provide multiple extents for the same high latency as a single extent (such as L). For example: - nbdkit -U - --filter=cacheextents --run 'qemu-img map $nbd' vddk ... + nbdkit --filter=cacheextents --run 'qemu-img map $nbd' vddk ... For files with big extents (when it is unlikely for one extents() call to return multiple different extents) this does not slow down the diff --git a/filters/checkwrite/nbdkit-checkwrite-filter.pod b/filters/checkwrite/nbdkit-checkwrite-filter.pod index 67a466f87..6855d7988 100644 --- a/filters/checkwrite/nbdkit-checkwrite-filter.pod +++ b/filters/checkwrite/nbdkit-checkwrite-filter.pod @@ -28,17 +28,17 @@ You can check that a copying tool is copying data correctly by creating an nbdkit instance containing some test data, overlaying this filter, and copying from and to nbdkit at the same time: - nbdkit -U - --filter=checkwrite data "@32768 1" \ + nbdkit --filter=checkwrite data "@32768 1" \ --run 'nbdcopy "$uri" "$uri"' =for paragraph - nbdkit -U - --filter=checkwrite file disk.img \ + nbdkit --filter=checkwrite file disk.img \ --run 'nbdcopy "$uri" "$uri"' =for paragraph - nbdkit -U - --filter=checkwrite linuxdisk testdir/ \ + nbdkit --filter=checkwrite linuxdisk testdir/ \ --run 'qemu-img convert -n "$uri" "$uri"' If the copying program is buggy then you will see EIO errors and (if diff --git a/filters/pause/nbdkit-pause-filter.pod b/filters/pause/nbdkit-pause-filter.pod index 1bc083ddc..708e0b3ea 100644 --- a/filters/pause/nbdkit-pause-filter.pod +++ b/filters/pause/nbdkit-pause-filter.pod @@ -39,7 +39,7 @@ Any unknown commands are ignored. The filter responds with C<'X'>. Pick a large file, disk image or ISO, serve it over NBD, and start copying it: - nbdkit -U - --filter=pause --filter=rate \ + nbdkit --filter=pause --filter=rate \ file BIG_FILE.ISO rate=10M pause-control=sock \ --run 'qemu-img convert -p $nbd /var/tmp/out' diff --git a/filters/retry/nbdkit-retry-filter.pod b/filters/retry/nbdkit-retry-filter.pod index 6eba3d4ff..6179a507d 100644 --- a/filters/retry/nbdkit-retry-filter.pod +++ b/filters/retry/nbdkit-retry-filter.pod @@ -50,7 +50,7 @@ waiting in total about 1 minute before we give up. In this example we copy and convert a large file using L, L and L. - nbdkit -U - \ + nbdkit \ ssh host=remote.example.com /var/tmp/test.iso \ --filter=retry \ --run 'qemu-img convert
