Re: [Libguestfs] [PATCH v3 05/10] lib: extract osinfo DB traversing API

2017-02-14 Thread Richard W.M. Jones
On Fri, Feb 10, 2017 at 04:06:00PM +0100, Cédric Bosdonnat wrote: > +static struct osinfo *osinfo_db = NULL; > + > + Extra blank line here. > +static int > +read_osinfo_db_xml (guestfs_h *g, const char *pathname, void *data); Unsplit this. Only put a function name at the beginning of a line if

[Libguestfs] [PATCH v3 05/10] lib: extract osinfo DB traversing API

2017-02-10 Thread Cédric Bosdonnat
Split lib/osinfo.c to provide an API for other pieces of code (namely mllib) to reuse it. The ISO-related processing is thus moved into a lib/osinfo-iso.c file. --- lib/Makefile.am | 2 + lib/osinfo-iso.c | 464 +++ lib/osinfo.c | 424