Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Richard W.M. Jones
On Wed, Nov 09, 2022 at 01:47:15PM -0600, Eric Blake wrote: > On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: > > > > -=item 4, 5, 6, 7 > > > > +=item S<4> > > > > > > The S<> notation seems new here (so it's going to be inconsistent with > > > the rest of this file, I think).

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2022 at 02:23:39PM +0100, Laszlo Ersek wrote: > On 11/09/22 20:47, Eric Blake wrote: > > On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: > -=item 4, 5, 6, 7 > +=item S<4> > >>> > >>> The S<> notation seems new here (so it's going to be inconsistent

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Laszlo Ersek
On 11/09/22 20:47, Eric Blake wrote: > On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: -=item 4, 5, 6, 7 +=item S<4> >>> >>> The S<> notation seems new here (so it's going to be inconsistent with >>> the rest of this file, I think). >> >> I was going to mention this

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-09 Thread Eric Blake
On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: > > > -=item 4, 5, 6, 7 > > > +=item S<4> > > > > The S<> notation seems new here (so it's going to be inconsistent with > > the rest of this file, I think). > > I was going to mention this too. The S<> notation is used to

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-04 Thread Eric Blake
On Wed, Nov 02, 2022 at 01:43:13PM +, Richard W.M. Jones wrote: > On Tue, Nov 01, 2022 at 02:56:09PM -0500, Eric Blake wrote: > ... > > +=item S<6> > > + > > +Triggers a call to the C function C with C > > +set to false, which requests a soft disconnect of the current client > > +(future

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-02 Thread Richard W.M. Jones
On Tue, Nov 01, 2022 at 02:56:09PM -0500, Eric Blake wrote: ... > +=item S<6> > + > +Triggers a call to the C function C with C > +set to false, which requests a soft disconnect of the current client > +(future client requests are rejected with C without calling > +into the plugin, but current

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-02 Thread Richard W.M. Jones
On Wed, Nov 02, 2022 at 02:15:45PM +0100, Laszlo Ersek wrote: > On 11/01/22 20:56, Eric Blake wrote: > > Make it possible for the sh and eval plugins to disconnect a client or > > shut down the entire nbdkit server by use of special return values. > > Prior to this patch we had reserved 4-7 for

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-02 Thread Laszlo Ersek
On 11/01/22 20:56, Eric Blake wrote: > Make it possible for the sh and eval plugins to disconnect a client or > shut down the entire nbdkit server by use of special return values. > Prior to this patch we had reserved 4-7 for future use; this defines > 4-6, and extends the set of reserved return

[Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-01 Thread Eric Blake
Make it possible for the sh and eval plugins to disconnect a client or shut down the entire nbdkit server by use of special return values. Prior to this patch we had reserved 4-7 for future use; this defines 4-6, and extends the set of reserved return values to 7-15. We figure it is unlikely that