Re: [Libguestfs] [p2v PATCH 09/11] gui: expose "p2v.output.misc" (-oo)

2023-01-31 Thread Laszlo Ersek
On 1/30/23 19:15, Richard W.M. Jones wrote: > On Mon, Jan 30, 2023 at 03:22:26PM +0100, Laszlo Ersek wrote: >> + str = gtk_entry_get_text (GTK_ENTRY (oo_entry)); >> + guestfs_int_free_string_list (config->output.misc); >> + config->output.misc = guestfs_int_split_string (',', str); > > My

Re: [Libguestfs] [p2v PATCH 09/11] gui: expose "p2v.output.misc" (-oo)

2023-01-30 Thread Richard W.M. Jones
On Mon, Jan 30, 2023 at 03:22:26PM +0100, Laszlo Ersek wrote: > + str = gtk_entry_get_text (GTK_ENTRY (oo_entry)); > + guestfs_int_free_string_list (config->output.misc); > + config->output.misc = guestfs_int_split_string (',', str); My concern here is that someone is going to put "foo=bar,

[Libguestfs] [p2v PATCH 09/11] gui: expose "p2v.output.misc" (-oo)

2023-01-30 Thread Laszlo Ersek
Introduce a new GTK_ENTRY field in the Output options box. Similarly to "p2v.output.misc" on the kernel cmdline, the contents of this GTK_ENTRY are a comma-separated list of OPTION=VALUE options, where each option is passed to virt-v2v as the argument of a separate "-oo" option. Refresh the