Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-16 Thread alan somers
On Mon, Jan 16, 2023 at 5:04 AM Martin Kletzander wrote: > > On Fri, Jan 13, 2023 at 08:23:05PM +, Richard W.M. Jones wrote: > >On Fri, Jan 13, 2023 at 01:06:09PM -0700, alan somers wrote: > >> Which files get overwritten by libvirt-ci ? > > > >I think it's everything except ci/manifest.yml,

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-16 Thread Erik Skultety
On Fri, Jan 13, 2023 at 06:34:29PM +, Richard W.M. Jones wrote: > > https://github.com/libguestfs/nbdkit/pull/19 > > Actually I suspect that the changes made in PR19 will get overwritten > since they touch files which are in git but are really controlled by > libvirt-ci. > > I'm not sure how

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-16 Thread Erik Skultety
On Mon, Jan 16, 2023 at 01:04:03PM +0100, Martin Kletzander wrote: > On Fri, Jan 13, 2023 at 08:23:05PM +, Richard W.M. Jones wrote: > > On Fri, Jan 13, 2023 at 01:06:09PM -0700, alan somers wrote: > > > Which files get overwritten by libvirt-ci ? > > > > I think it's everything except

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-16 Thread Richard W.M. Jones
Thanks everyone. Just a note that nbdkit CI is passing right now. I disabled the rust plugin (only) for the troublesome distros. Also I fixed a bunch of other things that were broken. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-16 Thread Martin Kletzander
On Fri, Jan 13, 2023 at 08:23:05PM +, Richard W.M. Jones wrote: On Fri, Jan 13, 2023 at 01:06:09PM -0700, alan somers wrote: Which files get overwritten by libvirt-ci ? I think it's everything except ci/manifest.yml, possibly. Eric and Martin (CC'd) know more about this. The libvirt-ci

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 01:06:09PM -0700, alan somers wrote: > Which files get overwritten by libvirt-ci ? I think it's everything except ci/manifest.yml, possibly. Eric and Martin (CC'd) know more about this. The libvirt-ci page is: https://libvirt.org/ci.html And the command I use to

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
Which files get overwritten by libvirt-ci ? On Fri, Jan 13, 2023 at 11:34 AM Richard W.M. Jones wrote: > > > https://github.com/libguestfs/nbdkit/pull/19 > > Actually I suspect that the changes made in PR19 will get overwritten > since they touch files which are in git but are really controlled

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
> https://github.com/libguestfs/nbdkit/pull/19 Actually I suspect that the changes made in PR19 will get overwritten since they touch files which are in git but are really controlled by libvirt-ci. I'm not sure how to make the changes in a way which are compatible with libvirt-ci, maybe Eric or

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 11:18:10AM -0700, alan somers wrote: > I approved PR 21. But I'd like to merge PR 19 too, to fix the Cirrus > CI that runs on the Github mirror. Sure thing! Please go ahead, as I'm going to wait for PR21 to see exactly what tests still fail. Rich. -- Richard Jones,

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
I approved PR 21. But I'd like to merge PR 19 too, to fix the Cirrus CI that runs on the Github mirror. On Fri, Jan 13, 2023 at 11:03 AM Richard W.M. Jones wrote: > > On Fri, Jan 13, 2023 at 06:00:07PM +, Richard W.M. Jones wrote: > > I'll push something to PR#19 in a few mins. > > Actually

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 06:00:07PM +, Richard W.M. Jones wrote: > I'll push something to PR#19 in a few mins. Actually I don't think I can modify it, so I opened an alternate PR: https://gitlab.com/nbdkit/nbdkit/-/merge_requests/21 Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 10:52:33AM -0700, alan somers wrote: > There actually isn't any real problem to fix; it's purely a CI problem. > > Our Cargo.toml file (and transitively, our dependencies' Cargo.toml > files) specify that we need predicates-tree and predicates-core. > Unless instructed

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
There actually isn't any real problem to fix; it's purely a CI problem. Our Cargo.toml file (and transitively, our dependencies' Cargo.toml files) specify that we need predicates-tree and predicates-core. Unless instructed otherwise, Cargo will attempt to fetch the latest compatible version.

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 09:17:29AM -0700, alan somers wrote: > Oh, I misread your initial mail. I saw "Debian" in the subject line > and assumed you were talking about packaging. But you weren't. This > is happening in CI for every platform. > > There's a straightforward way to fix the problem

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
Oh, I misread your initial mail. I saw "Debian" in the subject line and assumed you were talking about packaging. But you weren't. This is happening in CI for every platform. There's a straightforward way to fix the problem for Cirrus CI, the one that runs after we mirror to Github. But it

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 08:35:08AM -0700, alan somers wrote: > The nbdkit crate. Why does Debian need a package for it? I'm not sure -- do they have one? I can't seem to find it. Rich. > On Fri, Jan 13, 2023 at 8:30 AM Richard W.M. Jones wrote: > > > > On Fri, Jan 13, 2023 at 08:25:28AM

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
The nbdkit crate. Why does Debian need a package for it? On Fri, Jan 13, 2023 at 8:30 AM Richard W.M. Jones wrote: > > On Fri, Jan 13, 2023 at 08:25:28AM -0700, alan somers wrote: > > IMHO this is a design bug in Debian. Sure, they need to create > > packages for any Rust crate that needs to

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 08:25:28AM -0700, alan somers wrote: > IMHO this is a design bug in Debian. Sure, they need to create > packages for any Rust crate that needs to install executable or .so > files. But crates like nbdkit don't install anything. They're only > used to build other Rust

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
IMHO this is a design bug in Debian. Sure, they need to create packages for any Rust crate that needs to install executable or .so files. But crates like nbdkit don't install anything. They're only used to build other Rust crates, and only used at compile time. They can simply be fetched

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2023 at 07:17:14AM -0700, alan somers wrote: > I think we should downgrade predicates-tree to 1.0.5 or older. I can > submit a PR for that. What does "rustc --version" show you? Unfortunately our configure script doesn't collect that information (it should do! - I'll fix that in

Re: [Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread alan somers
I think we should downgrade predicates-tree to 1.0.5 or older. I can submit a PR for that. What does "rustc --version" show you? On Fri, Jan 13, 2023 at 2:41 AM Richard W.M. Jones wrote: > > > https://gitlab.com/nbdkit/nbdkit/-/jobs/3598390121 > >

[Libguestfs] Cargo edition problem with Debian 11

2023-01-13 Thread Richard W.M. Jones
https://gitlab.com/nbdkit/nbdkit/-/jobs/3598390121 -- cargo build --release --example ramdisk Downloading crates ... Downloaded float-cmp v0.9.0 Downloaded downcast v0.11.0 Downloaded mockall_derive v0.11.3 Downloaded