Re: [Libguestfs] Proposed changes for OpenStack

2011-12-15 Thread Matthew Booth
On 12/15/2011 08:35 AM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 05:07:04PM +, Matthew Booth wrote: guestmount_mount(g.sock_path(), '/tmp/dir') ...filesystem stuff... guestmount_umount('/tmp/dir') g.close() Note that there are no callbacks, no threads and no races. The code can be

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-15 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 05:07:04PM +, Matthew Booth wrote: > guestmount_mount(g.sock_path(), '/tmp/dir') > ...filesystem stuff... > guestmount_umount('/tmp/dir') > > g.close() > > Note that there are no callbacks, no threads and no races. The code > can be written sequentially. There are cer

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Matthew Booth
On 12/14/2011 04:40 PM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 04:03:16PM +, Matthew Booth wrote: On 12/14/2011 03:13 PM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 02:17:05PM +, Matthew Booth wrote: I still don't see why we need the guestfish event callbacks. becau

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 04:03:16PM +, Matthew Booth wrote: > On 12/14/2011 03:13 PM, Richard W.M. Jones wrote: > >On Wed, Dec 14, 2011 at 02:17:05PM +, Matthew Booth wrote: > >>I still don't see why we need the guestfish event callbacks. > > > >because ... > > > >>>The guestfish change is o

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Matthew Booth
On 12/14/2011 03:13 PM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 02:17:05PM +, Matthew Booth wrote: I still don't see why we need the guestfish event callbacks. because ... The guestfish change is only for us to do testing. Can't the test be written in another language? [..

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 02:17:05PM +, Matthew Booth wrote: > I still don't see why we need the guestfish event callbacks. because ... > >The guestfish change is only for us to do testing. [...] > This is an extension of the libguestfs api in a direction which is > best served by a different

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Matthew Booth
On 12/14/2011 12:06 PM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 11:06:24AM +, Matthew Booth wrote: On 12/14/2011 10:36 AM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 09:33:35AM +, Matthew Booth wrote: On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: [These two patche

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 11:06:24AM +, Matthew Booth wrote: > On 12/14/2011 10:36 AM, Richard W.M. Jones wrote: > >On Wed, Dec 14, 2011 at 09:33:35AM +, Matthew Booth wrote: > >>On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: > >>>[These two patches are for discussion only] > >>> > >>>Allo

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Matthew Booth
On 12/14/2011 10:36 AM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 09:33:35AM +, Matthew Booth wrote: On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: [These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 09:33:35AM +, Matthew Booth wrote: > On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: > >[These two patches are for discussion only] > > > >Allow FUSE support to be used directly through the API. > >This is the second commit. > > > >In order to make this usable from gue

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Matthew Booth
On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: [These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In order to make this usable from guestfish, we have to also bind the events API in guestfish. This is the first comm

[Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
[These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In order to make this usable from guestfish, we have to also bind the events API in guestfish. This is the first commit. Rich.