Re: [Libguestfs] [PATCH] v2v: Support and (RHBZ#1378022).

2016-09-21 Thread Pino Toscano
On Wednesday, 21 September 2016 14:03:43 CEST Richard W.M. Jones wrote: > Since libvirt 2.0.0, these two new types have been > supported: https://libvirt.org/formatdomain.html#elementsGraphics > > This change just copies that configuration over from the source to the > destination if the

[Libguestfs] [PATCH] v2v: -i libvirtxml: ignore (RHBZ#1378022)

2016-09-21 Thread Pino Toscano
When reading a libvirt XML which has: then just ignore it, as it is (roughly) the same as no child elements at all. This avoids a warning about an unknown listen type. --- v2v/input_libvirtxml.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/input_libvirtxml.ml

Re: [Libguestfs] [PATCH] libvirt: read disk paths from pools (RHBZ#1366049)

2016-09-21 Thread Richard W.M. Jones
On Tue, Sep 20, 2016 at 05:07:23PM +0200, Pino Toscano wrote: > A disk of type 'volume' is stored as > > and its real location is inside the 'volume_name', as 'pool_name': in > this case, query libvirt for the actual path of the specified volume in > the specified pool. > > Adjust the code so

Re: [Libguestfs] [PATCH] v2v: -i libvirtxml: ignore (RHBZ#1378022)

2016-09-21 Thread Richard W.M. Jones
On Wed, Sep 21, 2016 at 02:33:23PM +0200, Pino Toscano wrote: > When reading a libvirt XML which has: > > > > > > then just ignore it, as it is (roughly) the same as no child > elements at all. This avoids a warning about an unknown listen type. I looked at this and don't think it

[Libguestfs] [PATCH] v2v: Support and (RHBZ#1378022).

2016-09-21 Thread Richard W.M. Jones
Since libvirt 2.0.0, these two new types have been supported: https://libvirt.org/formatdomain.html#elementsGraphics This change just copies that configuration over from the source to the destination if the destination is also libvirt. Since we previously used 'LNone' to mean "no parseable