Re: [Libguestfs] [PATCH] appliance: more reliable check for the supermin appliance

On Fri, Apr 28, 2017 at 05:04:15PM +0300, Pavel Butsykin wrote: > At least two control files (packages and base.tar.gz) are necessary for the > supermin appliance. > > Signed-off-by: Pavel Butsykin > --- > lib/appliance.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On 28.04.2017 17:46, Pino Toscano wrote: On Wednesday, 19 April 2017 15:58:56 CEST Pavel Butsykin wrote: I dare to raise an old topic :) It seemed to me that this patch already applied, but recently discovered that it is not. As far as I understand we can't do a strict requirement to use

Re: [Libguestfs] [PATCH v6 1/1] v2v: bootloaders: search grub config for all distributions

On Fri, Apr 28, 2017 at 07:57:56PM +0300, Pavel Butsykin wrote: > On 28.04.2017 17:45, Pino Toscano wrote: > >On Wednesday, 19 April 2017 15:58:57 CEST Pavel Butsykin wrote: > >>This patch improves the search of grub config on EFI partition. This > >>means that the config will be found not only

Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On Fri, Apr 28, 2017 at 07:58:41PM +0300, Pavel Butsykin wrote: > > > On 28.04.2017 17:46, Pino Toscano wrote: > >On Wednesday, 19 April 2017 15:58:56 CEST Pavel Butsykin wrote: > >>I dare to raise an old topic :) It seemed to me that this patch already > >>applied, > >>but recently discovered

Re: [Libguestfs] [PATCH v6 1/1] v2v: bootloaders: search grub config for all distributions

On 28.04.2017 17:45, Pino Toscano wrote: On Wednesday, 19 April 2017 15:58:57 CEST Pavel Butsykin wrote: This patch improves the search of grub config on EFI partition. This means that the config will be found not only for rhel but also for many other distributions. Tests were performed on the

Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On 20.04.2017 12:19, Pavel Butsykin wrote: [This sender failed our fraud detection checks and may not be who they appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] 20.04.2017 10:54, Richard W.M. Jones пишет: On Wed, Apr 19, 2017 at 04:58:56PM +0300, Pavel Butsykin

[Libguestfs] [PATCH] appliance: more reliable check for the supermin appliance

At least two control files (packages and base.tar.gz) are necessary for the supermin appliance. Signed-off-by: Pavel Butsykin --- lib/appliance.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/appliance.c b/lib/appliance.c index

Re: [Libguestfs] [PATCH] add enable_appliance flag to specify the appliance build

On Fri, Apr 28, 2017 at 05:03:58PM +0300, Pavel Butsykin wrote: > On 27.04.2017 18:28, Richard W.M. Jones wrote: > > > >On Thu, Apr 27, 2017 at 03:55:10PM +0300, Pavel Butsykin wrote: > >>The flag determines the behavior of working with the appliance, and > >>specifically > >>the choice to use

Re: [Libguestfs] [PATCH] appliance: reorder the steps to search for appliance

On 27.04.2017 17:43, Richard W.M. Jones wrote: On Thu, Apr 27, 2017 at 03:54:44PM +0300, Pavel Butsykin wrote: [...] (2) If the fixed appliance was located somewhere else, you could do: LIBGUESTFS_PATH=/path/to/somewhere/else:/usr/lib64/guestfs export LIBGUESTFS_PATH and then it would

Re: [Libguestfs] [PATCH] add enable_appliance flag to specify the appliance build

On 27.04.2017 18:28, Richard W.M. Jones wrote: On Thu, Apr 27, 2017 at 03:55:10PM +0300, Pavel Butsykin wrote: The flag determines the behavior of working with the appliance, and specifically the choice to use the build supermin appliance or the fixed appliance. If the flag is false then the

Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On Fri, Apr 28, 2017 at 05:02:29PM +0300, Pavel Butsykin wrote: > > On 20.04.2017 12:19, Pavel Butsykin wrote: > >[This sender failed our fraud detection checks and may not be who they > >appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] > > > >20.04.2017 10:54, Richard

Re: [Libguestfs] [PATCH] add enable_appliance flag to specify the appliance build

And also it would be nice if there was a ./configure option to set the default path (at the moment it's hard-coded). That way you could set up the path to search in multiple directories, as appropriate for your downstream distro. Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [PATCH v6 1/1] v2v: bootloaders: search grub config for all distributions

On Wednesday, 19 April 2017 15:58:57 CEST Pavel Butsykin wrote: > This patch improves the search of grub config on EFI partition. This > means that the config will be found not only for rhel but also for > many other distributions. Tests were performed on the following > distributions: centos,

Re: [Libguestfs] [PATCH v6 0/1] v2v bootloaders and augeas

On Wednesday, 19 April 2017 15:58:56 CEST Pavel Butsykin wrote: > I dare to raise an old topic :) It seemed to me that this patch already > applied, > but recently discovered that it is not. > > As far as I understand we can't do a strict requirement to use Augeas >= > 1.7.0. > But initially,

[Libguestfs] [PATCH] common/options: Change drv struct to store drive index instead of device name.

The device name is only used by guestfish (when using the -N option to prepare drives). We constructed the device name very naively, basically ‘sprintf ("/dev/sd%c", next_drive)’. This stores the device index instead, and only constructs the device name in guestfish. Also the device name is

[Libguestfs] [PATCH] launch: Error if you try to launch with too many drives.

In particular the virt-rescue --scratch option makes it very easy to add huge numbers of drives. Since the per-backend max_disks limit was never checked anywhere you could get peculiar failures. Now you'll get a clear error message: $ virt-rescue --scratch=256 libguestfs: error: too many drives