[Libguestfs] [PATCH v4 3/3] tests: md: Test guestfish list-filesystems command skips partitioned md devices.

2018-03-12 Thread Mykola Ivanets
Test guestfish list-filesystems command finds file system on partitioned md device and doesn't take into account md device itself (similar to as physical devices are filtered out if they are partitioned). --- tests/md/Makefile.am| 3 +- tests/md/test-partitioned-md-devices.s

[Libguestfs] [PATCH v4 1/3] daemon: Reimplement 'part_get_mbr_part_type' API in OCaml.

2018-03-12 Thread Mykola Ivanets
Instead of parsing 'parted' output OCaml implementation relies on the following facts: 1. The function is applicable for MBR partitions only (as noted in documentation and as function name suggests). 2. An attempt to call the function for non-MBR partition fails with "part_get_mbr_part_type can

[Libguestfs] [PATCH v4 0/3] libguestfs: guestfs_list_filesystems: skip block devices which cannot hold file system

2018-03-12 Thread Mykola Ivanets
Rebased. The only thing left unclear is: "Would you like to document behavior for non-MBR partitions more clearly or keep previous implementation despite MBR partition type doesn't make sense for non-MBR partitions at all?" ___ Libguestfs mailing list

[Libguestfs] [PATCH v4 2/3] daemon: list-filesystems: Don't list partitions which cannot hold file system.

2018-03-12 Thread Mykola Ivanets
The following partitions are filtered out: 1. Partitioned md devices (just as partitioned physical devices are filtered out). 2. Extended MBR partitions. 3. LDM partitions (MBR and GPT partitions used by Windows Logical Disk Manager). 4. Microsoft Reserved Partitions (GUID E3C9E316-0B5C-4DB8-817D-

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Nir Soffer
On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones wrote: > It has to be said it would be really convenient to have a 'zero' > and/or 'trim' method of some sort. > 'trim' means discard? Currently we cannot support discard on block storage since ovirt may need to wipe lvs when deleting a disk, an

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Nir Soffer
On Mon, Mar 12, 2018 at 9:13 AM Nir Soffer wrote: > On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones > wrote: > >> It has to be said it would be really convenient to have a 'zero' >> and/or 'trim' method of some sort. >> > > 'trim' means discard? > > Currently we cannot support discard on block

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Richard W.M. Jones
On Mon, Mar 12, 2018 at 07:13:52AM +, Nir Soffer wrote: > On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones wrote: > > > It has to be said it would be really convenient to have a 'zero' > > and/or 'trim' method of some sort. > > > > 'trim' means discard? Yes. The 5 functions we could suppo

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Richard W.M. Jones
On Mon, Mar 12, 2018 at 10:19:02AM +, Nir Soffer wrote: > I posted this > https://gerrit.ovirt.org/#/c/88793/ > > If this work for you I think we can include this in the next 4.2 build. Looks good, but we need to know something about the alignment required for these requests. Rich. -- Rich

Re: [Libguestfs] virt-v2v 1.38 fails to convert .vmx VM: setfiles ... Multiple same specifications for /.*.

2018-03-12 Thread Richard W.M. Jones
On Mon, Mar 12, 2018 at 08:25:58AM +, Зиновик Игорь Анатольевич wrote: > Hello, Richard. > > Did you managed to find root cause of the problem that I reported last week? I didn't have a chance to look at this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Nir Soffer
On Mon, Mar 12, 2018 at 12:32 PM Richard W.M. Jones wrote: > On Mon, Mar 12, 2018 at 07:13:52AM +, Nir Soffer wrote: > > On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones > wrote: > > > > > It has to be said it would be really convenient to have a 'zero' > > > and/or 'trim' method of some so

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Richard W.M. Jones
On Mon, Mar 12, 2018 at 12:13:08PM +, Nir Soffer wrote: > I think it is for 4.2.z. > > Is zero support in the daemon and proxy enough, or we need the other > options now? zero support is all we really need right now. I'll turn trim requests into zero requests. We don't need flush or FUA sup

[Libguestfs] [PATCH RHEL 7] RHEL 7: -o rhv-upload: Use Python 2 instead of Python 3.

2018-03-12 Thread Richard W.M. Jones
From: "Richard W.M. Jones" --- v2v/output_rhv_upload.ml | 17 - v2v/rhv-upload-createvm.py | 20 v2v/rhv-upload-plugin.py | 28 v2v/rhv-upload-precheck.py | 22 +- 4 files changed, 61 insertions(+), 26 dele

[Libguestfs] [PATCH RHEL 7] RHEL 7: -o rhv-upload: Use Python 2 instead of Python

2018-03-12 Thread Richard W.M. Jones
For interest only, here is the patch required to make -o rhv-upload work with Python 2 (for RHEL 7). I don't think we want this upstream. A couple of remarks: * It's supposed to be possible to add ‘coding: utf-8’ to the top of .py files to make Python 2 accept that the file is UTF-8 (otherwise

Re: [Libguestfs] [PATCH v4 0/3] v2v: Add -o rhv-upload output mode.

2018-03-12 Thread Eric Blake
On 03/12/2018 07:13 AM, Nir Soffer wrote: On Mon, Mar 12, 2018 at 12:32 PM Richard W.M. Jones wrote: On Mon, Mar 12, 2018 at 07:13:52AM +, Nir Soffer wrote: On Fri, Mar 9, 2018 at 4:25 PM Richard W.M. Jones wrote: It has to be said it would be really convenient to have a 'zero' and/o

[Libguestfs] [PATCH] v2v: -o rhv-upload: Support zero requests.

2018-03-12 Thread Richard W.M. Jones
Only compile tested. I'm keeping this as a separate patch for the moment until the relevant change on the oVirt side goes upstream. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

[Libguestfs] [PATCH] v2v: -o rhv-upload: Support zero requests.

2018-03-12 Thread Richard W.M. Jones
--- v2v/rhv-upload-plugin.py | 44 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py index 4f5ed2ac5..9ccb393f8 100644 --- a/v2v/rhv-upload-plugin.py +++ b/v2v/rhv-upload-plugin.py @@ -15