[Libguestfs] [PATCH v2] daemon: inspect: better handling windows drive mapping.

2018-05-31 Thread Mykola Ivanets
I saw several Windows disk images which contains strange registry entry for mapped drives: "\\DosDevices\\Y:"=hex(3):00,00,00,00,00,00,00,00,00,00,00,00 Which is decoded something like diskID = 0x0, partition starts at 0 bytes offset from the start of the disk. In addition to a Windows disk

[Libguestfs] [PATCH v8 4/6] daemon: list-filesystems: Change the way we filter out LDM partitions.

2018-05-31 Thread Mykola Ivanets
1. Now we use GPT partition type to filter out LDM partitions. 2. We also check for filesystems on LDM volumes because LDM partitions doesn't contain filesystems (list_ldm_partitions is not called anymore). 3. Obvious repetitive comments are moved to a function description. --- daemon/listfs.ml |

[Libguestfs] [PATCH v8 3/6] tests: list-filesystems command ignores partitioned MD devices.

2018-05-31 Thread Mykola Ivanets
Test guestfish list-filesystems command finds file system on partitioned md device and doesn't take into account md device itself (similar to as physical devices are filtered out if they are partitioned). --- tests/md/Makefile.am| 3 +-

[Libguestfs] [PATCH v8 6/6] daemon: list-filesystems: Filter out MBR extended partitions.

2018-05-31 Thread Mykola Ivanets
Extended MBR partitions cannot hold filesystems - filter them out. --- daemon/listfs.ml | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/daemon/listfs.ml b/daemon/listfs.ml index 57f2f622d..908e59cc4 100644 --- a/daemon/listfs.ml +++

[Libguestfs] [PATCH v8 0/6] daemon: list_filesystems: filter out block devices which cannot hold filesystem.

2018-05-31 Thread Mykola Ivanets
v8: - Rebased on top of master. v7: - Addresses comments after v6 series review. v6: - Addresses comments after v5 series review. - Large commit is splitted to more granular commits for better code review. v5: - Addresses comments after v4 series review (part_get_mbr_part_type doesn't break

[Libguestfs] [PATCH v8 2/6] daemon: list-filesystems: Ignore partitioned MD devices.

2018-05-31 Thread Mykola Ivanets
Ignore partitioned MD devices the same way we ignore regular partitioned devices because they cannot contain filesystems as well. --- daemon/listfs.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/daemon/listfs.ml b/daemon/listfs.ml index eced55bce..10b1a8594 100644 ---