Re: [Libguestfs] Build failure of libnbd

2020-10-17 Thread Richard W.M. Jones
On Sat, Oct 17, 2020 at 08:48:40AM +0100, Richard W.M. Jones wrote: > [Adding libguestfs mailing list] > > I reproduced it locally - the difference was installing "gcc-go". > I only had golang-bin installed previously. With gcc-go installed: > > ../run go install libguestfs.org/libnbd >

Re: [Libguestfs] Build failure of libnbd

2020-10-17 Thread Richard W.M. Jones
[Adding libguestfs mailing list] I reproduced it locally - the difference was installing "gcc-go". I only had golang-bin installed previously. With gcc-go installed: ../run go install libguestfs.org/libnbd write of Go pointer 0xc16060 to non-Go memory 0x7f5fe8297390 fatal error: Go

[Libguestfs] Why does libxml2 limit port numbers to 999,999,999?

2020-10-17 Thread Richard W.M. Jones
The AF_VSOCK protocol added in Linux 5.6 uses a 32 bit port number. For NBD we map this to simple URIs[1] like nbd+vsock://CID:PORT (where CID is a number that acts a bit like a hostname and PORT is a 32 bit port number). eg: nbd+vsock://1:10/ would be port 10^9 on the loopback address

[Libguestfs] [PATCH nbdkit] common/include/tvdiff.h: Add formal specification.

2020-10-17 Thread Richard W.M. Jones
This commit adds a formal specification of tvdiff_usec and a partial specification of subtract_timeval. These may be proved using Frama-C. The existing functions ignored overflow, but it is possible to call the functions with parameters that will cause overflow. So to create a formal

Re: [Libguestfs] [libnbd PATCH] info: Add support for new 'qemu-nbd -A' qemu:allocation-depth

2020-10-17 Thread Richard W.M. Jones
On Fri, Oct 16, 2020 at 10:23:18AM -0500, Eric Blake wrote: > A rather trivial decoding; we may enhance it further if qemu extends > things to give an integer depth alongside its tri-state encoding. > --- > > I'll wait to push this to libnbd until the counterpart qemu patches > land upstream,

Re: [Libguestfs] [libnbd PATCH] info: Keep request within 4G bound

2020-10-17 Thread Richard W.M. Jones
On Fri, Oct 16, 2020 at 11:35:55PM -0500, Eric Blake wrote: > Otherwise, we get a failure due to Numerical result out of range. > > And for safety's sake, we are best capping our request to an aligned > value, if the server insists on minimum alignment. > > Fixes: f3fd935c > --- >

Re: [Libguestfs] [xml] Why does libxml2 limit port numbers to 99, 999, 999?

2020-10-17 Thread Richard W.M. Jones
On Sat, Oct 17, 2020 at 11:24:31AM +0100, Richard W.M. Jones via xml wrote: > The problem is that libxml2 arbitrarily limits port numbers to > 999,999,999. I don't see any support for this limit in RFC 3986 [2]. Actually I miscounted the number of 9's. The limit is 99,999,999. The rest still

Re: [Libguestfs] [xml] Why does libxml2 limit port numbers to 999, 999, 999?

2020-10-17 Thread Richard W.M. Jones
On Sat, Oct 17, 2020 at 06:32:18PM +0200, Nick Wellnhofer wrote: > On Oct 17, 2020, at 12:24 , Richard W.M. Jones via xml wrote: > > It seems like libxml2 chose to do this for convenience rather than > > correctness. > > Yes, this is an arbitrary limit introduced to avoid integer overflow. > >

Re: [Libguestfs] [xml] Why does libxml2 limit port numbers to 999, 999, 999?

2020-10-17 Thread Nick Wellnhofer
On Oct 17, 2020, at 12:24 , Richard W.M. Jones via xml wrote: > It seems like libxml2 chose to do this for convenience rather than > correctness. Yes, this is an arbitrary limit introduced to avoid integer overflow. > I think it should accept port numbers at least up to > signed int (the type

[Libguestfs] [PATCH] Use guestfsd binary to auto-generate library dependencies for appliance

2020-10-17 Thread Hilko Bengen
The ELF NEEDED are used to determine guestfsd's library dependencies with help from the dynamic linker and the package manager. This was prompted by Debian bug #972241 which was caused by a libtirpc package renaming in Debian/unstable because the SONAME had been changed. ---

Re: [Libguestfs] Build failure of libnbd

2020-10-17 Thread Martin Kletzander
On Sat, Oct 17, 2020 at 09:00:30AM +0100, Richard W.M. Jones wrote: On Sat, Oct 17, 2020 at 08:48:40AM +0100, Richard W.M. Jones wrote: [Adding libguestfs mailing list] I reproduced it locally - the difference was installing "gcc-go". I only had golang-bin installed previously. With gcc-go

Re: [Libguestfs] Build failure of libnbd

2020-10-17 Thread Richard W.M. Jones
On Sat, Oct 17, 2020 at 10:48:13PM +0200, Martin Kletzander wrote: > The list of packages is something I will have to go through anyway, > for not it is just a list taken from libvirt CI container with bunch > of things added for libnbd. Ideally it should be driven from ”dnf builddep libnbd”,

Re: [Libguestfs] Build failure of libnbd

2020-10-17 Thread Martin Kletzander
On Sat, Oct 17, 2020 at 10:08:26PM +0100, Richard W.M. Jones wrote: On Sat, Oct 17, 2020 at 10:48:13PM +0200, Martin Kletzander wrote: The list of packages is something I will have to go through anyway, for not it is just a list taken from libvirt CI container with bunch of things added for