[Libguestfs] libnbd | Failed pipeline for master | 32739fa8

2023-08-30 Thread GitLab
Pipeline #986544565 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 32739fa8 ( https://gitlab.com/nbdkit/libnbd/-/commit/32739fa8e25c44b6d60d29fe4cb60b4284e53342 ) Commit Message: Merge branch

[Libguestfs] libnbd | Failed pipeline for master | 7d9a7b34

2023-08-30 Thread GitLab
Pipeline #986610017 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 7d9a7b34 ( https://gitlab.com/nbdkit/libnbd/-/commit/7d9a7b341abf21fcc00ce43acee90da5a316e538 ) Commit Message: ci: Update to

Re: [Libguestfs] [libnbd PATCH v9 5/7] rust: async: Add a couple of integration tests

2023-08-30 Thread Eric Blake
On Tue, Aug 29, 2023 at 05:17:19PM -0500, Eric Blake wrote: > On Sat, Aug 26, 2023 at 11:29:58AM +, Tage Johansson wrote: > > Add a couple of integration tests as rust/tests/test_async_*.rs. They > > are very similar to the tests for the synchronous API. > > --- > > >

Re: [Libguestfs] [libnbd PATCH v9 5/7] rust: async: Add a couple of integration tests

2023-08-30 Thread Eric Blake
On Wed, Aug 30, 2023 at 08:42:00AM -0500, Eric Blake wrote: > On Tue, Aug 29, 2023 at 05:17:19PM -0500, Eric Blake wrote: > > On Sat, Aug 26, 2023 at 11:29:58AM +, Tage Johansson wrote: > > > Add a couple of integration tests as rust/tests/test_async_*.rs. They > > > are very similar to the

[Libguestfs] libnbd | Failed pipeline for master | b2c95682

2023-08-30 Thread GitLab
Pipeline #986575359 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: b2c95682 ( https://gitlab.com/nbdkit/libnbd/-/commit/b2c956827f39d8c7ead3118f7ead1089cc52dc61 ) Commit Message: Version 1.17.4.

[Libguestfs] libnbd | Failed pipeline for master | 7d9a7b34

2023-08-30 Thread GitLab
Pipeline #986610017 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 7d9a7b34 ( https://gitlab.com/nbdkit/libnbd/-/commit/7d9a7b341abf21fcc00ce43acee90da5a316e538 ) Commit Message: ci: Update to

Re: [Libguestfs] [libnbd PATCH v9 5/7] rust: async: Add a couple of integration tests

2023-08-30 Thread Eric Blake
On Wed, Aug 30, 2023 at 12:16:07PM -0500, Eric Blake wrote: > > error[E0425]: cannot find value `EPOLL_CTL_ADD` in crate `libc` > > https://www.reddit.com/r/rust/comments/65kflg/does_rust_have_native_epoll_support/ > mentions how epoll is Linux-specific, and has comments about tokio > trying to

[Libguestfs] [libnbd PATCH 0/2] (Attempt to) fix Rust on BSD-based builds

2023-08-30 Thread Eric Blake
I managed to get a build of the async Rust handle compiling on FreeBSD (although the cirrus CI appears to not actually run 'make check' on non-Linux machines, at least when run on my fork): https://gitlab.com/ebblake/libnbd/-/jobs/4985192286 However, I'd really like Tage's review on patch 2 to

[Libguestfs] [libnbd PATCH 2/2] rust: Use mio::poll instead of requiring epoll

2023-08-30 Thread Eric Blake
CI shows our async handle fails to build on FreeBSD and MacOS (where epoll() is not available as a syscall, and therefore not available as a Rust crate). We can instead accomplish the same level-probing effects by doing a zero-timeout poll with mio (which defers under the hood to epoll on Linux,

[Libguestfs] [libnbd PATCH 1/2] maint: Favor 4-space indent in .rs files

2023-08-30 Thread Eric Blake
Since rustfmt favors 4-space indent on .rs files, we should do likewise to reduce the churn when running rustfmt after editing in an emacs session set to honor editorconfig. Signed-off-by: Eric Blake --- .editorconfig | 4 1 file changed, 4 insertions(+) diff --git a/.editorconfig

[Libguestfs] [nbdkit PATCH] sh: Allow pwrite to not consume all data

2023-08-30 Thread Eric Blake
I hit another transient failure in libnbd CI when a poorly-written eval script did not consume all of stdin during .pwrite. As behaving as a data sink can be a somewhat reasonable feature of a quickly-written sh or eval plugin, we should not be so insistent as treating an EPIPE failure as an

[Libguestfs] libnbd | Failed pipeline for master | 4df70870

2023-08-30 Thread GitLab
Pipeline #987092980 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 4df70870 ( https://gitlab.com/nbdkit/libnbd/-/commit/4df70870420d1be9348ac45f4aa467501eca5089 ) Commit Message: copy: Once again,