eries
intends to fix both issues.
Thanks,
Laszlo
Laszlo Ersek (2):
tests/mount-local: exit child immediately when exec fails
tests/mount-local: fix relative pathname of FUSE client executable
tests/mount-local/test-parallel-mount-local.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
in the
child, and so the test case always hangs.
Because we had removed "mount-local" from the end of the working
directory, prepend it now to the relative pathname of the FUSE client
executable.
Fixes: 6d32773e811882f78dbd8c2a39a2b7a9c3cfca7c
Signed-off-by: Laszlo Ersek
---
tests/
s" from the symptoms. The
next patch will fix the actual regression in this test case.
Signed-off-by: Laszlo Ersek
---
tests/mount-local/test-parallel-mount-local.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/mount-local/test-parallel-mount-local.c
b/tests/mount-lo
Hi,
I'll post two small patch sets as followups to this "higher order" cover
letter. The goal is to build guestfs-tools and virt-v2v against a
freshly built libguestfs (git checkout), using libguestfs's "run"
script. The modifications affect two projects, libguestfs-common and
guestfs-tools,
(...) {
arg ("-device", "sga");
} else {
#if defined(__i386__) || defined(__x86_64__)
arg ("-machine", "graphics=off");
#endif
}
This would continue working with SeaBIOS preceding "rel-1.11.0", if at
the same time, the QEMU board had SGA support.
But: do we care? (That's what I'd like to learn about libguestfs,
primarily.)
The patch looks good to me, otherwise.
Reviewed-by: Laszlo Ersek
Thanks
Laszlo
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
On 09/08/21 15:27, Laszlo Ersek wrote:
> This series introduces the "lib/local/hivex.pc" pkg-config file to
> hivex, permitting, through the "run" script, other programs and
> libraries to be built against the just-built (not installed) hivex tree.
> A few
On 09/08/21 17:48, Richard W.M. Jones wrote:
> On Wed, Sep 08, 2021 at 03:27:57PM +0200, Laszlo Ersek wrote:
>> This static-only linking allows the libguestfs daemon ("guestfsd") to
>> launch in the appliance, without unresolved hivex symbols, when libguestfs
>> i
On 09/08/21 17:49, Richard W.M. Jones wrote:
>
> Yes the series looks fine, ACK series.
Thanks!
> I think the presence of $(top_builddir)/lib to look for the header
> file was likely a copy-paste thing from some other project. The
> generator always writes files into the source directory (or
On 09/09/21 13:08, Richard W.M. Jones wrote:
> On Thu, Sep 09, 2021 at 12:42:45PM +0200, Laszlo Ersek wrote:
>> On 09/08/21 17:49, Richard W.M. Jones wrote:
>>>
>>> Yes the series looks fine, ACK series.
>>
>> Thanks!
>>
>>> I think the
On 09/09/21 13:35, Richard W.M. Jones wrote:
> On Thu, Sep 09, 2021 at 01:11:09PM +0200, Laszlo Ersek wrote:
>> How does libguestfs deal with different QEMU versions / QEMU feature
>> deprecation? Is there some kind of feature detection?
>
> Kind of, but it's only greppin
On 09/08/21 15:35, Laszlo Ersek wrote:
> "daemon/Makefile.am" needs some tweaks for finding such OCaml bindings
> for hivex that are not installed system-wide.
>
> Thanks,
> Laszlo
>
> Laszlo Ersek (2):
> daemon: generalize ocaml-hivex[-devel] lookup
>
On 09/06/21 16:40, Richard W.M. Jones wrote:
>
> Yes this all seems like obvious stuff. ACK both series + the update
> commits to bring the common submodules up to date.
Thank you for the quick review!
- libguestfs-common: commit range 6d26b6eac9da..19302b64c5f1
- guestfs-tools: commit
o
> visit-c.c:33:10: fatal error: guestfs.h: No such file or directory
>33 | #include "guestfs.h"
> | ^~~
Add the missing $(LIBGUESTFS_CFLAGS) instances.
Signed-off-by: Laszlo Ersek
---
edit/Makefile.am | 3 ++-
mlvisit/Makefile.am | 1 +
parallel/Ma
ror: Error during linking (exit code 1)
in the "mltools" and "mlvisit" modules.
Signed-off-by: Laszlo Ersek
---
mltools/Makefile.am | 24 ++--
mlvisit/Makefile.am | 9 -
2 files changed, 26 insertions(+), 7 deletions(-)
diff --git a/mltools/M
./configure CFLAGS=-fPIC
$ ../libguestfs/run make -j $(getconf _NPROCESSORS_ONLN)
$ ../libguestfs/run make -j $(getconf _NPROCESSORS_ONLN) check
Thanks,
Laszlo
Laszlo Ersek (2):
Makefile.am: supply missing $(LIBGUESTFS_CFLAGS)
Makefile.am: use $(LIBGUESTFS_LIBS) for linking OCaml test programs
CFLAGS=-fPIC
$ ../libguestfs/run make -j $(getconf _NPROCESSORS_ONLN)
$ ../libguestfs/run make -j $(getconf _NPROCESSORS_ONLN) check
Thanks,
Laszlo
Laszlo Ersek (3):
Makefile.am: fix $(LIBGUESTFS_CFLAGS) typo for virt-ls
Makefile.am: supply missing $(LIBGUESTFS_CFLAGS)
Makefile.am: use
CC virt_ls-ls.o
> ls.c:47:10: fatal error: guestfs.h: No such file or directory
>47 | #include "guestfs.h"
> | ^~~
Fixes: 4354a3126152a2748cc9097cba139b3908ccc342
Signed-off-by: Laszlo Ersek
---
cat/Makefile.am | 2 +-
1 file changed, 1 insertio
$(LIBGUESTFS_CFLAGS) instances.
Signed-off-by: Laszlo Ersek
---
builder/Makefile.am | 4 +++-
customize/Makefile.am | 1 +
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/builder/Makefile.am b/builder/Makefile.am
index f49a3b0aaa12..9c155c7f29ef 100644
--- a/builder/Makefile.am
+++
ror during linking (exit code 1)
in the "builder", "customize", "dib", "get-kernel", "resize", "sparsify"
and "sysprep" modules.
Signed-off-by: Laszlo Ersek
---
builder/Makefile.am| 1 +
customize/Makefile.am | 1 +
dib/Makef
Hi,
the hivex tree provides a "run" script in its root directory, but it
does not suffice for building / checking libguestfs, like this:
libguestfs$ autoreconf -i
libguestfs$ ../hivex/run ./configure CFLAGS=-fPIC
libguestfs$ ../hivex/run make -j4
libguestfs$ ../hivex/run make -j4 check
I'll
The "configure" script creates "hivex.pc" in the build directory from
"hivex.pc.in"; there's no need to package "hivex.pc" in a tarball
distribution (created by "make dist"). Remove "hivex.pc" from EXTRA_DIST.
Signed-off-by: Laszlo Ersek
Port libguestfs commit cae7909f5ed8 ("./run: Use 'prepend' function to
build paths.", 2015-02-13) to hivex:
Add a bash function 'prepend' for intelligently prepending elements to
paths. eg:
prepend PYTHONPATH "/foo"
would set PYTHONPATH to "/foo" or
"/
)/lib"
options from the lib, perl, and python makefiles, preserving the proper
"-I$(top_srcdir)/lib" ones.
Signed-off-by: Laszlo Ersek
---
lib/Makefile.am | 2 +-
perl/Makefile.PL.in | 2 +-
python/Makefile.am | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git
nstalled, hivex
tree. The "run" script points PKG_CONFIG_PATH to the new file
"lib/local/hivex.pc", which describes the just-built hivex worktree.
Signed-off-by: Laszlo Ersek
---
configure.ac | 1 +
lib/Makefile.am | 3 ++-
.gitignore
quirements of
"guestfsd", cannot cover hivex when hivex is provided by a local build
directory.)
Linking hivex statically into *host-side* C programs that are compiled
against the hivex build dir is only a small penalty.
Signed-off-by: Laszlo Ersek
---
lib/local/hivex.pc.in | 2 +-
1 file change
figure CFLAGS=-fPIC
> libguestfs$ ../hivex/run make -j $(getconf _NPROCESSORS_ONLN)
> libguestfs$ ../hivex/run make -j $(getconf _NPROCESSORS_ONLN) check
Signed-off-by: Laszlo Ersek
---
ocaml/Makefile.am | 19 ++-
.gitignore| 1 +
run.in| 2 ++
warts are cleaned up, and parts of the libguestfs tree *layout* are
adopted.
Thanks,
Laszlo
Laszlo Ersek (8):
build: do not look for headers in "$(top_builddir)/lib"
build: expose public library header "hivex.h" without "lib" contents
build: remove &qu
,
"mmap.h") are consumed. There, let the new "include" directory extend --
and not replace -- the existent "lib" directory.
Signed-off-by: Laszlo Ersek
---
configure.ac | 1 +
Makefile.am| 2 +-
images/Makefile.am | 2 +-
inc
Bring hivex's worktree structure closer to libguestfs's, in preparation
for introducing "lib/local/hivex.pc.in" in a subsequent patch. Move
"hivex.pc.in" to the "lib" subdirectory.
Signed-off-by: Laszlo Ersek
---
configure.ac | 2 +-
Make
OCaml may exist elsewhere than under the
OCaml standard library directory. Invoke "ocamlfind query hivex" to find
this module. This is what AC_CHECK_OCAML_PKG(hivex) does too, in
"m4/guestfs-ocaml.m4" and "m4/ocaml.m4".
Signed-off-by: Laszlo Ersek
---
daemon/Make
"daemon/Makefile.am" needs some tweaks for finding such OCaml bindings
for hivex that are not installed system-wide.
Thanks,
Laszlo
Laszlo Ersek (2):
daemon: generalize ocaml-hivex[-devel] lookup
daemon_utils_tests: generalize ocaml-hivex[-devel] lookup
daemon/Makefile.am | 5 ++-
Pass $(HIVEX_LIBS) with -cclib under the "daemon_utils_tests_LINK" target;
otherwise the OCaml compiler does not tell the linker where "-lhivex" can
be found, and the linking step fails if "-lhivex" is not on a system
library path.
Signed-off-by: Laszlo Ersek
---
3) Remove the test altogether that attempts to disable lazy counters
after filesystem creation.
Given that new XFS filesystems are created with metadata CRCs enabled by
default, and several XFS features depend on metadata CRCs being enabled,
this patch implements option (3).
Signed-off-by: Lasz
nly be allocated in C:
https://stackoverflow.com/questions/35924545/golang-cgo-panic-runtime-error-cgo-argument-has-go-pointer-to-go-pointer
Rewrite the "arg_string_list" and "free_string_list" functions almost
entirely in C.
Signed-off-by: Laszlo Ersek
---
generator/golang.ml | 46
e RAID (md), and LVM logical volumes.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2005485
Signed-off-by: Laszlo Ersek
---
tests/md/test-md-and-lvm-devices.sh | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/md/test-md-and-lvm-devices.sh
b/tests/md/test-m
to <https://bugzilla.redhat.com/show_bug.cgi?id=2005529>.
Thanks,
Laszlo
Laszlo Ersek (4):
test-9p: fix the base directory that's exported to the guest
test-md-and-lvm-devices: work around RAID0 regression in Linux
v3.14/v5.4
tests: xfs: remove lazy-counter disablement test
Go bindin
directory would not return the file. Thus, the test fails now.
Restore the host-side base directory to ".../tests/9p".
Fixes: 6d32773e811882f78dbd8c2a39a2b7a9c3cfca7c
Signed-off-by: Laszlo Ersek
---
tests/9p/test-9p.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t
On 09/10/21 09:48, Richard W.M. Jones wrote:
> On Fri, Sep 10, 2021 at 01:06:17AM +0200, Laszlo Ersek wrote:
>> There are multiple problems with using strcasecmp() for ordering registry
>> keys:
>>
>> (1) strcasecmp() is influenced by LC_CTYPE.
>>
>>
{'[', '\\', ']', '^', '_', '`'}. For
example,
'c' (0x63) > '_' (0x5F)
'C' (0x43) < '_' (0x5F)
Compare key names byte for byte, eliminating problems (1) and (3).
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1648520
Signed-off-by: Laszlo Ersek
---
lib/write.
On 09/02/21 15:56, Richard W.M. Jones wrote:
> On Thu, Sep 02, 2021 at 03:51:24PM +0200, Laszlo Ersek wrote:
>> In commit 6d32773e8118 ("tests: Run the tests in parallel.", 2021-03-18),
>> the working directory relative to which "test-parallel-mount-local"
hat.com/archives/libguestfs/2021-September/msg00118.html
[2]
https://stackoverflow.com/questions/35924545/golang-cgo-panic-runtime-error-cgo-argument-has-go-pointer-to-go-pointer
[3] https://listman.redhat.com/archives/libguestfs/2021-September/msg00106.html
Cc: "Daniel P. Berrangé"
Cc
On 09/20/21 12:37, Daniel P. Berrangé wrote:
> On Mon, Sep 20, 2021 at 07:23:35AM +0200, Laszlo Ersek wrote:
>> The current "arg_string_list" and "free_string_list" implementations go
>> back to commit b6f01f32606d ("Add Go (language) bindings.", 201
On 10/12/21 19:54, Richard W.M. Jones wrote:
> On Tue, Oct 12, 2021 at 06:08:24PM +0200, Laszlo Ersek wrote:
>> Fixes: af9251086030886580cd5243afabf726d5e50fdc
>> Signed-off-by: Laszlo Ersek
>> ---
>> m4/guestfs-c.m4 | 2 +-
>> 1 file changed, 1 insertion(+), 1
Similar-to: b8bc491ff59cc1cc24a1935be99cee0c5edfb5be
Signed-off-by: Laszlo Ersek
---
inspector/virt-inspector.rng | 1 +
1 file changed, 1 insertion(+)
diff --git a/inspector/virt-inspector.rng b/inspector/virt-inspector.rng
index 0a81538e7c49..5b460b364593 100644
--- a/inspector/virt
Similar-to: cd08039d2427b584237265237c713d8cf46536a0
Signed-off-by: Laszlo Ersek
---
daemon/inspect_fs.ml| 2 ++
daemon/inspect_fs_unix.ml | 1 +
daemon/inspect_types.ml | 2 ++
daemon/inspect_types.mli| 1 +
generator/actions_inspection.ml | 4
5 files
resh "virt-inspector.rng" too.
Thanks,
Laszlo
Laszlo Ersek (2):
virt-inspector.rng: recognize "kalilinux" and "msdos" distros
virt-inspector.rng: Add support for Kylin (RHBZ#1995391).
inspector/virt-inspector.rng | 3 +++
1 file changed, 3 insertions(+)
base-commit:
As of libguestfs @ e597fc5317e0, the "string_of_distro" function
[daemon/inspect_types.ml] may output "kalilinux" and "msdos" beyond what
"virt-inspector.rng" currently accepts. Add these distro identifiers to
"virt-inspector.rng" now.
Libguestfs now depends (optionally) on Yara >= 4.0.0. Make this explicit
in the build configuration and the build documentation.
Thanks,
Laszlo
Laszlo Ersek (3):
build: fix the pkg-config identifier of the (optional) Yara library
build: eliminate the AC_CHECK_LIB / AC_CHECK_HEADER te
In a subsequent patch, we'll want to add a version requirement to the
PKG_CHECK_MODULES macro invocation, so at first, fix the pkg-config
identifier of Yara.
Fixes: 2e24129da37656706b5a1d3b6bc83d4c089740bb
Signed-off-by: Laszlo Ersek
---
m4/guestfs-daemon.m4 | 2 +-
1 file changed, 1 insertion(+),
e yara module of the daemon. Note the
version requirement in the documentation too.
Suggested-by: Eric Blake
Suggested-by: Richard W.M. Jones
Signed-off-by: Laszlo Ersek
---
docs/guestfs-building.pod | 2 +-
m4/guestfs-daemon.m4 | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff
_DECLS and AC_CHECK_TYPES
appear unable to check the parameter list of a function pointer typedef
(namely YR_CALLBACK_FUNC and YR_COMPILER_CALLBACK_FUNC). And writing a
dedicated test for this is overkill.
Signed-off-by: Laszlo Ersek
---
m4/guestfs-daemon.m4 | 9 +
1 file changed, 1 insertion
On 10/12/21 17:27, Richard W.M. Jones wrote:
> On Tue, Oct 12, 2021 at 09:16:10AM -0500, Eric Blake wrote:
>> On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote:
>>> The prototype of yara_rules_callback() is:
>>>
>>>> static int
>>>>
On 10/12/21 16:03, Eric Blake wrote:
> On Tue, Oct 12, 2021 at 12:36:26AM +0200, Laszlo Ersek wrote:
>> In order to shut up the compiler, just zero-initialize the buffer --
>> that's simpler than adding diagnostics pragmas. The "maybe-uninitialized"
>> warning is
expression
*(YR_CALLBACK_FUNC)NULL
has the desired function type.
Of course, evaluating this expression would be undefined behavior, but in
the GCC extension expression
typeof (*(YR_CALLBACK_FUNC)NULL)
the operand of the "typeof" operator is never evaluated, as it does not
have
t globally enabled (per
WARN_CFLAGS / WERROR_CFLAGS).
Signed-off-by: Laszlo Ersek
---
lib/proto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/proto.c b/lib/proto.c
index 3976e98b56d0..f798ece05e32 100644
--- a/lib/proto.c
+++ b/lib/proto.c
@@ -433,7 +433,7 @@ send_file_canc
While <https://libguestfs.org/guestfs-building.1.html> correctly documents
the "--enable-werror" option, the "./configure" help text itself doesn't.
Replace "--enable-error" with "--enable-werror" now.
Fixes: 0f54df53d26e4c293871fb30bce88511e1d61d6
the bug, but I don't notice gcc
warnings unless I ask for "-Werror" (I don't really "watch" the
build),
- it turns out the "./configure --help" hint on "-Werror" is inexact :)
Thanks,
Laszlo
Laszlo Ersek (3):
build: fix typo in "--enable-werror&qu
On 10/12/21 12:04, Richard W.M. Jones wrote:
>
> Thanks - ACK series.
Thanks! Merged as commit range 63c9cd933af7..e597fc5317e0.
> It may be that the bad help string ("error" instead of "werror") is
> present in other projects since I just copied the configure.ac when
> splitting libguestfs up.
On 10/12/21 00:36, Laszlo Ersek wrote:
> Currently, the Yara test case ("yara/test-yara-scan.sh") fails, with the
> following obscure error message:
>
>>> yara-scan /text.txt
>> libguestfs: error: deserialise_yara_detection_list:
>
> Namely, the
Fixes: af9251086030886580cd5243afabf726d5e50fdc
Signed-off-by: Laszlo Ersek
---
m4/guestfs-c.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/m4/guestfs-c.m4 b/m4/guestfs-c.m4
index 6b417c091c91..67a7f276df74 100644
--- a/m4/guestfs-c.m4
+++ b/m4/guestfs-c.m4
@@ -30,7 +30,7
to flip domains that use QXL to standard VGA (see the background
above).
(Further patches are expected for RHBZ#1961107.)
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1961107
Signed-off-by: Laszlo Ersek
---
lib/types.ml | 4 +---
lib/types.mli | 2 +-
2 files changed, 2 insertions(+), 4
On 10/20/21 18:46, Richard W.M. Jones wrote:
> On Wed, Oct 20, 2021 at 06:35:03PM +0200, Laszlo Ersek wrote:
>> * Background:
>>
>> We intend to stop virt-v2v from outputting converted domains with a QXL
>> display device [1]. The reason is that QXL is a complex d
On 10/13/21 12:06, Richard W.M. Jones wrote:
> This commit adds a new command line option (effective-url=true) which
> causes nbdkit-curl-plugin the first time it fetches a URL to update
> its internal 'url' variable with the CURLINFO_EFFECTIVE_URL. That
> means, the URL after all redirects have
On 10/13/21 12:06, Richard W.M. Jones wrote:
> Probably best to read this first:
> https://bugzilla.redhat.com/show_bug.cgi?id=2013000
>
> This adds an effective-url=true|false flag to nbdkit-curl-plugin. If
> true, the first time we fetch the URL, we fetch the "effective" URL
> (ie. the URL
uld apply more or less
to every error exit after this point.
> + }
> + if (test_start_nbdkit ("--filter=retry-request",
> + "curl", usp_param, "http://localhost/mirror;,
> + "retry-request-delay=1",
&
<= retries; ++i) { \
> + if (i > 0) { \
> +nbdkit_debug ("retry %u: waiting %u seconds before retrying", \
> + i, delay);
On 10/18/21 23:30, Richard W.M. Jones wrote:
> On Mon, Oct 18, 2021 at 10:12:49PM +0100, Richard W.M. Jones wrote:
>> On Mon, Oct 18, 2021 at 08:27:36PM +0200, Laszlo Ersek wrote:
>>> On 10/15/21 16:17, Richard W.M. Jones wrote:
>>>> +#ifndef HAVE_CURLOPT_UNIX_SOCKE
On 10/14/21 13:54, Richard W.M. Jones wrote:
>
> Series looks good, thanks.
>
> ACK
>
> Rich.
>
Thank you both; merged as commit range e597fc5317e0..f34bd6b12f85.
Laszlo
___
Libguestfs mailing list
Libguestfs@redhat.com
On 10/14/21 13:56, Richard W.M. Jones wrote:
> ACK
>
> Thanks,
> Rich.
>
Commit 305b02e7e74a.
Thanks!
Laszlo
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
On 10/14/21 13:57, Richard W.M. Jones wrote:
>
> ACK series
>
> It's kind of annoying that we need to keep this file up to date with
> libguestfs (considering they are now separate projects). But here we are ...
Merged as commit range a4930f5fad82..f041a5e24d8c.
Thank you!
Laszlo
tangent:
On 10/14/21 19:12, Richard W.M. Jones wrote:
> https://libguestfs.org/nbdkit-plugin.3.html#Callback-lifecycle
Impressive. Both the particular diagram, and the general documentation
quality in the v2v project set.
Laszlo
___
Libguestfs
only mentioning things that I managed to think of in addition to Eric's
comments (which is of course not to say I thought of *everything* that
Eric pointed out):
On 10/14/21 22:58, Richard W.M. Jones wrote:
> Similar to nbdkit-retry-filter, but this only retries single failing
> requests rather
On 10/14/21 23:28, Richard W.M. Jones wrote:
> On Thu, Oct 14, 2021 at 04:22:27PM -0500, Eric Blake wrote:
>> I know this is just an RFC, but the idea looks like it may have merit.
>> Would we want to merge this functionality into the 'retry' filter (a
>> single filter, with a knob on whether to
On 10/15/21 12:52, Richard W.M. Jones wrote:
> nbdkit definitely abuses macros. I guess you've not seen
> https://gitlab.com/nbdkit/nbdkit/-/blob/master/common/utils/vector.h
> yet.
>
> Or for even more excitement,
>
On 10/12/21 17:27, Richard W.M. Jones wrote:
> On Tue, Oct 12, 2021 at 09:16:10AM -0500, Eric Blake wrote:
>> On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote:
>>> The prototype of yara_rules_callback() is:
>>>
>>>> static int
>>>>
On 09/27/21 10:30, Richard W.M. Jones wrote:
> On Mon, Sep 27, 2021 at 08:34:56AM +0200, Laszlo Ersek wrote:
>> Per commit ac39fa292c31 ("v2v: Set machine type explicitly for outputs
>> which support it (RHBZ#1581428).", 2020-12-04), Windows 7 guests (which
>> ar
On 09/27/21 10:32, Richard W.M. Jones wrote:
> On Mon, Sep 27, 2021 at 08:34:58AM +0200, Laszlo Ersek wrote:
>> This is likely an omission from commit 05f780c16f01 ("v2v: support
>> configuration of viosock driver", 2021-02-26) -- if the converted Windows
>> guest d
On 09/27/21 10:00, Richard W.M. Jones wrote:
> On Mon, Sep 27, 2021 at 08:24:42AM +0200, Laszlo Ersek wrote:
>> Port libguestfs commit bf61bf7355d3 ("build: Allow OCaml programs using
>> libguestfs to be compiled against build dir.", 2020-03-12) to libnbd.
>>
(+libvirt-devel)
On 09/29/21 21:22, Richard W.M. Jones wrote:
> We currently partially install the virtio block drivers in the Windows
> guest (just enough to get the guest to boot on the target), and
> Windows itself re-installs the virtio block driver and other drivers
> it needs, and that's
On 10/01/21 15:01, Richard W.M. Jones wrote:
> On Fri, Oct 01, 2021 at 02:53:38PM +0200, Laszlo Ersek wrote:
>> Recent Pardus releases seem to have abandoned the original
>> "/etc/pardus-release" file, which the current Pardus detection, from
>> commit 233530
ase" specification
<https://www.freedesktop.org/software/systemd/man/os-release.html>, with
"ID=pardus". Extend the "distro_of_os_release_id" function accordingly.
Keep the original method for recognizing earlier releases.
Bugzilla: https://bugzilla.redhat.com/show_bug
Hi Rich,
(dropping libvirt-devel)
On 09/30/21 13:53, Richard W.M. Jones wrote:
> Also we don't currently try to find or rewrite /dev/disk/ paths in
> guest configuration files. The only rewriting that happens is for
> /dev/[hs]d* block device filenames and a few others. The actual code
> that
On 09/20/21 14:33, Daniel P. Berrangé wrote:
> On Mon, Sep 20, 2021 at 12:03:51PM +0100, Richard W.M. Jones wrote:
>> On Mon, Sep 20, 2021 at 11:37:02AM +0100, Daniel P. Berrangé wrote:
>>> What distro / go version do you see this on, as I can't reproduce
>>> this pointer problem with a standalone
On 09/20/21 13:04, Richard W.M. Jones wrote:
> For example 1024 is returned as "1K".
>
> This does not attempt to handle decimals or SI units. If the number
> isn't some multiple of a power of 1024 then it is returned as bytes (a
> flag is available to indicate this).
>
> I looked at both the
On 09/20/21 18:25, Laszlo Ersek wrote:
> On 09/20/21 13:04, Richard W.M. Jones wrote:
>> +#define HUMAN_SIZE_LONGEST 64
>
> (5) The integer constant expression
>
> ((sizeof (uint64_t) * 8 + 2) / 3 + 1)
>
> would be more frugal (but we might not care).
>
> I
ze);
> +if (human_size_flag)
> + fprintf (fp, "\texport-size: %" PRIi64 " (%s)\n", size, size_str);
> +else
> + fprintf (fp, "\texport-size: %" PRIi64 "\n", size);
> if (content)
> fprintf (fp, "\
On 09/20/21 18:39, Richard W.M. Jones wrote:
> On Mon, Sep 20, 2021 at 06:25:34PM +0200, Laszlo Ersek wrote:
>> On 09/20/21 13:04, Richard W.M. Jones wrote:
>>> +/* If you allocate a buffer of at least this length in bytes and pass
>>> + * it as the fi
On 09/20/21 17:30, Daniel P. Berrangé wrote:
> On Mon, Sep 20, 2021 at 05:23:30PM +0200, Laszlo Ersek wrote:
>> On 09/20/21 14:33, Daniel P. Berrangé wrote:
>>> On Mon, Sep 20, 2021 at 12:03:51PM +0100, Richard W.M. Jones wrote:
>>>> On Mon, Sep 20, 2021 at 11:37:
On 09/20/21 18:41, Eric Blake wrote:
> On Mon, Sep 20, 2021 at 06:32:29PM +0200, Laszlo Ersek wrote:
>>> +++ b/copy/test-verbose.sh
>>> @@ -28,11 +28,11 @@ requires nbdkit --version
>>> file=test-verbose.out
>>> cleanup_fn rm -f $file
>>>
>
)
>
> cat $file
>
> # Check some known strings appear in the output.
> grep '^nbdcopy: src: nbd_ops' $file
> -grep '^nbdcopy: src: size=0' $file
> +grep '^nbdcopy: src: size=1048576 (1M)' $file
> grep '^nbdcopy: dst: null_ops' $file
>
Ah, the test case is modified at once so it generate more interesting
output. Can you note that in the commit message please?
Acked-by: Laszlo Ersek
Thanks!
Laszlo
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
4,5 @@
>
>
>
> -
> +
>
> ./test-v2v-cdrom.sh: unexpected disk assignments
The conversion seems correct, but the test expectation is stale. Most
probably, commit d0267122e348 missed updating the test data. Do it now.
Fixes: d0267122e348202f6f
Using the argument from the "test-v2v-cdrom: update the CD-ROM's bus to
SATA in the converted domain" patch earlier in this series.
Fixes: d0267122e348202f6fac4d833f7448409e7129c9
Signed-off-by: Laszlo Ersek
---
tests/test-v2v-i-ova.xml | 2 +-
1 file changed, 1 insertion(+),
On 09/21/21 23:01, Richard W.M. Jones wrote:
> On Tue, Sep 21, 2021 at 09:29:39PM +0200, Laszlo Ersek wrote:
>> The current "arg_string_list" and "free_string_list" implementations go
>> back to commit b6f01f32606d ("Add Go (language) bindings.", 201
Port libguestfs commit bf61bf7355d3 ("build: Allow OCaml programs using
libguestfs to be compiled against build dir.", 2020-03-12) to libnbd.
This allows C+OCaml programs, such as virt-v2v, to find a just built, but
not installed, libnbd tree.
Signed-off-by: Laszlo Ersek
---
ocaml/M
rarily with
SKIP_TEST_V2V_IN_PLACE_SH=1,
I can run "make" and "make check" successfully in the virt-v2v tree.
Thanks,
Laszlo
Laszlo Ersek (4):
Makefile.am: use $(LIBNBD_LIBS) for linking OCaml programs
test-v2v-cdrom: update the CD-ROM's bus to SATA in the converted
domain
tes
;output" and "v2v" modules.
(This patch is similar to guestfs-tools commit 9b0f2e2d5893 ("Makefile.am:
use $(LIBGUESTFS_LIBS) for linking OCaml programs", 2021-09-06).)
Signed-off-by: Laszlo Ersek
---
convert/Makefile.am | 1 +
output/Makefile.am | 1 +
v2v/Makefile.am
e domain XML.
Fixes: 05f780c16f0135c657615520c2245b42de1efc3e
Signed-off-by: Laszlo Ersek
---
tests/test-v2v-i-ova.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/test-v2v-i-ova.xml b/tests/test-v2v-i-ova.xml
index a018fd44aee8..489c0ab09bcc 100644
--- a/tests/test-v2v-i-ova.xml
+++ b/tests/test-v2v-i-ov
On 09/20/21 07:23, Laszlo Ersek wrote:
> The "test-md-and-lvm-devices" test case creates, among other things, a
> RAID0 array (md127) that spans two *differently sized* block devices
> (sda1: 20MB, lv0: 16MB).
>
> In Linux v3.14, the layout of such arrays
On 09/20/21 07:23, Laszlo Ersek wrote:
> In commit 6d32773e8118 ("tests: Run the tests in parallel.", 2021-03-18),
> the "abs_srcdir" macro value that the 9p test would see changed from
> ".../tests/9p" to just ".../tests" -- the last comp
On 09/20/21 07:23, Laszlo Ersek wrote:
> According to xfs_admin(8):
>
>>-c 0|1 Enable (1) or disable (0) lazy-counters in the filesys‐
>> tem.
>>
>> Lazy-counters may not be disabled on Version 5 su‐
>>
1 - 100 of 1738 matches
Mail list logo
