[Libguestfs] libguestfs 1.14 update for Fedora 16

2011-11-09 Thread Richard W.M. Jones
I would like to put libguestfs 1.14 (the next stable branch) into Fedora 16. There should be no changes required in other packages at all, since libguestfs is API and ABI compatible for all releases, forever. Nor should users know the difference (except new features). But it's software, and we

Re: [Libguestfs] [PATCH] Add tune2fs support to libguestfs.

2011-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2011 at 12:16:20PM +, Mark McLoughlin wrote: Hey Rich, On Wed, 2011-11-09 at 18:23 +, Richard W.M. Jones wrote: At the moment OpenStack uses kpartx and nbd to resize filesystems and inject files to guests. I sincerely hope they don't allow untrusted users

Re: [Libguestfs] [PATCH] Add tune2fs support to libguestfs.

2011-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2011 at 01:48:53PM +, Mark McLoughlin wrote: Thanks for all that Rich. My takeaways are: 1) The current file injection and disk resizing code in OpenStack doesn't provide sufficient protection against the possibility of users exploiting vulnerabilities in the

Re: [Libguestfs] [PATCH 1/2] New API: list_md_devices

2011-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2011 at 02:19:11PM +, Matthew Booth wrote: +/* Look for directories under /sys/block matching md[0-9]* + * As an additional check, we also make sure they have a md subdirectory */ +int err = glob(PREFIX [0-9]* SUFFIX, GLOB_ERR, NULL, mds); +if (err ==

Re: [Libguestfs] [PATCH 2/2] Update list-filesystems to check md devices

2011-11-10 Thread Richard W.M. Jones
This looks fine, modulo binding the mdadm -C call as I said in the other email. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging,

Re: [Libguestfs] [PATCH 1/2] New API: list_md_devices

2011-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2011 at 02:53:48PM +, Richard W.M. Jones wrote: On Thu, Nov 10, 2011 at 02:19:11PM +, Matthew Booth wrote: +/* Look for directories under /sys/block matching md[0-9]* + * As an additional check, we also make sure they have a md subdirectory */ +int err

[Libguestfs] [PATCH 2/4] generator: Support testing the output of RHashtable functions.

2011-11-10 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com You can use TestOutputHashtable to test the output of RHashtable functions. --- generator/generator_capitests.ml | 38 ++ generator/generator_types.ml |6 ++ generator/generator_utils.ml |1 + 3

[Libguestfs] [PATCH 3/4] tune2fs-l: Add a test.

2011-11-10 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com --- generator/generator_actions.ml |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/generator/generator_actions.ml b/generator/generator_actions.ml index d3fa3e0..243ea9b 100644 --- a/generator/generator_actions.ml +++ b

[Libguestfs] [PATCH 1/4] daemon: Define safe ADD_ARG macro for constructing arg lists on the stack.

2011-11-10 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com --- daemon/btrfs.c | 18 +++- daemon/daemon.h | 12 daemon/luks.c | 82 --- daemon/mkfs.c | 59 +++- daemon/ntfs.c | 18

[Libguestfs] [PATCH 4/4] New API: Bind the tune2fs command.

2011-11-10 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com Previously we bound the 'tune2fs -l' command so that we could list out the tunables of an ext2/3/4 filesystem. Also commands like set_e2label and set_e2uuid used tune2fs. This commit binds many of the tunables that can be set using tune2fs

[Libguestfs] [PATCH 2/3] New API: list-md-devices.

2011-11-11 Thread Richard W.M. Jones
From: Matthew Booth mbo...@redhat.com Return a list of Linux MD devices detected in the guest. This API complements list_devices, list_partitions, list_lvs and list_dm_devices. --- appliance/init |3 ++ daemon/daemon.h |1 + daemon/guestfsd.c

Re: [Libguestfs] febootstrap-3.12 configure error on Fedora 16

2011-11-17 Thread Richard W.M. Jones
On Wed, Nov 16, 2011 at 10:19:09PM +0100, Andrzej Tobola wrote: On Wed, Nov 16, 2011 at 12:10:24PM +, Richard W.M. Jones wrote: On Mon, Nov 14, 2011 at 04:43:28PM +0100, Andrzej Tobola wrote: Hello Richard, Can't configure febootstrap-3.12 on Fedora 16: $ ./configure

Re: [Libguestfs] Possible issue with virt-v2v writing to wrong Windows registry control set

2011-11-17 Thread Richard W.M. Jones
On Thu, Nov 17, 2011 at 09:19:59AM -0600, Greg Scott wrote: But - doesn't the V2V process hack in some minimal viostor stuff to the new image file and then count on Windows properly loading up all the drivers after it boots? Yes. And there's an invisible firstboot at the tail end of the V2V

Re: [Libguestfs] Virtio-win RPM?

2011-11-19 Thread Richard W.M. Jones
On Fri, Nov 18, 2011 at 04:17:53PM -0600, Greg Scott wrote: But c'mon - every Windows system in the world has the directories mentioned below. This cannot be the first P2V attempt on the planet earth from a Windows system to RHEV. Asserting this isn't helping anyone to diagnose the problem.

Re: [Libguestfs] Virtio-win RPM?

2011-11-19 Thread Richard W.M. Jones
On Sat, Nov 19, 2011 at 08:13:19AM -0600, Greg Scott wrote: When the P2V fails, it apparently deletes everything it set up, so there is no guest to run virt-inspector. Where do I export LIBGUESTFS_TRACE=1? AFAIK, there isn't any interactive shell where I can do this. I edit virt-v2v.conf,

Re: [Libguestfs] libguestfs 1.14.2 is now in Fedora 16 updates-testing

2011-11-21 Thread Richard W.M. Jones
On Fri, Nov 18, 2011 at 08:40:16PM +, Richard W.M. Jones wrote: Please try it out! https://admin.fedoraproject.org/updates/libguestfs-1.14.2-1.fc16 I have run the automated tests on this package. However you'll probably have a whole variety of guests. If you have a little time to help

Re: [Libguestfs] Virt-resize error (ntfs) : Fatal error: exception Guestfs.Error(ntfsresize_opts: /dev/vda2)

2011-11-21 Thread Richard W.M. Jones
On Mon, Nov 21, 2011 at 03:44:51PM +, Morgan Cox wrote: root@kvm1:~# ntfsresize -v ntfsresize v2011.4.12AR.4 (libntfs-3g) The attempt ends with an error Fatal error: exception Guestfs.Error(ntfsresize_opts: /dev/vda2) I have attached a txt file of the results where I have used

Re: [Libguestfs] Virt-resize error (ntfs) : Fatal error: exception Guestfs.Error(ntfsresize_opts: /dev/vda2)

2011-11-21 Thread Richard W.M. Jones
On Mon, Nov 21, 2011 at 04:27:40PM +, Morgan Cox wrote: Hi. (sorry I replyed in last email rather than posting to the list..) Thanks - after issuing the commands it has correctly resized.. So it is possible to resize (with the extra steps..) Here is the output from the ntfsresize

Re: [Libguestfs] [PATCH 1/2] Create an MD variant of the dummy Fedora image

2011-11-22 Thread Richard W.M. Jones
General comment: Can you use git send-email to send the patches? I think I had problems applying those patches before, but now I'm finding it problematic to apply patches that are attachments. +# Make a (dummy) Fedora image using md devices +fedora-md1.img fedora-md2.img:

Re: [Libguestfs] [PATCH] Don't test r5t2 in mdadm test

2011-11-22 Thread Richard W.M. Jones
On Tue, Nov 22, 2011 at 04:32:01PM +, Matthew Booth wrote: test-mdadm.sh was failing when mdadm-detail tried to examine r5t2, which is missing a member. This patch simply skips testing the problematic array. Strange .. works for me, and 1.15.5 was recently built in Koji and the test was

Re: [Libguestfs] [PATCH v2] New API: md-stop for stopping MD devices

2011-11-24 Thread Richard W.M. Jones
On Thu, Nov 24, 2011 at 09:06:07PM +0800, Wanlong Gao wrote: This API is used to stop a md device. When we want to move a device to another md array, we should stop the md device which contained this device first. ACK. I'm going to run the tests and push it later. Thanks, Rich. -- Richard

[Libguestfs] mdadm / RHEL 6 error

2011-11-24 Thread Richard W.M. Jones
libguestfs: error: md_detail: mdadm: md device /dev/md125 does not appear to be active. FAIL: test-mdadm.sh Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual

Re: [Libguestfs] [PATCH] NFC: Cleanup iteration over fstab entries in inspect_fs_unix.c

2011-11-24 Thread Richard W.M. Jones
On Thu, Nov 24, 2011 at 02:48:46PM +, Matthew Booth wrote: Select non-comment labels using an augeas path to return the correct nodes in the first instance, rather than applying a regular expression to all results. Iterate over returned matches using a char** iterator. Use asprintf() to

Re: [Libguestfs] [PATCH 1/2] inspection: Handle MD devices in fstab

2011-11-29 Thread Richard W.M. Jones
On Tue, Nov 29, 2011 at 12:18:46PM +, Matthew Booth wrote: On 11/29/2011 08:58 AM, Richard W.M. Jones wrote: On Fri, Nov 25, 2011 at 05:32:42PM +, Matthew Booth wrote: static int check_fstab (guestfs_h *g, struct inspect_fs *fs) { + /* Generate a map of MD device paths listed

Re: [Libguestfs] [PATCH] out of tree build: ruby (second take)

2011-11-30 Thread Richard W.M. Jones
On Tue, Nov 29, 2011 at 08:59:14PM +0100, Hilko Bengen wrote: --- ruby/Rakefile.in | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) Thanks for the updated patch. ACKed and pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [PATCH] hivex: Added gnulib includes from builddir, as suggested by the Gnulib documentation; link hivexml against libgnu.

2011-12-01 Thread Richard W.M. Jones
Thanks, ACKed and pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

Re: [Libguestfs] [PATCH 1/2] inspection: Handle MD devices in fstab

2011-12-01 Thread Richard W.M. Jones
There are still memory leaks -- at least 4 -- revealed by valgrind. I tried to fix a few of them, but there are still more. If you run 'make extra-tests' it will run many tests under valgrind and you can look at extratests/valgrind.log to see the problems. Rich. -- Richard Jones,

Re: [Libguestfs] [PATCH] libguestfs: Added gnulib includes from builddir, as suggested by the Gnulib documentation

2011-12-01 Thread Richard W.M. Jones
Thanks -- I tested it and it seems to work fine. ACKed and pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc.

Re: [Libguestfs] [PATCH v2] NEW API: add blkid command to print the attributes of the device

2011-12-04 Thread Richard W.M. Jones
On Sun, Dec 04, 2011 at 07:45:07PM +0800, Wanlong Gao wrote: So, for the future of *libguestfs*, can we add something to separate these disto? For example we can remove the features like *-p* from RHEL5 but add it to RHEL6 or some fedora distos? I agree. To do this we need to detect at

Re: [Libguestfs] [PATCH v2] NEW API: add blkid command to print the attributes of the device

2011-12-04 Thread Richard W.M. Jones
On Sun, Dec 04, 2011 at 08:29:09PM +0800, Wanlong Gao wrote: On 12/04/2011 08:09 PM, Richard W.M. Jones wrote: On Sun, Dec 04, 2011 at 07:45:07PM +0800, Wanlong Gao wrote: So, for the future of *libguestfs*, can we add something to separate these disto? For example we can remove

Re: [Libguestfs] [hivex][PATCH 2/8] generator: Add new return type to ABI: RLenValue

2011-12-05 Thread Richard W.M. Jones
On Sun, Dec 04, 2011 at 04:45:27PM -0800, Alex Nelson wrote: On Oct 20, 2011, at 04:46 , Richard W.M. Jones wrote: On Thu, Oct 20, 2011 at 12:37:54PM +0100, Richard W.M. Jones wrote: of the tests could have picked up this type of bug. I think the tests (all of them) need to be changed

Re: [Libguestfs] [PATCH] blkid: split the RHEL5 which can't support some options

2011-12-05 Thread Richard W.M. Jones
On Mon, Dec 05, 2011 at 02:22:43PM +0800, Wanlong Gao wrote: RHEL5 shoult not support '-p', '-i' and '-o export' options. But we just split it according to the '-p' option. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/blkid.c | 80

Re: [Libguestfs] [PATCH] mdadm: fix a possible memory leak when error

2011-12-05 Thread Richard W.M. Jones
On Mon, Dec 05, 2011 at 02:30:35PM +0800, Wanlong Gao wrote: When add_string() error, it returned without free the *ret*. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/md.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon/md.c

Re: [Libguestfs] Problem to convert ESX guest into the KVM

2011-12-05 Thread Richard W.M. Jones
On Mon, Dec 05, 2011 at 09:49:19AM +, Matthew Booth wrote: As for ESX 5.x, we now know we need to pull in support for that to libvirt. For completeness, here is that BZ: https://bugzilla.redhat.com/show_bug.cgi?id=758231 Component: libvirt - Add support for ESXi 5 Rich. -- Richard Jones,

Re: [Libguestfs] guestmount - unable to get device geometry

2011-12-06 Thread Richard W.M. Jones
On Tue, Dec 06, 2011 at 06:44:51PM +0200, Evaggelos Balaskas wrote: Hi, i am trying to use libguestfs (libvirt/kvm etc) into archlinux. I think there is a warning and possible two different errors here. But it seems that i am keep getting this error warning: Unable to get device geometry

Re: [Libguestfs] guestmount - unable to get device geometry

2011-12-06 Thread Richard W.M. Jones
On Tue, Dec 06, 2011 at 09:33:46PM +0200, Evaggelos Balaskas wrote: I have: qemu-kvm 0.15.1 $ grep -i augeas /opt/dnl/sw/kvm/libguestfs-1.14.5/appliance/supermin.d/hostfiles [ empty ] $ grep -i augeas /usr/local/lib/guestfs/supermin.d/hostfiles [ empty ] This is surprising.

Re: [Libguestfs] guestmount - unable to get device geometry

2011-12-06 Thread Richard W.M. Jones
On Tue, Dec 06, 2011 at 11:29:35PM +0200, Evaggelos Balaskas wrote: On Tue, Dec 6, 2011 at 9:47 PM, Richard W.M. Jones rjo...@redhat.com wrote: (1) augeas is listed in appliance/packagelist _and_ confirmed #ifdef ARCHLINUX ... augeas ... #endif /* ARCHLINUX */ and that's

Re: [Libguestfs] guestmount - unable to get device geometry

2011-12-06 Thread Richard W.M. Jones
I'm downloading and installing ArchLinux again, but I can't promise I'll be able to fix this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports

Re: [Libguestfs] failure converting Linux ESX guest to KVM hypervisor

2011-12-08 Thread Richard W.M. Jones
On Wed, Dec 07, 2011 at 04:19:21PM -0500, John Kienle wrote: Hi, I am experiencing a failure running virt-v2v to convert a Linux guest on an ESX host to a RedHat KVM hypervisor. The output with the failure follows. Any help/guidance is appreciated. [root@storage-024 ~]# virt-v2v

Re: [Libguestfs] guestmount failing to mount a qcow image

2011-12-09 Thread Richard W.M. Jones
Never mind about filing the bug; I have pushed this commit: http://git.annexia.org/?p=libguestfs.git;a=commitdiff;h=54e91da925323642e67b8ce4b95899fe4b7a51c4 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without

Re: [Libguestfs] [PATCH] hivex: Fix Ruby bindings for 1.9; let the user explicitly choose ruby, rake

2011-12-09 Thread Richard W.M. Jones
On Wed, Dec 07, 2011 at 09:41:29PM +0100, Hilko Bengen wrote: --- configure.ac | 15 +-- generator/generator.ml | 12 ++-- ruby/Makefile.am | 11 ++- ruby/Rakefile.in |2 +- ruby/run-ruby-tests|4 ++-- 5 files changed, 32

Re: [Libguestfs] Help loading a corrupt vdi file

2011-12-14 Thread Richard W.M. Jones
On Tue, Dec 13, 2011 at 08:47:32PM -0500, op 157 wrote: I need to get access to some files I had on there using libguestfs on a Mint Virtualbox I have, and I'm trying to mount the bad vdi file to get access to everything, but that isn't working. I have this output from libguestfs-test-tool,

Re: [Libguestfs] febootstrap error ?

2011-12-14 Thread Richard W.M. Jones
On Tue, Dec 13, 2011 at 10:16:31PM +0200, Evaggelos Balaskas wrote: [root@mylaptop ~]# time libguestfs-test-tool [...] [01990ms] /usr/bin/qemu-kvm \ -drive file=/tmp/libguestfs-test-tool-sda-CDyryJ,format=raw,if=virtio \ -nodefconfig \ -machine accel=kvm:tcg \ -nodefaults \

[Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
[These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In order to make this usable from guestfish, we have to also bind the events API in guestfish. This is the first commit. Rich.

[Libguestfs] [PATCH 2/2] New APIs: mount-local, umount-local (FUSE support in the API).

2011-12-14 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com Add FUSE support directly to the API. Instead of needing to use the external 'guestmount' command, you can mount the libguestfs filesystem space on a local mountpoint using an API call from any language. Cc: Pádraig Brady p...@draigbrady.com

[Libguestfs] [PATCH 1/2] fish: Allow events to be processed in guestfish.

2011-12-14 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com Add 'event' and 'delete-event' commands so that event handlers can be registered and deleted in guestfish. The event handler is a shell script snippet or host command. Cc: Pádraig Brady p...@draigbrady.com --- generator/generator_actions.ml | 39

Re: [Libguestfs] Is there something wrong with http://git.annexia.org/

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 04:38:11PM +0800, Wanlong Gao wrote: Hi Rich: I just can't get access to http://git.annexia.org/ since this week. Is there something wrong? Yes, server died, and at the same time I'm about 500 miles away. I'll fix it this weekend. There is a backup of most

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 09:33:35AM +, Matthew Booth wrote: On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: [These two patches are for discussion only] Allow FUSE support to be used directly through the API. This is the second commit. In order to make this usable from guestfish, we

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 11:06:24AM +, Matthew Booth wrote: On 12/14/2011 10:36 AM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 09:33:35AM +, Matthew Booth wrote: On 12/14/2011 08:44 AM, Richard W.M. Jones wrote: [These two patches are for discussion only] Allow FUSE support

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 02:17:05PM +, Matthew Booth wrote: I still don't see why we need the guestfish event callbacks. because ... The guestfish change is only for us to do testing. [...] This is an extension of the libguestfs api in a direction which is best served by a different

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-14 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 04:03:16PM +, Matthew Booth wrote: On 12/14/2011 03:13 PM, Richard W.M. Jones wrote: On Wed, Dec 14, 2011 at 02:17:05PM +, Matthew Booth wrote: I still don't see why we need the guestfish event callbacks. because ... The guestfish change is only for us

Re: [Libguestfs] Proposed changes for OpenStack

2011-12-15 Thread Richard W.M. Jones
On Wed, Dec 14, 2011 at 05:07:04PM +, Matthew Booth wrote: guestmount_mount(g.sock_path(), '/tmp/dir') ...filesystem stuff... guestmount_umount('/tmp/dir') g.close() Note that there are no callbacks, no threads and no races. The code can be written sequentially. There are certainly

Re: [Libguestfs] Help loading a corrupt vdi file

2011-12-15 Thread Richard W.M. Jones
On Thu, Dec 15, 2011 at 12:16:19AM -0500, op 157 wrote: Thanks for the heads up. I managed to get my vdi file working after hacking together a repaired header! Hopefully this can help fix a bug that might exist though. I am running Mint 11 64 bit.Thanks Without looking too closely, I'd

[Libguestfs] Development and hosting arrangements (was: Re: Is there something wrong with http://git.annexia.org/)

2011-12-16 Thread Richard W.M. Jones
First of all, http://git.annexia.org/ should be back up now. The problem was 'pilot error' -- I accidentally removed libvirt from that server, which generally broke things. Secondly, starting in January I hope we can agree on some changes to the libguestfs development and hosting arrangement,

Re: [Libguestfs] febootstrap error ?

2011-12-17 Thread Richard W.M. Jones
On Tue, Dec 13, 2011 at 10:16:31PM +0200, Evaggelos Balaskas wrote: hi, i am not quite sure about the below error: [ 1320.506848] INFO: task init:1 blocked for more than 120 seconds. [ 1320.510069] echo 0 /proc/sys/kernel/hung_task_timeout_secs disables this message. FYI, this bug is

[Libguestfs] FYI: Changes to test directory names

2011-12-22 Thread Richard W.M. Jones
I'm going to rename some test directories to make the names more logical: * caution - tests/qemu This directory contains tests of qemu (safety and liveness). 'make check' will be changed so that this directory is tested first. At present, 'make check' happens to build images/ first which

Re: [Libguestfs] FYI: Changes to test directory names

2011-12-22 Thread Richard W.M. Jones
This has been done (in 1.15.12). It probably breaks a few things ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd

[Libguestfs] [PATCH] Security: Mitigate possible privilege escalation via SG_IO ioctl (CVE-2011-4127, RHBZ#757071)

2011-12-22 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com CVE-2011-4127 is a serious qemu kernel privilege escalation bug found by Paolo Bonzini. http://seclists.org/oss-sec/2011/q4/536 An untrusted guest kernel is able to issue special SG_IO ioctls on virtio devices which qemu passes through to the host

Re: [Libguestfs] [PATCH] extra-tests: add test-guests to prevent test error

2011-12-23 Thread Richard W.M. Jones
On Fri, Dec 23, 2011 at 11:46:21AM +0800, Wanlong Gao wrote: extra-tests is depending on tests-guests. We need guests/*.img when doing extra-tests. Yes it is, thanks. I'll add this shortly. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is

Re: [Libguestfs] [PATCH] gitignore: ignore the guestfs.* directory

2011-12-23 Thread Richard W.M. Jones
On Fri, Dec 23, 2011 at 02:54:04PM +0800, Wanlong Gao wrote: Let git ignore the guestfs.* directorys. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index

[Libguestfs] [PATCH 2/2] lib: Try harder to remove temporary directory along error paths (RHBZ#769680).

2011-12-23 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com --- src/appliance.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/src/appliance.c b/src/appliance.c index 5f77a56..57ff38f 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -450,8 +450,10

[Libguestfs] Remove temporary directories created during appliance building along error paths (RHBZ#769680)

2011-12-23 Thread Richard W.M. Jones
https://bugzilla.redhat.com/show_bug.cgi?id=769680 ___ Libguestfs mailing list Libguestfs@redhat.com https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] Kernel panic on Ubuntu 10.04

2011-12-23 Thread Richard W.M. Jones
On Fri, Dec 23, 2011 at 03:34:43PM +0400, Syndicut wrote: execl: /init: No such file or directory This error (which is confusing) means: either /init doesn't exist in the appliance, or /bin/sh which /init uses doesn't exist, or some library that /bin/sh needs doesn't exist. We can see by

Re: [Libguestfs] [PATCH 3/2] lib: remove all temporary directories may remained last launching

2011-12-23 Thread Richard W.M. Jones
On Fri, Dec 23, 2011 at 10:06:37PM +0800, Wanlong Gao wrote: If guestfish or other progs which launching appliance was aborted or killed last time, the temp dir will be remained, so delete it when this time launching. Prevent the possible waste of disk space. Signed-off-by: Wanlong Gao

Re: [Libguestfs] [PATCH 3/2] lib: remove all temporary directories may remained last launching

2011-12-23 Thread Richard W.M. Jones
On Fri, Dec 23, 2011 at 10:38:10PM +0800, Wanlong Gao wrote: On 12/23/2011 10:22 PM, Wanlong Gao wrote: On 12/23/2011 10:17 PM, Richard W.M. Jones wrote: On Fri, Dec 23, 2011 at 10:06:37PM +0800, Wanlong Gao wrote: If guestfish or other progs which launching appliance was aborted

[Libguestfs] Happy Holidays

2011-12-23 Thread Richard W.M. Jones
Myself and most people at Red Hat are on holiday for the whole of next week, back on the 3rd of January. libguestfs 1.15.14 is being pushed out to the usual place. Happy holiday, see you in January. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones

Re: [Libguestfs] libguestfs-test-tool say child process died on ubuntu 11.10 x64

2011-12-30 Thread Richard W.M. Jones
On Fri, Dec 30, 2011 at 09:57:36AM +0800, lzy@gmail.com wrote: library version: 1.15.11 [...] [17614ms] /usr/bin/kvm \ -drive file=/tmp/libguestfs-test-tool-sda-6OA3hT,cache=off,format=raw,if=virtio \ -nodefconfig \ -machine accel=kvm:tcg \ -nodefaults \

Re: [Libguestfs] Kernel panic on Ubuntu 10.04

2012-01-01 Thread Richard W.M. Jones
On Mon, Dec 26, 2011 at 06:43:55PM +0400, Syndicut wrote: - linux-image + linux-image-2.6.32-21-generic Actually, this is also (going to be) a problem. Linux 2.6.32 didn't have virtio-serial, so that kernel won't work with libguestfs. See my notes from compiling on Ubuntu 10.04 here:

Re: [Libguestfs] Kernel panic on Ubuntu 10.04

2012-01-02 Thread Richard W.M. Jones
On Mon, Jan 02, 2012 at 03:12:46AM +0400, Syndicut wrote: 02.01.2012 03:05, Richard W.M. Jones пишет: On Mon, Dec 26, 2011 at 06:43:55PM +0400, Syndicut wrote: execl: /init: No such file or directory This error means that /init or /bin/bash or some library needed by /bin/bash doesn't

Re: [Libguestfs] [PATCH] AUTHORS: add the email address for each authors

2012-01-03 Thread Richard W.M. Jones
On Tue, Jan 03, 2012 at 10:42:59AM +0800, Wanlong Gao wrote: Add the email address for authors. It will be better. It would be better. However AUTHORS is generated; see: http://git.annexia.org/?p=libguestfs.git;a=blob;f=Makefile.am;h=350c579a6d278afe4b03a1b734e7f6565b037531;hb=HEAD#l217 It

Re: [Libguestfs] [PATCH v2] AUTHORS: add the email address for each authors

2012-01-03 Thread Richard W.M. Jones
On Tue, Jan 03, 2012 at 11:41:43PM +0800, Wanlong Gao wrote: Add the email address for authors. It would be better. Thanks -- I've applied it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install

Re: [Libguestfs] [PATCH] fish: fix the Ctrl-\ causes guestfish to abort bug(RHBZ#596761)

2012-01-04 Thread Richard W.M. Jones
On Wed, Jan 04, 2012 at 04:07:07PM +0800, Wanlong Gao wrote: Hi Rich: Is this right? Yes, thanks! I've pushed it. If there are any other patches over the holidays that I missed, please let me know. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones

Re: [Libguestfs] [PATCH] gitignore: ignore the git related files

2012-01-04 Thread Richard W.M. Jones
On Wed, Jan 04, 2012 at 06:07:33PM +0800, Wanlong Gao wrote: This is over the holidays, too. *.eml for email picked patches other for orginal git patch related files. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- .gitignore |7 +++ 1 files changed, 7

Re: [Libguestfs] [PATCH] build: Fix automake warnings

2012-01-04 Thread Richard W.M. Jones
Thanks, I pushed it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

Re: [Libguestfs] [PATCH] Tempora mutantur, nos et mutamur in illis.

2012-01-04 Thread Richard W.M. Jones
On Wed, Jan 04, 2012 at 11:15:24AM +, Matthew Booth wrote: --- java/Makefile.inc |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, I've pushed it. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming blog:

Re: [Libguestfs] Development and hosting arrangements

2012-01-04 Thread Richard W.M. Jones
On Wed, Jan 04, 2012 at 09:36:04PM +0800, Wanlong Gao wrote: On 12/17/2011 06:33 AM, Richard W.M. Jones wrote: First of all, http://git.annexia.org/ should be back up now. The problem was 'pilot error' -- I accidentally removed libvirt from that server, which generally broke things

Re: [Libguestfs] Development and hosting arrangements

2012-01-04 Thread Richard W.M. Jones
On Wed, Jan 04, 2012 at 02:13:24PM +, Daniel P. Berrange wrote: On Wed, Jan 04, 2012 at 01:51:30PM +, Richard W.M. Jones wrote: For github it looks like someone has to pay: https://github.com/plans I use gitorious.org for most of my personal project hosting these days, as well

[Libguestfs] Development and hosting arrangements [new discussion thread]

2012-01-04 Thread Richard W.M. Jones
[Let's start a new thread for this so all the mail archives will appear in one place. Please follow up on any of these items, and hopefully we can formulate policy together.] (1) Policy for commits. [with thanks to Dan Berrange for helping to formulate this ...] In order to become a

Re: [Libguestfs] [hivex] [PATCH 8/8] hivexml: Add byte run reporting functions

2012-01-05 Thread Richard W.M. Jones
Thanks. I have pushed patches 1-7. I made a small change to the description of the function in patch 3. However this patch (8) cannot go in because it provokes many gcc warnings. Try configuring hivex with: ./configure --enable-gcc-warnings and recompile hivexml (possibly you'll only see

Re: [Libguestfs] [hivex] [PATCH 1/1] hivexml: Change value type output to standard names

2012-01-05 Thread Richard W.M. Jones
On Mon, Dec 12, 2011 at 10:03:57PM -0800, Alex Nelson wrote: Signed-off-by: Alex Nelson ajnel...@cs.ucsc.edu Unfortunately this patch doesn't compile cleanly with gcc warnings enabled, because of lots of const-correctness problems. Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [PATCH 2/3] launch: add a goto label when add_drive error

2012-01-09 Thread Richard W.M. Jones
On Mon, Jan 09, 2012 at 03:22:42PM +0800, Wanlong Gao wrote: Code cleanup. Add a goto label to simplify the code. Thanks, I've applied this. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot

Re: [Libguestfs] [PATCH 1/3] launch: move the filename checking to a wrapper

2012-01-09 Thread Richard W.M. Jones
On Mon, Jan 09, 2012 at 03:22:41PM +0800, Wanlong Gao wrote: Move the filename's comma character checking to a wrapper. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- src/launch.c | 18 -- 1 files changed, 12 insertions(+), 6 deletions(-) diff --git

Re: [Libguestfs] [PATCH v2 1/2] launch: move the filename checking to a wrapper

2012-01-09 Thread Richard W.M. Jones
Thanks, I've pushed all of these, with some modifications to fix things found by gcc warnings and the tests. Please use './configure --enable-gcc-warnings' and 'make check'! Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of

[Libguestfs] NOTE: New location for libguestfs, hivex and febootstrap git repositories

2012-01-10 Thread Richard W.M. Jones
I have moved all three repositories to new locations on github: https://github.com/libguestfs/libguestfs https://github.com/libguestfs/hivex https://github.com/libguestfs/febootstrap You don't need to reclone them (unless you want to). You can simply edit .git/config and adjust the URL to:

Re: [Libguestfs] [PATCH] Prepend local library path to LD_LIBRARY_PATH for tests, instead of replacing it

2012-01-11 Thread Richard W.M. Jones
On Tue, Jan 10, 2012 at 11:08:58PM +0100, Hilko Bengen wrote: Overwriting LD_LIBRARY_PATH broke some tests when running with fakeroot. [...] diff --git a/align/Makefile.am b/align/Makefile.am index 1dc9221..4afb2e4 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -72,7 +72,7 @@

Re: [Libguestfs] Testing github pull requests

2012-01-11 Thread Richard W.M. Jones
On Wed, Jan 11, 2012 at 11:35:50AM +, Matthew Booth wrote: I've sent a github pull request containing this patch here: https://github.com/libguestfs/libguestfs/pull/1 I'm interested to know if this interface could be useful to the project. We should be wary, though, of tying useful

Re: [Libguestfs] [PATCH 1/2] ext2: tweak the error returned message of resize2fs-M(BZ755729)

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 02:27:49PM +0800, Wanlong Gao wrote: Tweak the error message e2fsck -f and e2fsck -fy to e2fsck-f and e2fsck-fy. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- daemon/ext2.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-)

Re: [Libguestfs] [PATCH 2/2] NEW API: new api e2fsck-fy for resize2fs

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 02:27:50PM +0800, Wanlong Gao wrote: Add a new api e2fsck-fy for resize2fs. Sometimes e2fsck-f is not enough. If resiz2fs return the message says: Please use e2fsck-fy first, we just haven't such a command, it's so awkward. Since we are going to rewrite the error

Re: [Libguestfs] Libguestfs gobject bindings

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 11:40:40AM +, Daniel P. Berrange wrote: On Fri, Jan 13, 2012 at 11:33:33AM +, Matthew Booth wrote: On 01/13/2012 10:58 AM, Daniel P. Berrange wrote: On Thu, Jan 12, 2012 at 11:59:22AM +, Matthew Booth wrote: I'm currently working on gobject bindings for

Re: [Libguestfs] Libguestfs gobject bindings

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 12:28:50PM +, Daniel P. Berrange wrote: GIO provides all the infrastructure you need to do this, via the GSimpleAsyncResult object, and its g_simple_async_result_run_in_thread method. So it does; we could use that. Might want to only offer this for functions that

Re: [Libguestfs] [PATCH 2/3] NEW API: add a new api e2fsck

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 10:55:57PM +0800, Wanlong Gao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Add a new api e2fsck with two options: correct: same as '-p' option of e2fsck forceall: same as '-y' option of e2fsck API looks good in general. A few comments below. Thanks for

Re: [Libguestfs] [PATCH 1/3] ext2: tweak the error returned message of resize2fs-M(BZ755729)

2012-01-13 Thread Richard W.M. Jones
On Fri, Jan 13, 2012 at 10:55:56PM +0800, Wanlong Gao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Tweak the error message e2fsck -f and e2fsck -fy. Indicate the user to use the correct and/or forceall options. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

Re: [Libguestfs] [PATCH v2 3/3] e2fsck-f: change the internal to use e2fsck

2012-01-13 Thread Richard W.M. Jones
On Sat, Jan 14, 2012 at 12:03:45AM +0800, Wanlong Gao wrote: From: Wanlong Gao gaowanl...@cn.fujitsu.com Since we implement the new api e2fsck, just change the internal of e2fsck_f to use e2fsck now. v1-v2: use optargs_bitmask Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com ---

Re: [Libguestfs] [PATCH] New tool: virt-format

2012-01-17 Thread Richard W.M. Jones
On Tue, Jan 17, 2012 at 07:58:15PM +0200, Török Edwin wrote: - does it autodetect when disk is too large for MBR and GPT would be needed? No, but you're right that it should do. I'll make this change. - does it align partitions to SSD erase block size? (LVM is particularly tricky to

[Libguestfs] [PATCH 1/2] fish options parsing: Allow add_drives to be called multiple times.

2012-01-17 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com Don't leak old drv-device when add_drives is called multiple times. --- fish/options.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fish/options.c b/fish/options.c index 48c8e1c..f652389 100644 --- a/fish/options.c +++ b

[Libguestfs] [PATCH 2/2] New tool: virt-format: erase and make blank disks.

2012-01-17 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com This tool allows you to easily reformat a disk, creating a blank disk with optional partition, LVM and empty filesystem. --- .gitignore |4 + Makefile.am |3 +- configure.ac|1 + format/Makefile.am

[Libguestfs] [PATCH 1/4] ocaml: Add -Wno-missing-field-initializers to avoid a warning.

2012-01-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com --- configure.ac |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index fa97479..6e42423 100644 --- a/configure.ac +++ b/configure.ac @@ -141,6 +141,10 @@ if test $gl_gcc_warnings = yes

[Libguestfs] [PATCH 3/4] ocaml: Use automake to build the C part of the bindings.

2012-01-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com By arranging the C part of the bindings into a library, we can get automake to build it instead of using $(CC) directly. --- ocaml/Makefile.am | 28 +++- 1 files changed, 15 insertions(+), 13 deletions(-) diff --git a/ocaml

[Libguestfs] [PATCH 4/4] lib: Use -fvisibilty=hidden by default; only ABI symbols are now visible.

2012-01-18 Thread Richard W.M. Jones
From: Richard W.M. Jones rjo...@redhat.com http://gcc.gnu.org/wiki/Visibility --- configure.ac |6 generator/generator_c.ml | 70 - src/Makefile.am |8 +++-- 3 files changed, 48 insertions(+), 36 deletions(-) diff

Re: [Libguestfs] [PATCH 3/4] ocaml: Use automake to build the C part of the bindings.

2012-01-18 Thread Richard W.M. Jones
On Wed, Jan 18, 2012 at 05:15:16PM +0100, Jim Meyering wrote: Richard W.M. Jones wrote: By arranging the C part of the bindings into a library, we can get automake to build it instead of using $(CC) directly. diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am ... -AM_CPPFLAGS = -I

  1   2   3   4   5   6   7   8   9   10   >