Re: [Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

2013-12-18 Thread Richard W.M. Jones
On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: diff --git a/tests/regressions/rhbz563450.sh b/tests/regressions/rhbz563450.sh new file mode 100755 index 000..6fa6f2b --- /dev/null +++ b/tests/regressions/rhbz563450.sh @@ -0,0 +1,54 @@ +#!/bin/bash - +# libguestfs +#

[Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

2013-12-16 Thread Pino Toscano
The current add_cdrom way basically appends a new raw -cdrom /path parameter to the qemu invocation (even when using libvirt as backend), hence such images are seen as CD-ROM drives inside the appliance. However, there is no need for such particular behaviour, as they need to be handled as normal

Re: [Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

2013-12-14 Thread Richard W.M. Jones
On Fri, Dec 13, 2013 at 04:32:49PM +0100, Pino Toscano wrote: The current add_cdrom way basically appends a new raw -cdrom /path parameter to the qemu invocation (even when using libvirt as backend), hence such images are seen as CD-ROM drives inside the appliance. However, there is no need