Re: [Libguestfs] [PATCH nbdkit 3/4] tests/functions.sh.in: Rename variables $status and $i when running cleanups.

2020-05-26 Thread Eric Blake
On 5/22/20 4:32 PM, Richard W.M. Jones wrote: This causes conflicts if a cleanup hook happens to use a variable with the same name. I don't envy the debugging you used to finally spot this. Using 'local' in the cleanup hook helps, but so does this rename, so I like this approach. ---

[Libguestfs] [PATCH nbdkit 3/4] tests/functions.sh.in: Rename variables $status and $i when running cleanups.

2020-05-22 Thread Richard W.M. Jones
This causes conflicts if a cleanup hook happens to use a variable with the same name. --- tests/functions.sh.in | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/functions.sh.in b/tests/functions.sh.in index e2ef9701..b5c7d88b 100644 --- a/tests/functions.sh.in