Re: [Libguestfs] [PATCH v8 0/6] daemon: list_filesystems: filter out block devices which cannot hold filesystem.

2018-06-01 Thread Richard W.M. Jones


This all looks good now.  If it passes the tests then I'll push it.

Thanks, Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs


[Libguestfs] [PATCH v8 0/6] daemon: list_filesystems: filter out block devices which cannot hold filesystem.

2018-05-31 Thread Mykola Ivanets
v8: - Rebased on top of master.
v7: - Addresses comments after v6 series review.
v6: - Addresses comments after v5 series review.
- Large commit is splitted to more granular commits for better code review.
v5: - Addresses comments after v4 series review (part_get_mbr_part_type doesn't 
break original implementation in C).
- Rebased on top of master and little bit refactored for readability.
v4: - Rebased on top of master.
v3: - Rebased on top of master.
v2: - First implementation.
v1: - Initial discussion.

This patch series filters out block devices which cannot hold filesystems:
- partitioned MD devices;
- LDM partitions (only LDM volume can hold filesystem);
- Windows Logical Disk Manager data partition;
- Microsoft Reserved Partition;
- Windows Snapshot Partition;
- MBR extended partition.

Mykola Ivanets (6):
  daemon: Changing the way that we detect if a device contains
partitions.
  daemon: list-filesystems: Ignore partitioned MD devices.
  tests: list-filesystems command ignores partitioned MD devices.
  daemon: list-filesystems: Change the way we filter out LDM partitions.
  daemon: list-filesystems: Filter out Microsoft Reserved and Windows
Snapshot partitions.
  daemon: list-filesystems: Filter out MBR extended partitions.

 daemon/listfs.ml| 132 ++--
 tests/md/Makefile.am|   3 +-
 tests/md/test-partitioned-md-devices.sh |  79 ++
 3 files changed, 157 insertions(+), 57 deletions(-)
 create mode 100755 tests/md/test-partitioned-md-devices.sh

-- 
2.17.0

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs