Re: [Libguestfs] [libnbd PATCH] info: Prefer NBD_OPT_INFO when possible

2023-09-07 Thread Richard W.M. Jones
On Thu, Sep 07, 2023 at 11:35:27AM -0500, Eric Blake wrote: > On Tue, Sep 05, 2023 at 03:23:58PM +0100, Richard W.M. Jones wrote: > > On Tue, Sep 05, 2023 at 08:47:34AM -0500, Eric Blake wrote: > > > diff --git a/info/info-list-uris.sh b/info/info-list-uris.sh > > > index 0d6a16a0..d8ea9108 100755

Re: [Libguestfs] [libnbd PATCH] info: Prefer NBD_OPT_INFO when possible

2023-09-07 Thread Eric Blake
On Tue, Sep 05, 2023 at 03:23:58PM +0100, Richard W.M. Jones wrote: > On Tue, Sep 05, 2023 at 08:47:34AM -0500, Eric Blake wrote: > > diff --git a/info/info-list-uris.sh b/info/info-list-uris.sh > > index 0d6a16a0..d8ea9108 100755 > > --- a/info/info-list-uris.sh > > +++ b/info/info-list-uris.sh >

Re: [Libguestfs] [libnbd PATCH] info: Prefer NBD_OPT_INFO when possible

2023-09-05 Thread Richard W.M. Jones
On Tue, Sep 05, 2023 at 08:47:34AM -0500, Eric Blake wrote: > --- a/info/info-list-uris.sh > +++ b/info/info-list-uris.sh > @@ -22,7 +22,14 @@ set -e > set -x > > requires nbdkit --version > -requires nbdkit file --version > +# Avoid tickling a double-free bug in nbdkit 1.35.11 > +requires

Re: [Libguestfs] [libnbd PATCH] info: Prefer NBD_OPT_INFO when possible

2023-09-05 Thread Richard W.M. Jones
On Tue, Sep 05, 2023 at 08:47:34AM -0500, Eric Blake wrote: > diff --git a/info/info-list-uris.sh b/info/info-list-uris.sh > index 0d6a16a0..d8ea9108 100755 > --- a/info/info-list-uris.sh > +++ b/info/info-list-uris.sh > @@ -22,7 +22,14 @@ set -e > set -x > > requires nbdkit --version >

[Libguestfs] [libnbd PATCH] info: Prefer NBD_OPT_INFO when possible

2023-09-05 Thread Eric Blake
Now that libnbd supports extended headers, it is worth observing that the qemu implementation for NBD_CMD_BLOCK_STATUS that supports an extended header for filtering the server's response, as advertised by NBD_FLAG_BLOCK_STAT_PAYLOAD, is conditionally advertised. When using NBD_OPT_GO, the flag