Re: [Libguestfs] [libnbd PATCH 0/3] Simplify nbd_shutdown vs. opt mode

2023-09-05 Thread Eric Blake
On Fri, Sep 01, 2023 at 10:28:52PM +0100, Richard W.M. Jones wrote: > On Tue, Aug 29, 2023 at 05:20:40PM -0500, Eric Blake wrote: > > While working on a larger set of patches to make nbdinfo favor > > NBD_OPT_INFO over NBD_OPT_GO where possible (which requires use of > > nbd_set_opt_mode(,true) in

Re: [Libguestfs] [libnbd PATCH 0/3] Simplify nbd_shutdown vs. opt mode

2023-09-01 Thread Richard W.M. Jones
On Tue, Aug 29, 2023 at 05:20:40PM -0500, Eric Blake wrote: > While working on a larger set of patches to make nbdinfo favor > NBD_OPT_INFO over NBD_OPT_GO where possible (which requires use of > nbd_set_opt_mode(,true) in more cases), I noticed that it got unwieldy > to have to pick the correct

[Libguestfs] [libnbd PATCH 0/3] Simplify nbd_shutdown vs. opt mode

2023-08-29 Thread Eric Blake
While working on a larger set of patches to make nbdinfo favor NBD_OPT_INFO over NBD_OPT_GO where possible (which requires use of nbd_set_opt_mode(,true) in more cases), I noticed that it got unwieldy to have to pick the correct shutdown function in all code paths. So I propose making the API