Re: [Libguestfs] [PATCH nbdkit 1/2] tests: Remove QEMU_IO / HAVE_QEMU_IO.

2018-03-07 Thread Eric Blake
On 03/07/2018 09:39 AM, Richard W.M. Jones wrote: Needs rebasing now that the test no longer relies on file-data. Also, I still appreciate being able to override $QEMU_IO from the command line (to point to an alternative version on the fly), so even though I agree with your Makefile changes, I d

Re: [Libguestfs] [PATCH nbdkit 1/2] tests: Remove QEMU_IO / HAVE_QEMU_IO.

2018-03-07 Thread Richard W.M. Jones
On Wed, Mar 07, 2018 at 08:39:05AM -0600, Eric Blake wrote: > On 03/06/2018 06:21 AM, Richard W.M. Jones wrote: > >This is for consistency with qemu-img, socat, ss, etc where we test > >for these binaries at run time. > >--- > > configure.ac| 4 > > tests/Makefile.am

Re: [Libguestfs] [PATCH nbdkit 1/2] tests: Remove QEMU_IO / HAVE_QEMU_IO.

2018-03-07 Thread Eric Blake
On 03/06/2018 06:21 AM, Richard W.M. Jones wrote: This is for consistency with qemu-img, socat, ss, etc where we test for these binaries at run time. --- configure.ac| 4 tests/Makefile.am | 8 +++- tests/test-parallel-file.sh | 20 +--- t