Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-07-06 Thread Sam Eiderman
On Mon, Jul 6, 2020 at 2:39 PM Richard W.M. Jones wrote: > > Hi Sam, > > I was doing some work on the Python bindings, starting with removing > support for Python 2 since it's EOL. I thought I would have a look at > this patch. > This is great, I'm currently working on adding python3 type hints

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-07-06 Thread Richard W.M. Jones
Hi Sam, I was doing some work on the Python bindings, starting with removing support for Python 2 since it's EOL. I thought I would have a look at this patch. So firstly I think the last version posted is: https://www.redhat.com/archives/libguestfs/2020-April/msg00190.html My impression of

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-30 Thread Sam Eiderman
I see, well the problem is that for some reason SUSE11 did not encode some of their packages as UTF8 but rather used Latin-1. There are multiple possible solutions here: 1. Do not decode application description as a string, but rather as a byte array - I am not sure regarding other than Python

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-30 Thread Sam Eiderman
Regarding reproducing this - if possible, simply install SLES11 SP4 from CD. I'm not sure how easy it will be for you nowadays since Suse just removed SLES11 from their Downloads page. Sam On Tue, Jun 30, 2020 at 11:53 AM Sam Eiderman wrote: > Hey Pino, > > Can you search for the previous

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-30 Thread Sam Eiderman
Hey Pino, Can you search for the previous patches I submitted? I had some discussions regarding this with Daniel and Nir. Thanks! On Tue, Jun 30, 2020 at 11:43 AM Pino Toscano wrote: > On Sunday, 26 April 2020 20:14:03 CEST Sam Eiderman wrote: > > The python3 bindings create PyUnicode objects

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-30 Thread Sam Eiderman
gentle ping On Wed, Jun 3, 2020 at 2:52 PM Sam Eiderman wrote: > On Wed, May 13, 2020 at 10:06 PM Richard W.M. Jones > wrote: > > > > On Sun, Apr 26, 2020 at 09:14:03PM +0300, Sam Eiderman wrote: > > > The python3 bindings create PyUnicode objects from application strings > > > on the guest

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-30 Thread Pino Toscano
On Tuesday, 30 June 2020 10:53:54 CEST Sam Eiderman wrote: > Hey Pino, > > Can you search for the previous patches I submitted? I had some discussions > regarding this with Daniel and Nir. Sure, I did read those, and I took it into account. What I said does not invalidate nor contradict that.

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-30 Thread Pino Toscano
On Sunday, 26 April 2020 20:14:03 CEST Sam Eiderman wrote: > The python3 bindings create PyUnicode objects from application strings > on the guest (i.e. installed rpm, deb packages). > It is documented that rpm package fields such as description should be > utf8 encoded - however in some cases

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-06-03 Thread Sam Eiderman
On Wed, May 13, 2020 at 10:06 PM Richard W.M. Jones wrote: > > On Sun, Apr 26, 2020 at 09:14:03PM +0300, Sam Eiderman wrote: > > The python3 bindings create PyUnicode objects from application strings > > on the guest (i.e. installed rpm, deb packages). > > It is documented that rpm package fields

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-05-13 Thread Sam Eiderman
bump On Sun, Apr 26, 2020 at 9:14 PM Sam Eiderman wrote: > > The python3 bindings create PyUnicode objects from application strings > on the guest (i.e. installed rpm, deb packages). > It is documented that rpm package fields such as description should be > utf8 encoded - however in some cases

Re: [Libguestfs] [PATCH v3] python: Fix UnicodeError in inspect_list_applications2() (RHBZ#1684004)

2020-05-13 Thread Richard W.M. Jones
On Sun, Apr 26, 2020 at 09:14:03PM +0300, Sam Eiderman wrote: > The python3 bindings create PyUnicode objects from application strings > on the guest (i.e. installed rpm, deb packages). > It is documented that rpm package fields such as description should be > utf8 encoded - however in some cases