Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-11 Thread Richard W.M. Jones
On Sun, Mar 11, 2018 at 10:54:14PM +0100, Tomáš Golembiovský wrote: > Hi, > > one more thing. > > On Sun, 11 Mar 2018 13:17:47 +0100 > Tomáš Golembiovský wrote: > > > > + > > > +def close(h): > > > +global params > > > + > > > +http = h['http'] > > > +connection = h['connection'] >

Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-11 Thread Tomáš Golembiovský
Hi, one more thing. On Sun, 11 Mar 2018 13:17:47 +0100 Tomáš Golembiovský wrote: > > + > > +def close(h): > > +global params > > + > > +http = h['http'] > > +connection = h['connection'] > > + > > +http.close() > > + > > +# If we didn't fail, then finalize the transfer. > >

Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-11 Thread Tomáš Golembiovský
On Thu, 8 Mar 2018 09:37:19 + "Richard W.M. Jones" wrote: > PROBLEMS: > - Target cluster defaults to "Default". > - Using Insecure = True, is that bad? Since you have --rhv-cafile mandatory, there is no reason to set Insecure=True. > - -of qcow2 does not work, with multiple problems >

Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-09 Thread Ondra Machacek
On 03/08/2018 12:57 PM, Nir Soffer wrote: On Thu, Mar 8, 2018 at 11:37 AM Richard W.M. Jones > wrote: PROBLEMS:  - Target cluster defaults to "Default".  - Using Insecure = True, is that bad?  - -of qcow2 does not work, with multiple problems  

Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-09 Thread Ondra Machacek
On 03/09/2018 11:14 AM, Richard W.M. Jones wrote: On Fri, Mar 09, 2018 at 11:05:09AM +0100, Ondra Machacek wrote: On 03/08/2018 12:57 PM, Nir Soffer wrote: On Thu, Mar 8, 2018 at 11:37 AM Richard W.M. Jones +# Connect to the server. +connection = sdk.Connection( +    url = params[

Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-09 Thread Richard W.M. Jones
On Fri, Mar 09, 2018 at 11:05:09AM +0100, Ondra Machacek wrote: > On 03/08/2018 12:57 PM, Nir Soffer wrote: > >On Thu, Mar 8, 2018 at 11:37 AM Richard W.M. Jones > >+# Connect to the server. > >+connection = sdk.Connection( > >+    url = params['output_conn'], > >+    username = use

Re: [Libguestfs] [PATCH v5 4/4] v2v: Add -o rhv-upload output mode.

2018-03-08 Thread Nir Soffer
On Thu, Mar 8, 2018 at 11:37 AM Richard W.M. Jones wrote: > PROBLEMS: > - Target cluster defaults to "Default". > - Using Insecure = True, is that bad? > - -of qcow2 does not work, with multiple problems > - Need to attach disks to VMs somehow > > This adds a new output mode to virt-v2v. vir