Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-23 Thread Richard W.M. Jones
On Mon, Jun 19, 2017 at 11:59:11AM +0100, Richard W.M. Jones wrote: > On Mon, Jun 19, 2017 at 10:25:33AM +0200, Pino Toscano wrote: > > On Friday, 16 June 2017 16:58:53 CEST Richard W.M. Jones wrote: > > > On Fri, Jun 16, 2017 at 03:24:55PM +0200, Pino Toscano wrote: > > > > On Thursday, 15 June

Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-19 Thread Richard W.M. Jones
On Mon, Jun 19, 2017 at 10:25:33AM +0200, Pino Toscano wrote: > On Friday, 16 June 2017 16:58:53 CEST Richard W.M. Jones wrote: > > On Fri, Jun 16, 2017 at 03:24:55PM +0200, Pino Toscano wrote: > > > On Thursday, 15 June 2017 19:05:55 CEST Richard W.M. Jones wrote: > > > > Those cleanups which

Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-19 Thread Pino Toscano
On Friday, 16 June 2017 16:58:53 CEST Richard W.M. Jones wrote: > On Fri, Jun 16, 2017 at 03:24:55PM +0200, Pino Toscano wrote: > > On Thursday, 15 June 2017 19:05:55 CEST Richard W.M. Jones wrote: > > > Those cleanups which only depend on libc, gnulib or libxml2 are split > > > out into a

Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-16 Thread Richard W.M. Jones
On Fri, Jun 16, 2017 at 03:24:55PM +0200, Pino Toscano wrote: > On Thursday, 15 June 2017 19:05:55 CEST Richard W.M. Jones wrote: > > Those cleanups which only depend on libc, gnulib or libxml2 are split > > out into a separate common/cleanups directory. > > --- > > IMHO a single cleanups.c

Re: [Libguestfs] [PATCH v6 05/41] utils: Split out cleanups into common/cleanups.

2017-06-16 Thread Pino Toscano
On Thursday, 15 June 2017 19:05:55 CEST Richard W.M. Jones wrote: > Those cleanups which only depend on libc, gnulib or libxml2 are split > out into a separate common/cleanups directory. > --- IMHO a single cleanups.c source should be enough, otherwise it's overly split... -- Pino Toscano