Re: [Libguestfs] [PATCH v7 2/9] lib: extract osinfo DB traversing API

2017-07-20 Thread Cedric Bosdonnat
On Fri, 2017-07-07 at 15:04 +0200, Pino Toscano wrote:
> On Monday, 19 June 2017 10:48:30 CEST Cédric Bosdonnat wrote:
> > Split lib/osinfo.c to provide an API for other pieces of code (namely
> > mllib) to reuse it. The ISO-related processing is thus moved into a
> > lib/osinfo-iso.c file.
> > ---
> 
> This (and patch #3) conflict with Rich's patch to deprecate the
> inspection of ISO images. So we should decide what is the fate of this
> code:
> a) move the C code as-is to virt-builder
> b) apply this (and following) patch to make it a bit more general
> c) write the osinfo-db code in OCaml, directly in virt-builder
> d) any other solution I missed above

So you mean that this code was bound to die sooner or later? Do we need
the osinfo data in the virt-builder index after all?

BTW, I'm currently rebasing the patch series on master... and it's painful.

--
Cedric

___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

Re: [Libguestfs] [PATCH v7 2/9] lib: extract osinfo DB traversing API

2017-07-07 Thread Pino Toscano
On Monday, 19 June 2017 10:48:30 CEST Cédric Bosdonnat wrote:
> Split lib/osinfo.c to provide an API for other pieces of code (namely
> mllib) to reuse it. The ISO-related processing is thus moved into a
> lib/osinfo-iso.c file.
> ---

This (and patch #3) conflict with Rich's patch to deprecate the
inspection of ISO images. So we should decide what is the fate of this
code:
a) move the C code as-is to virt-builder
b) apply this (and following) patch to make it a bit more general
c) write the osinfo-db code in OCaml, directly in virt-builder
d) any other solution I missed above

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs