Re: [Libhugetlbfs-devel] [PATCH 05/14] stop exporting kernel detection

2008-10-20 Thread Mel Gorman
On (17/10/08 17:14), Andy Whitcroft didst pronounce: > Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> Acked-by: Mel Gorman <[EMAIL PROTECTED]> > --- > Makefile |2 +- > hugetlbfs.h |9 - > kernel-features.c|1 + > libhugetlbfs_privutils

Re: [Libhugetlbfs-devel] [PATCH 05/14] stop exporting kernel detection

2008-10-17 Thread Adam Litke
This comment is not specific to this patch, but the thought came into my head while reading this patch: I think developers (myself included) will sometimes get confused as to whether their new function should go into libhugetlbfs_internal.h, libhugetlbfs_privutils.h, hugetlbfs.h, or no header at a

[Libhugetlbfs-devel] [PATCH 05/14] stop exporting kernel detection

2008-10-17 Thread Andy Whitcroft
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> --- Makefile |2 +- hugetlbfs.h |9 - kernel-features.c|1 + libhugetlbfs_privutils.h | 10 ++ 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/Makefile b/Makefile i