I appreciate any comments!
thank you,
Avantika
Add the --hard flag to hugeadm that is set with --pool-pages-(min|max). When
the flag is set, try multiple times adjust the pool size to the count
specified.
Signed-off-by: Avantika Mathur
---
Index: libhugetlbfs/hugeadm.c
Mel Gorman wrote:
On Thu, Mar 19, 2009 at 09:53:39PM -0700, Avantika Mathur wrote:
Patch cleaniness issues. Not a massive deal here but a kernel
submission patch would attract complaint and we try and keep to the same
standard.
Rename subject to something like
hugeadm: Retry allocation
Mel Gorman wrote:
On Fri, Mar 20, 2009 at 05:48:25PM -0700, Avantika Mathur wrote:
Mel Gorman wrote:
Fix it up so that --hard can be specified anywhere and I'll be happy.
I've made it so --hard can be specified anywhere with your suggestion, and also
updated man
o adds support for multiple options to hugeadm to be
specified in any order. Without this the verbose option would have to be
specified before any other options.
Signed-off-by: Avantika Mathur
---
Index: libhugetlbfs-save/hug
d and activated on disk for the duration of a positive resize of
the minimum pool size. After the resize is completed, the swap is turned off
and swapfile removed.
Signed-off-by: Avantika Mathur
---
Index: libhugetlbfs-tempswap-new/huge
Eric B Munson wrote:
On Fri, 22 May 2009, Avantika Mathur wrote:
Comments are inline.
Thanks for the comments. An update patch incorporating your feedback, and some
comments are below.
thanks
Avantika
+
+ f = fopen(file, "w");
+ if (!f) {
+
ature.
- update man page entry
- Use the opt_temp_swap flag as an indicator of whether the swap was
initialized successfully, preventing rem_temp_swap from being called if
the swap was not added.
- use exclusive open for the swap file - do not stop execution on file
open failure.
Signed-off-by: Ava
Comment is inline
thanks
Avantika
Eric B Munson wrote:
> The return value from the system() call in add_temp_swap() was
> being ignored, generating compile time warnings. This patch adds
> a check of the return value to make sure that all is well. It also
> changes the ERROR reporting in add_t
Mel Gorman wrote:
>> +
>> +/* swapsize is 5 hugepages (in KB) */
>> +swap_size = gethugepagesize() * 5;
>> +buf = malloc(swap_size);
>> +memset(buf, 0, swap_size);
>> +fwrite(buf, sizeof(char), swap_size, f);
>> +free(buf);
>> +fclose(f);
>>
>
> Just out of curious
Update to the add-temp-swap feature
- use page size of pool being resized to as increment for size of swap space
- allow optional user input of the size of the swap in number of hugepages.
by default it is 5 huge pages.
- update man page
Signed-off-by: Avantika Mathur
---
Index
: Avantika Mathur
---
Index: libhugetlbfs/hugeadm.c
===
--- libhugetlbfs.orig/hugeadm.c 2009-06-29 01:52:26.0 -0700
+++ libhugetlbfs/hugeadm.c 2009-06-29 02:10:53.0 -0700
@@ -32,6 +32,7 @@
#include
#include
#include
Adding the --perist option which is specified with --add-ramdisk-swap
or --add-temp-swap, to make the swap space created, permanent after the
pool resize is completed.
Signed-off-by: Avantika Mathur
---
Index: libhugetlbfs/hugeadm.c
The string returned from add_ramdisk_swap points to local memory that
can be overwritten after return. This patch makes a global string
ramdisk_list which is used to store the list of ramdisks swap is
initialized on.
Signed-off-by: Avantika Mathur
diff -uprNb libhugetlbfs.orig/hugeadm.c
cost measured in cycles.
Signed-off-by: Avantika Mathur
---
TLBC/OpCollect.pm | 40 ++--
cpupcstat | 28
oprofile_map_events.pl | 13 ++---
3 files changed, 60 insertions(+), 21 deletions(-)
diff -uprN
Fix parameters being passed to _get_column(). $report is no longer
passed because it is global.
Signed-off-by: Avantika Mathur
---
OpCollect.pm |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: libhugetlbfs/TLBC/OpCollect.pm
runs tlbmiss_cost.sh to generate cost, uses this value and caches the result
for later runs.
If the user specifies a file using the --cost-config, uses the tlbmiss cost
stored in this file.
Signed-off-by: Avantika Mathur
---
cpupcstat | 25 -
1 file changed, 16
cpupcstat to pass the vmlinux value used in cpupcstat.
Signed-off-by: Avantika Mathur
---
contrib/tlbmiss_cost.sh |9 +
cpupcstat |2 +-
2 files changed, 6 insertions(+), 5 deletions(-)
Index: libhugetlbfs/cpupcstat
17 matches
Mail list logo
