Re: [Libmesh-devel] astyle

2010-12-02 Thread Tim Kroeger
On Thu, 2 Dec 2010, Roy Stogner wrote: > This hurts the usefulness of "svn blame". Whoever commits the first > massive set of astyle changes suddenly looks responsible for a whole > lot of code where he merely touched whitespace. > > This hurts the usefulness of "svn diff -r A:B" where A is any r

Re: [Libmesh-devel] Is there an Exodus expert in the crowd?

2010-12-02 Thread Derek Gaston
On Dec 2, 2010, at 5:09 PM, Roy Stogner wrote: > Comment out the Gnuplot case in ex4, so that it falls through to > Exodus even with dimension 1, then the first execution in "make run" > will hit the same error we do. Will do. Derek -

Re: [Libmesh-devel] astyle

2010-12-02 Thread Chetan Jhurani
> -Original Message- > From: Roy Stogner [mailto:[email protected]] > > There are nearly ONE HUNDRED THOUSAND lines of changes. No way are we > looking over every one of them. Does everyone want to trust that > astyle doesn't break any C++, or that our regression and unit tests

Re: [Libmesh-devel] astyle

2010-12-02 Thread John Peterson
On Thu, Dec 2, 2010 at 4:27 PM, Roy Stogner wrote: > > This hurts the usefulness of "svn diff -r A:B" where A is any revision > number before the whitespace change and B is any revision number > after. FYI: you can get diff to ignore whitespace changes by passing -x -w: svn diff -rPREV -x -w inc

Re: [Libmesh-devel] astyle

2010-12-02 Thread Boyce Griffith
On 12/2/10 5:27 PM, Roy Stogner wrote: > There are nearly ONE HUNDRED THOUSAND lines of changes. No way are we > looking over every one of them. Does everyone want to trust that > astyle doesn't break any C++, or that our regression and unit tests > have enough coverage to catch any breakage? Al

Re: [Libmesh-devel] inhomogenous DOF constraints

2010-12-02 Thread Boyce Griffith
On 12/2/10 8:03 PM, Boyce Griffith wrote: > Hi, Folks -- > > I'm trying to add support for inhomogeneous DOF constraints to DofMap. I > think I am almost there --- if I add the constraints after calling > init(), everything appears to work. These constraints are quite simple > --- they are just i

[Libmesh-devel] inhomogenous DOF constraints

2010-12-02 Thread Boyce Griffith
Hi, Folks -- I'm trying to add support for inhomogeneous DOF constraints to DofMap. I think I am almost there --- if I add the constraints after calling init(), everything appears to work. These constraints are quite simple --- they are just inhomogeneous Dirichlet boundary conditions. I've

Re: [Libmesh-devel] Is there an Exodus expert in the crowd?

2010-12-02 Thread Roy Stogner
On Thu, 2 Dec 2010, Derek Gaston wrote: > We will do this. Thanks! > Can you give me a simple test case? Comment out the Gnuplot case in ex4, so that it falls through to Exodus even with dimension 1, then the first execution in "make run" will hit the same error we do. --- Roy ---

Re: [Libmesh-devel] New Quadrature Rule

2010-12-02 Thread John Peterson
On Thu, Dec 2, 2010 at 9:20 AM, Boyce Griffith wrote: > > > On 11/16/10 2:24 PM, Derek Gaston wrote: >> >> On Nov 16, 2010, at 10:27 AM, Boyce Griffith wrote: >> >>> Is adding qrule->need_reinit() the only change that you are making to >>> QBase?  I am probably missing something, but it seems like

Re: [Libmesh-devel] Is there an Exodus expert in the crowd?

2010-12-02 Thread Derek Gaston
We will do this. Can you give me a simple test case? We can probably have it done early next week (we are currently migrant workers while we have our offices remodeled... It should be finished on Monday... But until it is we can't do much work!) Derek Sent from my iPad On Dec 2, 2010, at 2:44

[Libmesh-devel] astyle

2010-12-02 Thread Roy Stogner
On Thu, 2 Dec 2010, Boyce Griffith wrote: > It looks like Artistic Style's GNU setting more-or-less conforms to the > libMesh style --- you can invoke it via: > > astyle --style=gnu -r $PWD/*.C $PWD/*.h > > or possibly: > > astyle --style=gnu --max-instatement-indent=79 \ > --min-co

[Libmesh-devel] Is there an Exodus expert in the crowd?

2010-12-02 Thread Roy Stogner
Anyone who'd be able to quickly add support for 1D elements, specifically? Our code's support for plotting postprocessed boundary data drops dead when the boundary is of a 2D simulation and the plotting format is ExodusII. I've mostly managed to avoid digging through that code or that file forma

Re: [Libmesh-devel] xdr_io with multiple boundary ids per side

2010-12-02 Thread Boyce Griffith
On 12/2/10 1:11 PM, Roy Stogner wrote: > > On Thu, 2 Dec 2010, Boyce Griffith wrote: > >> OK --- attached is a patch. Most of it is just re-indenting. (I wasn't >> always careful about using tabs instead of spaces --- is there a >> convention that you all prefer to use?) > > The ideal thing to do

Re: [Libmesh-devel] xdr_io with multiple boundary ids per side

2010-12-02 Thread Roy Stogner
On Thu, 2 Dec 2010, Boyce Griffith wrote: > OK --- attached is a patch. Most of it is just re-indenting. (I wasn't > always careful about using tabs instead of spaces --- is there a convention > that you all prefer to use?) The ideal thing to do is tabs for indentation, spaces for alignment.

Re: [Libmesh-devel] xdr_io with multiple boundary ids per side

2010-12-02 Thread Boyce Griffith
On 12/2/10 10:17 AM, Roy Stogner wrote: On Thu, 2 Dec 2010, Boyce Griffith wrote: If you agree, I'm happy to send a patch. Thanks! That would be great. OK --- attached is a patch. Most of it is just re-indenting. (I wasn't always careful about using tabs instead of spaces --- is there

Re: [Libmesh-devel] New Quadrature Rule

2010-12-02 Thread Boyce Griffith
On 11/16/10 2:24 PM, Derek Gaston wrote: > On Nov 16, 2010, at 10:27 AM, Boyce Griffith wrote: > >> Is adding qrule->need_reinit() the only change that you are making to QBase? >> I am probably missing something, but it seems like allowing the quadrature >> rule to vary from element to element

Re: [Libmesh-devel] xdr_io with multiple boundary ids per side

2010-12-02 Thread Roy Stogner
On Thu, 2 Dec 2010, Boyce Griffith wrote: > Looking around, there are some other places in libMesh that appear not to > handle multiple boundary IDs per side. In particular: > > fe_base.C~ around line 2018 > mesh_communication.C ~ around lines 364 and 1080 > mesh_modification.C

Re: [Libmesh-devel] xdr_io with multiple boundary ids per side

2010-12-02 Thread Boyce Griffith
On 12/1/10 9:31 PM, Roy Stogner wrote: > > Did you really managed to get overlapping BC IDs working with a > dozen-line patch? Egg on our faces... I don't think any of the > primary developers use multiple IDs on the same boundary right now, > but if we'd known it would be that simple to support t