Re: [Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread David Andrs
Roy Stogner wrote on 06/08/2011 01:28:03 PM: > > On Wed, 8 Jun 2011, David Andrs wrote: > > > This was actually a serial run with adaptivity and this bug poped out > > after first refinement when calling EquationSystems::reinit(). > > > > I'll try to replicate this behavior with pure libMesh ca

Re: [Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread Roy Stogner
On Wed, 8 Jun 2011, David Andrs wrote: > This was actually a serial run with adaptivity and this bug poped out > after first refinement when calling EquationSystems::reinit(). > > I'll try to replicate this behavior with pure libMesh calls and send it to > you, it might be worth to include it int

Re: [Libmesh-devel] subdomain_id_patch

2011-06-08 Thread Cody Permann
On Jun 8, 2011, at 1:07 PM, John Peterson wrote: > On Wed, Jun 8, 2011 at 1:02 PM, Cody Permann wrote: >> >> On Jun 8, 2011, at 12:56 PM, Roy Stogner wrote: >> >>> >>> On Wed, 8 Jun 2011, John Peterson wrote: >>> On Wed, Jun 8, 2011 at 8:49 AM, Cody Permann wrote: > I've just about

Re: [Libmesh-devel] subdomain_id_patch

2011-06-08 Thread John Peterson
On Wed, Jun 8, 2011 at 1:02 PM, Cody Permann wrote: > > On Jun 8, 2011, at 12:56 PM, Roy Stogner wrote: > >> >> On Wed, 8 Jun 2011, John Peterson wrote: >> >>> On Wed, Jun 8, 2011 at 8:49 AM, Cody Permann wrote: I've just about finished up the patch to allow us to configure subdomain_id

Re: [Libmesh-devel] subdomain_id_patch

2011-06-08 Thread Cody Permann
On Jun 8, 2011, at 12:56 PM, Roy Stogner wrote: > > On Wed, 8 Jun 2011, John Peterson wrote: > >> On Wed, Jun 8, 2011 at 8:49 AM, Cody Permann wrote: >>> I've just about finished up the patch to allow us to configure >>> subdomain_id_type with ./configure. The current syntax I'm using >>> is

Re: [Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread David Andrs
Roy Stogner wrote on 06/08/2011 12:45:06 PM: > > On Wed, 8 Jun 2011, David Andrs wrote: > > > > Would it be sufficient to change that assert from > > > libmesh_assert(last_local_idx < this->size()); > > > to > > > libmesh_assert(last_local_idx+1 <= this->size()); > > > ? > > > > Yes, it fixes

Re: [Libmesh-devel] subdomain_id_patch

2011-06-08 Thread Roy Stogner
On Wed, 8 Jun 2011, John Peterson wrote: On Wed, Jun 8, 2011 at 8:49 AM, Cody Permann wrote: I've just about finished up the patch to allow us to configure subdomain_id_type with ./configure.  The current syntax I'm using is "--with-subdomain-id-bytes=<1|2|4>" defaulting to "2". This looks

Re: [Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread Roy Stogner
On Wed, 8 Jun 2011, David Andrs wrote: > > Would it be sufficient to change that assert from > > libmesh_assert(last_local_idx < this->size()); > > to > > libmesh_assert(last_local_idx+1 <= this->size()); > > ? > > Yes, it fixes the issue as well. Good to hear; that's in SVN now. Sorry about t

Re: [Libmesh-devel] subdomain_id_patch

2011-06-08 Thread John Peterson
On Wed, Jun 8, 2011 at 8:49 AM, Cody Permann wrote: > I've just about finished up the patch to allow us to configure > subdomain_id_type with ./configure.  The current syntax I'm using is > "--with-subdomain-id-bytes=<1|2|4>" defaulting to "2". > I'm running into an issue now with our regressio

Re: [Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread David Andrs
Roy Stogner wrote on 06/08/2011 11:52:55 AM: > > On Wed, 8 Jun 2011, David Andrs wrote: > > > Some of our tests here at INL started to fail after we updated > libMesh. I tracked the problem down into TransientSystem::re_update > where r4500 > > commented out the if-statement on line 152. With

Re: [Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread Roy Stogner
On Wed, 8 Jun 2011, David Andrs wrote: > Some of our tests here at INL started to fail after we updated libMesh. I > tracked the problem down into TransientSystem::re_update where r4500 > commented out the if-statement on line 152. Without it the code execution > continues into localize of olde

[Libmesh-devel] Bug in TransientSystem::re_update

2011-06-08 Thread David Andrs
Hi! Some of our tests here at INL started to fail after we updated libMesh. I tracked the problem down into TransientSystem::re_update where r4500 commented out the if-statement on line 152. Without it the code execution continues into localize of older_local_solution and we have first_local_d

[Libmesh-devel] subdomain_id_patch

2011-06-08 Thread Cody Permann
I've just about finished up the patch to allow us to configure subdomain_id_type with ./configure. The current syntax I'm using is "--with-subdomain-id-bytes=<1|2|4>" defaulting to "2". I'm running into an issue now with our regression test suite where I'm getting diffs on tests that use the m