Re: [Libmesh-devel] [PATCH 2/2] Update for XXDestroy() API change in petsc-dev (to be released in 3.2).

2011-08-01 Thread Jed Brown
On Mon, Aug 1, 2011 at 14:48, John Peterson wrote: > Hmm... I think there used to be. We used to need to define > > EXTERN_C_FOR_PETSC_BEGIN > EXTERN_C_FOR_PETSC_END > > inside petsc_macro.h, before we could include any other petsc headers. > (At some point the petsc headers began extern C'ing

Re: [Libmesh-devel] [PATCH 2/2] Update for XXDestroy() API change in petsc-dev (to be released in 3.2).

2011-08-01 Thread John Peterson
On Mon, Aug 1, 2011 at 1:21 PM, Jed Brown wrote: > On Mon, Aug 1, 2011 at 12:49, John Peterson wrote: >> >> I think it's because petsc_macro.h is #include'd *before* the relevant >> petsc header, so the macro is defined before the extern XXDestroy >> functions are declared, at which point they ge

Re: [Libmesh-devel] [Libmesh-users] avoid inverse maps in shape reinit on sides

2011-08-01 Thread John Peterson
On Mon, Aug 1, 2011 at 1:45 PM, Roy Stogner wrote: > > John, double-check me on this: > > I believe the PYRAMID5 in Lorenzo's patch is wrong - the Pyramid5 we > use, going by both my own hazy memory and by the ::shape() equations > in fe_lagrange_shape_3D.C, has points 0-3 in the zeta=0 plane, not

Re: [Libmesh-devel] [Libmesh-users] avoid inverse maps in shape reinit on sides

2011-08-01 Thread Roy Stogner
On Wed, 27 Jul 2011, Lorenzo Alessio Botti wrote: > here is a patch to avoid inverse maps on sides reinit. > I hope that the main developers will consider it and > have some time to give it a look since it might break a lot of code... Aha, so it might. You're adding a new method that can make D

Re: [Libmesh-devel] [PATCH 2/2] Update for XXDestroy() API change in petsc-dev (to be released in 3.2).

2011-08-01 Thread Jed Brown
On Mon, Aug 1, 2011 at 12:49, John Peterson wrote: > I think it's because petsc_macro.h is #include'd *before* the relevant > petsc header, so the macro is defined before the extern XXDestroy > functions are declared, at which point they get macro-fied...? > Hmm, I wonder why this would be diffe

Re: [Libmesh-devel] [PATCH 2/2] Update for XXDestroy() API change in petsc-dev (to be released in 3.2).

2011-08-01 Thread John Peterson
On Mon, Aug 1, 2011 at 12:07 PM, Roy Stogner wrote: > > On Mon, 1 Aug 2011, John Peterson wrote: > >> I can commit these patches unless someone else is already in the >> process of doing it... > > I'm still catching up on older stuff, and at first glance don't see > any problems here; go for it.

Re: [Libmesh-devel] [PATCH 2/2] Update for XXDestroy() API change in petsc-dev (to be released in 3.2).

2011-08-01 Thread Roy Stogner
On Mon, 1 Aug 2011, John Peterson wrote: > I can commit these patches unless someone else is already in the > process of doing it... I'm still catching up on older stuff, and at first glance don't see any problems here; go for it. --- Roy

Re: [Libmesh-devel] [PATCH 2/2] Update for XXDestroy() API change in petsc-dev (to be released in 3.2).

2011-08-01 Thread John Peterson
I can commit these patches unless someone else is already in the process of doing it... -- John On Sun, Jul 31, 2011 at 10:39 AM, Jed Brown wrote: > --- >  include/numerics/petsc_macro.h       |   10 + >  include/numerics/petsc_vector.h      |    2 +- >  src/numerics/petsc_matrix.C        

Re: [Libmesh-devel] XDA restart fix

2011-08-01 Thread David Andrs
We didn't have a test for that before - one of our post-docs ran into this. But now, we do have such a test. -- David Roy Stogner wrote on 08/01/2011 09:26:03 AM: > > On Mon, 25 Jul 2011, David Andrs wrote: > > > We bumped into an issue with XDA restart here at INL. We ran a > > simulation

Re: [Libmesh-devel] XDA restart fix

2011-08-01 Thread Roy Stogner
On Mon, 25 Jul 2011, David Andrs wrote: > We bumped into an issue with XDA restart here at INL. We ran a > simulation that had one system in EquationSystems object and we > saved the result (as XDA). Then we wanted to restart with more > variables but also with more systems in the EquationSystems