Re: [Libmesh-devel] svn commit of whitespace changes

2011-12-02 Thread Roy Stogner
On Fri, 2 Dec 2011, Roy Stogner wrote: > I do love the irony of complaining about the size of a 600-line diff, > then preparing a 130,000 line diff myself. Just to be extra-clear: I say "preparing", not "committing". Such an extensive change would obviously create annoying little svn conflicts

Re: [Libmesh-devel] svn commit of whitespace changes

2011-12-02 Thread Roy Stogner
On Fri, 2 Dec 2011, Derek Gaston wrote: > We somewhat recently implemented commit hooks on our repository that > force no trailing whitespace (ie, reject a commit if it has trailing > whitespace). I thought it was going to be draconian at first... But I > actually like it a lot because it keeps

Re: [Libmesh-devel] svn commit of whitespace changes

2011-12-02 Thread Cody Permann
It works really well after the huge initial check-in that fixes all existing whitespace. At least it is a one time change and all contained in change set. The hook and Perl script have worked flawlessly through the process. Sent from my evil iPhone On Dec 2, 2011, at 2:52 PM, Derek Gaston wrot

Re: [Libmesh-devel] svn commit of whitespace changes

2011-12-02 Thread Derek Gaston
We somewhat recently implemented commit hooks on our repository that force no trailing whitespace (ie, reject a commit if it has trailing whitespace). I thought it was going to be draconian at first... But I actually like it a lot because it keeps out a _bunch_ of superfluous diffs. We just use s

[Libmesh-devel] svn commit of whitespace changes

2011-12-02 Thread Roy Stogner
Regularizing whitespace (e.g. deleting trailing whitespace from lines, fixing formatting that doesn't fit the rest of the file) is great, but it tends to generate enormous diffs, so when simultaneously changing whitespace and features, let's keep them in separate svn commits, please. Having to hu