Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread Derek Gaston
Ok it's all committed now... let me know if you have any problems with it. The update of Exodus only caused a couple of compile errors that were easy to fix. I did end up modifying both exodus and nemesis to #include in a couple of files. It was giving warnings about implicit declaration of mal

Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread John Peterson
On Fri, Jul 11, 2008 at 11:29 AM, Derek Gaston <[EMAIL PROTECTED]> wrote: > On Fri, Jul 11, 2008 at 9:49 AM, John Peterson <[EMAIL PROTECTED]> wrote: >> >> Try to use your best programming judgment as well. If something >> actually seems dangerous/might cause a problem in some use cases, I >> woul

Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread Derek Gaston
On Fri, Jul 11, 2008 at 9:49 AM, John Peterson <[EMAIL PROTECTED]> wrote: > Try to use your best programming judgment as well. If something > actually seems dangerous/might cause a problem in some use cases, I > would definitely fix it. Sometimes warnings are good for stuff like > that :) > Wow

Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread Derek Gaston
On Jul 11, 2008, at 9:27 AM, Roy Stogner wrote: >> Should I modify the source? > > Only if you can convince the developers upstream to do the same. > >> Should I modify CFLAGS to turn these warnings off? > > I think so. > >> Basically, what's the policy on warnings from contrib? > > Officially, I

Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread Roy Stogner
On Fri, 11 Jul 2008, Derek Gaston wrote: > I've got it all setup and building... the only issue is that it has > some warnings (in opt) like so: > > Is this going to be acceptable? Yes, but not preferrable. > Should I modify the source? Only if you can convince the developers upstream to do th

Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread Derek Gaston
On Jul 11, 2008, at 9:18 AM, John Peterson wrote: > Cool. I assume this is GPL'd or LGPL'd or in some way distributable? Yeah - it's the same as Exodus... essentially do what you like but retain the COPYRIGHT file. > I think if at all possible try to fix any warnings under our normal > compila

Re: [Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread John Peterson
On Fri, Jul 11, 2008 at 10:12 AM, Derek Gaston <[EMAIL PROTECTED]> wrote: > All, > > I'm adding a new library to contrib: Nemsis. It's the ExodusII > parallel decomposition API... it will allow us to read and write > parallel decomposed Exodus files. Cool. I assume this is GPL'd or LGPL'd or in

[Libmesh-devel] Policy on contrib warnings

2008-07-11 Thread Derek Gaston
All, I'm adding a new library to contrib: Nemsis. It's the ExodusII parallel decomposition API... it will allow us to read and write parallel decomposed Exodus files. I've got it all setup and building... the only issue is that it has some warnings (in opt) like so: ne_gneat.c:82: warning