On Fri, 3 Dec 2010, [email protected] wrote:
> My vote would be to add it in the commit hook. There should be no
> disadvantages that way and formatting will get better over time.
> Heavily worked sections of code will come up to date quickly while
> less busy sections of code (in terms of c
My vote would be to add it in the commit hook. There should be no
disadvantages that way and
formatting will get better over time. Heavily worked sections of code will
come up to date quickly while
less busy sections of code (in terms of changes) may never come up to
speed. At least things
w
On Thu, 2 Dec 2010, Roy Stogner wrote:
> This hurts the usefulness of "svn blame". Whoever commits the first
> massive set of astyle changes suddenly looks responsible for a whole
> lot of code where he merely touched whitespace.
>
> This hurts the usefulness of "svn diff -r A:B" where A is any r
> -Original Message-
> From: Roy Stogner [mailto:[email protected]]
>
> There are nearly ONE HUNDRED THOUSAND lines of changes. No way are we
> looking over every one of them. Does everyone want to trust that
> astyle doesn't break any C++, or that our regression and unit tests
On Thu, Dec 2, 2010 at 4:27 PM, Roy Stogner wrote:
>
> This hurts the usefulness of "svn diff -r A:B" where A is any revision
> number before the whitespace change and B is any revision number
> after.
FYI: you can get diff to ignore whitespace changes by passing -x -w:
svn diff -rPREV -x -w inc
On 12/2/10 5:27 PM, Roy Stogner wrote:
> There are nearly ONE HUNDRED THOUSAND lines of changes. No way are we
> looking over every one of them. Does everyone want to trust that
> astyle doesn't break any C++, or that our regression and unit tests
> have enough coverage to catch any breakage?
Al
On Thu, 2 Dec 2010, Boyce Griffith wrote:
> It looks like Artistic Style's GNU setting more-or-less conforms to the
> libMesh style --- you can invoke it via:
>
> astyle --style=gnu -r $PWD/*.C $PWD/*.h
>
> or possibly:
>
> astyle --style=gnu --max-instatement-indent=79 \
> --min-co
