Re: [Libmesh-devel] More PeriodicBoundary stuff

2012-08-20 Thread Roy Stogner
Discussing refactoring; this probably ought to be on one of the public lists. Something to add to the below discussion: if we're refactoring PeriodicBoundary anyway, and *especially* if we're putting more classes of periodic boundary into the main library, it would be nice to add an abstract base

Re: [Libmesh-devel] More PeriodicBoundary stuff

2012-08-20 Thread John Peterson
On Mon, Aug 20, 2012 at 2:03 PM, Roy Stogner wrote: > >> 2.) We add a virtual clone() method to PeriodicBoundary. Both >> versions of DofMap::add_periodic_boundary() take constant references >> and clone() them internally before adding them to the >> _periodic_boundaries container. > > > This is

Re: [Libmesh-devel] More PeriodicBoundary stuff

2012-08-20 Thread Roy Stogner
On Mon, 20 Aug 2012, John Peterson wrote: > On Mon, Aug 20, 2012 at 2:03 PM, Roy Stogner wrote: > >> Yeah, we'd definitely want to call the ABC PeriodicBoundaryBase so we >> could still instantiate PeriodicBoundary for backwards compatibility. > > OK, and I assume we'd like to maintain the "auto

[Libmesh-devel] Periodic BCs patch

2012-08-20 Thread Roy Stogner
This is against the SVN head. It seems to work fine on the all-too-few tests I've run, but does it pass the INL test suite too? --- RoyIndex: src/fe/fe_base.C === --- src/fe/fe_base.C (revision 5966) +++ src/fe/fe_base.C (working co