[Libmesh-devel] one step short of beautify...

2013-04-02 Thread Kirk, Benjamin (JSC-EG311)
OK, at risk of entering dangerous territory… I've been using John's recommended git config flags, and have become ashamed of the amount of trailing whitespace I leave in source files. Consequently, I've added ;-- ; remove trailing whitespace (add

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread Cody Permann
Haha - it seems like we've done whitespace cleanup before and it's already a mess again! Perhaps you should seriously consider taking the more draconian approach like we have and rejecting all commits containing whitespace! There's nothing funnier then watching Derek prepare a huge patch for MOOS

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread John Peterson
On Tue, Apr 2, 2013 at 2:30 PM, Kirk, Benjamin (JSC-EG311) < benjamin.kir...@nasa.gov> wrote: > OK, at risk of entering dangerous territory… > > I've been using John's recommended git config flags, and have become > ashamed of the amount of trailing whitespace I leave in source files. > I've play

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread John Peterson
On Tue, Apr 2, 2013 at 2:43 PM, John Peterson wrote: > been using it a few weeks now and would go back! > Derp, would *not* go back! -- John -- Minimize network downtime and maximize team effectiveness. Reduce network

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread Kirk, Benjamin (JSC-EG311)
On Apr 2, 2013, at 3:45 PM, John Peterson wrote: > On Tue, Apr 2, 2013 at 2:43 PM, John Peterson wrote: > been using it a few weeks now and would go back! > > Derp, would *not* go back! > sure the *not* didn't get slurped up by your 'pre-send' script? thanks, I'll turn off the emacs feature

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread Roy Stogner
On Tue, 2 Apr 2013, Kirk, Benjamin (JSC-EG311) wrote: > Any objections to a massive, whitespace-only commit? My fury is limited to whitespace-mixed-with-functionality-changes commits. Whitespace-only is fine, unless someone chimes in this afternoon to complain that they've got an upcoming merge

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread John Peterson
On Tue, Apr 2, 2013 at 2:49 PM, Kirk, Benjamin (JSC-EG311) < benjamin.kir...@nasa.gov> wrote: > > On Apr 2, 2013, at 3:45 PM, John Peterson wrote: > > > On Tue, Apr 2, 2013 at 2:43 PM, John Peterson > wrote: > > been using it a few weeks now and would go back! > > > > Derp, would *not* go back!

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread John Peterson
On Tue, Apr 2, 2013 at 2:43 PM, John Peterson wrote: > On Tue, Apr 2, 2013 at 2:30 PM, Kirk, Benjamin (JSC-EG311) < > benjamin.kir...@nasa.gov> wrote: > >> OK, at risk of entering dangerous territory… >> >> >> I've been using John's recommended git config flags, and have become >> ashamed of the

Re: [Libmesh-devel] [Libmesh-users] Has anyone tripped this error?

2013-04-02 Thread Kirk, Benjamin (JSC-EG311)
On Apr 2, 2013, at 4:12 PM, "Kirk, Benjamin (JSC-EG311)" wrote: > RemoteElem should be being created from LibMeshInit (see the > Singleton::create() call and related bits in remote_elem.C) but apparently it > isn't? To be more clear, Singleton::setup() should call the preregistered RemoteE

Re: [Libmesh-devel] [Libmesh-users] Has anyone tripped this error?

2013-04-02 Thread Cody Permann
Trying this now... Cody On Tue, Apr 2, 2013 at 3:17 PM, Kirk, Benjamin (JSC-EG311) < benjamin.kir...@nasa.gov> wrote: > On Apr 2, 2013, at 4:12 PM, "Kirk, Benjamin (JSC-EG311)" < > benjamin.kir...@nasa.gov> wrote: > > > RemoteElem should be being created from LibMeshInit (see the > Singleton::cr

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread Derek Gaston
I recommend running this in the libMesh dir: find . -name '*.[Chi]' -or -name '*.py' | xargs perl -pli -e 's/\s+$//' Then adding a commit hook to the repository that never again allows trailing whitespace to enter. Then it doesn't matter if people keep it out using Emacs or a Git pre-commit hook

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread Kirk, Benjamin (JSC-EG311)
You've got that as a git hook? Ill clean the tree tonight or tomorrow, and then work with Cody after he finds whatever bug I just presented him with... -Ben On Apr 2, 2013, at 4:55 PM, "Derek Gaston" mailto:fried...@gmail.com>> wrote: I recommend running this in the libMesh dir: find . -na

Re: [Libmesh-devel] [Libmesh-users] Has anyone tripped this error?

2013-04-02 Thread Cody Permann
On Tue, Apr 2, 2013 at 3:22 PM, Cody Permann wrote: > Trying this now... > Cody > > > > On Tue, Apr 2, 2013 at 3:17 PM, Kirk, Benjamin (JSC-EG311) < > benjamin.kir...@nasa.gov> wrote: > >> On Apr 2, 2013, at 4:12 PM, "Kirk, Benjamin (JSC-EG311)" < >> benjamin.kir...@nasa.gov> wrote: >> >> > Remot

Re: [Libmesh-devel] one step short of beautify...

2013-04-02 Thread Cody Permann
On Tue, Apr 2, 2013 at 4:19 PM, Kirk, Benjamin (JSC-EG311) < benjamin.kir...@nasa.gov> wrote: > You've got that as a git hook? > > Not quite - we just have that little one-liner hanging around on our "tips" page for developers to run to clean stuff up. Our svn-hook is basically the same thing (i.

Re: [Libmesh-devel] [Libmesh-users] Has anyone tripped this error?

2013-04-02 Thread Kirk, Benjamin (JSC-EG311)
On Apr 2, 2013, at 5:22 PM, Cody Permann wrote: > > > RemoteElem should be being created from LibMeshInit (see the > > Singleton::create() call and related bits in remote_elem.C) but apparently > > it isn't? > > > Yeah - bad news... RemoteElem::create() is _not_ being called on several of >

Re: [Libmesh-devel] [Libmesh-users] Has anyone tripped this error?

2013-04-02 Thread Cody Permann
On Tue, Apr 2, 2013 at 4:42 PM, Kirk, Benjamin (JSC-EG311) < benjamin.kir...@nasa.gov> wrote: > On Apr 2, 2013, at 5:22 PM, Cody Permann wrote: > > > > > RemoteElem should be being created from LibMeshInit (see the > Singleton::create() call and related bits in remote_elem.C) but apparently > it

Re: [Libmesh-devel] [Libmesh-users] Has anyone tripped this error?

2013-04-02 Thread Roy Stogner
On Tue, 2 Apr 2013, Cody Permann wrote: > Weird - *all* my compilers on linux worked fine - gcc 4.4, 4.5, 4.6, 4.7, icc 12.0, 12.1, > 13.0, pgi's, open solaris… Alright, I'll give it a shot, I can't repeat the bad behavior on our Macs, even with the identical 4.7.2 compiler so it is a compl