Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-23 Thread Lionel Debroux
--- John Adcock <[EMAIL PROTECTED]> wrote : > --snip-- > > Thanks for the tips, I'll try again later. > Here is a more complete patch. Tested-by: Lionel Debroux <[EMAIL PROTECTED]> The patch passes `make check` for me on SimplyMEPIS 7.0 (based on Debian stable, GCC 4.1.x) running on a Core 2 Duo;

Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-22 Thread John Adcock
--snip-- Thanks for the tips, I'll try again later. Here is a more complete patch. Thanks John win32_fixes.diff Description: Binary data - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) V

Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-22 Thread John Adcock
--snip-- > Apart from that, I'd surround the GCC-specific declaration of > DECLARE_ALIGNED by a #ifdef __GNUC__, like this: --snip-- > (Note that I updated the comment as well) Thanks for the tips, I'll try again later. John --

Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-22 Thread Lionel Debroux
Hi, > > This patch may fix vc++, but breaks all other platforms > > because it moves ATTR_ALIGN which is used in different > > places. > It certainly shouldn't, the patch replaces ATTR_ALIGN > taking 2 parameters which only works with gcc with > DECLARE_ALIGNED which takes 3 parameters and support

Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-22 Thread John Adcock
(Embarrassed answering of own question) > Could you explain how this breaks other platforms and I'll happily update the > patch. by not changing all the instances of ATTR_ALIGN you fool. I'll make an upadated patch this evening, apologies. John ---

Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-22 Thread John Adcock
> This patch may fix vc++, but breaks all other platforms because it > moves ATTR_ALIGN which is used in different places. It certainly shouldn't, the patch replaces ATTR_ALIGN taking 2 parameters which only works with gcc with DECLARE_ALIGNED which takes 3 parameters and supports both gcc and ms

Re: [mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-22 Thread Christophe Massiot
At 14:35 +0100 17/05/08, John Adcock wrote: >The attached patch fixes support for compilation under Visual Studio >using the project file in the vc++ directory. The recent SSE2 IDCT >patch requires some data to be aligned and this patch adds support for >the alignment in MSVC as well as fixing a c

[mpeg2-dev] Patch to fix issues with Visual Studio

2008-05-17 Thread John Adcock
The attached patch fixes support for compilation under Visual Studio using the project file in the vc++ directory. The recent SSE2 IDCT patch requires some data to be aligned and this patch adds support for the alignment in MSVC as well as fixing a compilation error in for the obj files that need