Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Christophe Fergeau
On Thu, May 31, 2018 at 04:19:54PM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 3:35 PM, Christophe Fergeau > wrote: > > On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fidêncio wrote: > >> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau > >> wrote: > >> > On Thu, May 31,

Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 3:35 PM, Christophe Fergeau wrote: > On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fidêncio wrote: >> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau >> wrote: >> > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: >> >> > If they are public, what

Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Christophe Fergeau
On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau > wrote: > > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: > >> > If they are public, what happens in libosinfo if we try to set a > >> > non-existent

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex

2018-05-31 Thread Christophe Fergeau
On Thu, May 31, 2018 at 02:57:14PM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 2:23 PM, Christophe Fergeau > wrote: > > On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fidêncio wrote: > >> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau > >> wrote: > >> > On Sat, May 26,

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 2:23 PM, Christophe Fergeau wrote: > On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fidêncio wrote: >> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau >> wrote: >> > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: >> >> The regex to match unknown

Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau wrote: > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: >> > If they are public, what happens in libosinfo if we try to set a >> > non-existent parameter? In other word, should we consider this an >> > API/ABI break, or are we

Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Christophe Fergeau
On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: > > If they are public, what happens in libosinfo if we try to set a > > non-existent parameter? In other word, should we consider this an > > API/ABI break, or are we fine with dropping it? > > We're totally fine dropping it. > If

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex

2018-05-31 Thread Christophe Fergeau
On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau > wrote: > > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: > >> The regex to match unknown openSUSE prereleases is becoming > >> bigger and harder to read.

Re: [Libosinfo] [libosinfo][PATCH v2] tests: Add test-os-resources

2018-05-31 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Fri, May 04, 2018 at 10:34:09PM +0200, Fabiano Fidêncio wrote: > From: Fabiano Fidêncio > > test-os-resources has been written to avoid bug as having minimum > resources greater than the recommended resources in osinfo-db. > > This problem was exposed by

Re: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 11:16 AM, Christophe Fergeau wrote: > Hey, > > Commented on some of the patches, but for the series, > > Acked-by: Christophe Fergeau Thanks for the review, I'll address your comments, push the patches and do a release later Today. > > On Sat, May 26, 2018 at 10:29:37PM

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust upgrades/derives-from for leap 15.0

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 11:11 AM, Christophe Fergeau wrote: > On Sat, May 26, 2018 at 10:29:41PM +0200, Fabiano Fidêncio wrote: >> Signed-off-by: Fabiano Fidêncio >> --- >> data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git

Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 11:11 AM, Christophe Fergeau wrote: > On Sat, May 26, 2018 at 10:29:38PM +0200, Fabiano Fidêncio wrote: >> As we don't do anything in the second stage, we can just skip it >> entirely without any issues. >> >> Signed-off-by: Fabiano Fidêncio >> --- >>

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex

2018-05-31 Thread Fabiano Fidêncio
On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau wrote: > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: >> The regex to match unknown openSUSE prereleases is becoming >> bigger and harder to read. >> >> Basically, what it's doing is: >> >>

Re: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata

2018-05-31 Thread Christophe Fergeau
Hey, Commented on some of the patches, but for the series, Acked-by: Christophe Fergeau On Sat, May 26, 2018 at 10:29:37PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > .../openSUSE-Leap-15.0-DVD-x86_64.iso.txt | 29 > ++ >

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust upgrades/derives-from for leap 15.0

2018-05-31 Thread Christophe Fergeau
On Sat, May 26, 2018 at 10:29:41PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in >

Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage

2018-05-31 Thread Christophe Fergeau
On Sat, May 26, 2018 at 10:29:38PM +0200, Fabiano Fidêncio wrote: > As we don't do anything in the second stage, we can just skip it > entirely without any issues. > > Signed-off-by: Fabiano Fidêncio > --- > data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 + > 1 file

Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex

2018-05-31 Thread Christophe Fergeau
On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: > The regex to match unknown openSUSE prereleases is becoming > bigger and harder to read. > > Basically, what it's doing is: > > (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9]) > - -