config.h file is only used in osinfo-db-tools for the GETTEXT_PACKAGE
macro. Fortunately, when AC_CONFIG_HEADER macro is dropped from
configure, -DGETTEXT_PACKAGE=... is automatically passed as a compilar
argument, allowing us then to drop the file.
Together with this change, let's also drop both
Let's run the check in all files.
Signed-off-by: Fabiano Fidêncio
---
cfg.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index b7839c8..fc4b313 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -100,5 +100,3 @@ sc_bracket_spacing_check:
# We don't use this feature of maint.mk.
Let's adapt the prepare-release script to use meson build system instead
of autotools.
This change has been tested and is working fine on Fedora 30+.
Signed-off-by: Fabiano Fidêncio
---
prepare-release.sh | 78 ++
1 file changed, 24 insertions(+), 54
Now that ninja has a `syntax-check` target, let's add it to
prepare-release script in a similar that `make syntax-check` was used
before.
Signed-off-by: Fabiano Fidêncio
---
prepare-release.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/prepare-release.sh b/prepare-release.sh
index
The changes needed in the spec files are not so intrusive.
One thing that has to be mentioned is the requirement for
mingw-filesystem >= 107 (which is only present on Fedora 30+) in order
to generate the mingw rpms for osinfo-db-tools. This huge bump in the
version happened because the
Let's run the check in all files.
Signed-off-by: Fabiano Fidêncio
---
cfg.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 5490603..b7839c8 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -101,6 +101,4 @@ sc_bracket_spacing_check:
# We don't use this feature of maint.mk.
Meson build system is a way simpler and easier to understand build
system that can provide (with some work-arounds here and there) the same
functionalities currently available with our current build system
(autotools).
For now, as meson support is not fully complete* and requires a quite
new
A few dirty hacks have been done in GNUmakefile, cfg.mk, and maint.mk
in order to support running `make syntax-check` without having to have a
Makefile around.
GNUmakefile: set srcdir & top_srcdir and remove the parts that would
cause an error due to no presence of a Makefile.
cfg.mk: add
Let's try to drop autotools support as meson is in place. There are a
few files that were not dropped though, as:
- cfg.mk
- maint.mk
- GNUmakefile
- build-aux/bracket-spacing.pl
- build-aux/gitlog-to-changelog
- build-aux/useless-if-before-free
- build-aux/vc-list-files
>From the list above,
Those options have been added as the `prepare-release.sh` was copied
from the libosinfo project. However, those options are not valid for
osinfo-db-tools project.
Signed-off-by: Fabiano Fidêncio
---
prepare-release.sh | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git
By doing this, we can stop excluding files from
sc_preprocessor_indentation check.
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-db-util.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/osinfo-db-util.h b/tools/osinfo-db-util.h
index 7b4e501..8d7a456 100644
Signed-off-by: Fabiano Fidêncio
---
maint.mk | 407 ++-
1 file changed, 255 insertions(+), 152 deletions(-)
diff --git a/maint.mk b/maint.mk
index 04a839a..16e9360 100644
--- a/maint.mk
+++ b/maint.mk
@@ -2,7 +2,7 @@
# This Makefile fragment
Together with the changes, let's adapt GNUmakefile and maint.mk in order
to be able to run those files from build-aux.
GNUmakefile:
- changing both srcdir & top_srcdir, and adjusting the includes of
cfg.mk and maint.mk were enough to be able to run `make syntax-check`
from build-aux
The following patch series:
- Add suppor to meson build system;
- Drop support to autotools build system;
If we decide to go for it, there's still work to be done in
libvirt-jenkins-ci as it has to have meson support added there.
Changes since v1:
Commit 1df4c0dbede tried to unset all OSINFO_*_DIR envvars but instead
of unsetting OSINFO_LOCAL_DIR it unset OSINFO_DATA_DIR, which doesn't
exist.
Signed-off-by: Fabiano Fidêncio
---
tests/test_osinfo_db_path.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Let's run the check in all files.
Signed-off-by: Fabiano Fidêncio
---
cfg.mk | 2 --
1 file changed, 2 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 570bbb2..5490603 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -101,8 +101,6 @@ sc_bracket_spacing_check:
# We don't use this feature of maint.mk.
Let's take advantage of that we can run `make syntax-check` without the
need of having a Makefile around and add a `ninja syntax-check` target
that ends up calling `make syntax-check`.
Signed-off-by: Fabiano Fidêncio
---
build-aux/syntax-check | 5 +
meson.build| 3 +++
2 files
Let's add a new option so users can set their config from a file,
instead of directly passing the values via command-line.
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-install-script.c | 103 +-
1 file changed, 102 insertions(+), 1 deletion(-)
diff --git
Let's deprecate --config and warn out whenever a user or admin password
is passed to osinfo-install-script.
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-install-script.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tools/osinfo-install-script.c b/tools/osinfo-install-script.c
Those two patches introduce a fix for a low impact CVE where both user
& admin password would be passed to the osinfo-install-script via
command line.
In order to avoid doing so, let's introduce a --config-file and warn out
whenever a password is passed via --config.
Changes since v1:
Commit 1df4c0dbede tried to unset all OSINFO_*_DIR envvars but instead
of unsetting OSINFO_LOCAL_DIR it unset OSINFO_DATA_DIR, which doesn't
exist.
Signed-off-by: Fabiano Fidêncio
---
tests/test_osinfo_db_path.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
As Debian 10 has been released, Debian 9 ISOs have been moved to the
archive.
Signed-off-by: Fabiano Fidêncio
---
data/os/debian.org/debian-9.xml.in | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/data/os/debian.org/debian-9.xml.in
In this series let's:
- Update the deadlinks from Debian 9 as, due to the Debian 10 release,
its ISOs have been moved to the archive;
- Add Debian 10 info;
* Unattended installation on both jeos/desktop have been tested using
Debian tree;
Fabiano Fidêncio (2):
debian9: Update dead links
Debian 10 has been released on July 6th, 2019.
Signed-off-by: Fabiano Fidêncio
---
data/os/debian.org/debian-10.xml.in | 203 ++
.../debian-10.0.0-amd64-DVD-1.iso.txt | 29 +++
.../debian-10.0.0-amd64-netinst.iso.txt | 29 +++
24 matches
Mail list logo
