Splitting centos & rhel script, done in 538ca137c, was not exactly the
best idea as it increased the maintenance for pretty much no gain.
With that in mind, let's merge back the scripts keeping the centos
specific bits conditionally added as part of the templates.
Signed-off-by: Fabiano Fidê
Let's add a target-disk template so we actually can use what apps set as
target-disk, instead of using a hardcoded path to /dev/vda.
With this change we keep not requiring the apps to set this value.
Signed-off-by: Fabiano Fidêncio
---
.../opensuse-autoyast-desktop.xml.in | 21
repo-oss template has been generating an empy extra space before the URL
it returns, which may break unattended installations.
Signed-off-by: Fabiano Fidêncio
---
.../install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 -
data/install-script/opensuse.org/opensuse-autoyast
-by: Fabiano Fidêncio
---
data/install-script/redhat.com/rhel-kickstart-desktop.xml.in | 2 +-
data/install-script/redhat.com/rhel-kickstart-jeos.xml.in| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
b/data/install
Although we only support unattended installations for CentOS 6 (or
newer), let's fix the condition for using virtio as the target disk.
Unlike suggested in the previous condition, virtio-block has only been
added to CentOS 5.6 (and not 5.0).
Signed-off-by: Fabiano Fidêncio
---
data/install
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../centos.org/centos-kickstart-desktop.xml.in | 14 --
.../centos.org/centos-kickstart-jeos.xml.in
Let's add the script disk template so we don't actually require the apps
to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../silverblue-kickstart-desktop.xml.in | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff
Let's add a target-disk template so we actually can use what apps set
as target-disk, instead of using a hardcoded path to /dev/vda.
With this change we keep not requiring the apps to set this value.
Signed-off-by: Fabiano Fidêncio
---
.../silverblue-kickstart-desktop.xml.in | 15
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../redhat.com/rhel-kickstart-desktop.xml.in | 14 --
.../redhat.com/rhel-kickstart-jeos.xml.in
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../redhat.com/rhel-kickstart
autopart usage has been introduced in commit 81beb9970 and, since then,
there's no need keep the rootfs and bootfs templates.
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in | 22 ---
1 file changed, 22 deletions(-)
diff --git
a/data/install
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../centos.org/centos-kickstart
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in | 17 +++--
.../fedora-kickstart-jeos.xml.in| 17
Let's use virtio as target-disk in case a target-disk is not set by the
apps. We can safely do this as we support unattended installation for
Ubuntu since its 12.04 release and virtio support has been added on 9.04.
Signed-off-by: Fabiano Fidêncio
---
data/install-script/ubuntu.com/ubuntu
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../opensuse.org/opensuse-autoyast
libosinfo could just
start using it without any issues.
Together with this change, let's also change the name from CentOS 7.0 to
CentOS 7 as it's the distro preferred way to advertise the system.
Signed-off-by: Fabiano Fidêncio
---
data/os/centos.org/centos-7.0.xml.in | 5 +++--
1 file
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../opensuse.org/opensuse-autoyast
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../redhat.com/rhel-kickstart-desktop.xml.in | 14 --
.../redhat.com/rhel-kickstart-jeos.xml.in
-by: Fabiano Fidêncio
---
data/install-script/redhat.com/rhel-kickstart-desktop.xml.in | 2 +-
data/install-script/redhat.com/rhel-kickstart-jeos.xml.in| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/data/install-script/redhat.com/rhel-kickstart-desktop.xml.in
b/data/install
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../centos.org/centos-kickstart-desktop.xml.in | 14 --
.../centos.org/centos-kickstart-jeos.xml.in
Let's add the script disk template so we don't actually require the apps
to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../silverblue-kickstart-desktop.xml.in | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff
Let's add a target-disk template so we actually can use what apps set as
target-disk, instead of using a hardcoded path to /dev/vda.
With this change we keep not requiring the apps to set this value.
Signed-off-by: Fabiano Fidêncio
---
.../opensuse-autoyast-desktop.xml.in | 21
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in | 17 +++--
.../fedora-kickstart-jeos.xml.in| 17
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in
Let's use virtio as target-disk in case a target-disk is not set by the
apps. We can safely do this as we support unattended installation for
Ubuntu since its 12.04 release and virtio support has been added on 9.04.
Signed-off-by: Fabiano Fidêncio
---
data/install-script/ubuntu.com/ubuntu
Let's add a target-disk template so we actually can use what apps set
as target-disk, instead of using a hardcoded path to /dev/vda.
With this change we keep not requiring the apps to set this value.
Signed-off-by: Fabiano Fidêncio
---
.../silverblue-kickstart-desktop.xml.in | 15
repo-oss template has been generating an empy extra space before the URL
it returns, which may break unattended installations.
Signed-off-by: Fabiano Fidêncio
---
.../install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 -
data/install-script/opensuse.org/opensuse-autoyast
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../redhat.com/rhel-kickstart
Although we only support unattended installations for CentOS 6 (or
newer), let's fix the condition for using virtio as the target disk.
Unlike suggested in the previous condition, virtio-block has only been
added to CentOS 5.6 (and not 5.0).
Signed-off-by: Fabiano Fidêncio
---
data/install
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../centos.org/centos-kickstart
can be removed from the apps dealing
with unattended installations (mainly from GNOME Boxes).
Fabiano Fidêncio (15):
install-script,fedora: Improve script-disk template
install-script,fedora,desktop: Add avatar-disk template
install-script,silverblue: Add script-disk template
install-script
Splitting centos & rhel script, done in 538ca137c, was not exactly the
best idea as it increased the maintenance for pretty much no gain.
With that in mind, let's merge back the scripts keeping the centos
specific bits conditionally added as part of the templates.
Signed-off-by: Fabiano Fidê
Silverblue follows exactly the same cycle as Fedora, reaching its end of
life at the same date.
Signed-off-by: Fabiano Fidêncio
---
data/os/fedoraproject.org/silverblue-28.xml.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/data/os/fedoraproject.org/silverblue-28.xml.in
b/data/os
On Tue, 2019-06-04 at 10:38 -0400, Cole Robinson wrote:
> On 6/4/19 3:30 AM, Fabiano Fidêncio wrote:
> > People,
> >
> > libosinfo/osinfo-db claims to support unattended installations of
> > various OSes and all the possible versions of each OS. However,
> > t
On Mon, 2019-06-03 at 18:33 -0400, Cole Robinson wrote:
> On 5/7/19 9:06 AM, Fabiano Fidêncio wrote:
> > This patch set adds support to advertising the firmware types an OS
> > supports and follows the same naming used by libvirt.
> >
> > For now, I've decided to n
-off-by: Fabiano Fidêncio
---
.../fedoraproject.org/fedora-kickstart-desktop.xml.in | 2 +-
.../fedoraproject.org/fedora-kickstart-jeos.xml.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/data/install-script/fedoraproject.org/fedora-kickstart
There's already a template for getting the proper script-disk value,
let's use it instead of hardcoding it to "A".
Signed-off-by: Fabiano Fidêncio
---
.../microsoft.com/windows-unattend-desktop.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/da
For scripts being used on Windows Vista+ the unattended installer can
also be used via cdrom and not only via a floppy device.
Signed-off-by: Fabiano Fidêncio
---
.../microsoft.com/windows-cmd-desktop.xml.in | 7 +++
.../microsoft.com/windows-unattend-desktop.xml.in
There's already a template for getting the proper target-disk value,
let's use it instead of hardcoding it to "C".
Signed-off-by: Fabiano Fidêncio
---
.../microsoft.com/windows-unattend-desktop.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/da
of libosinfo & consumers.
Signed-off-by: Fabiano Fidêncio
---
.../install-script/microsoft.com/windows-cmd-desktop.xml.in | 6 ++
1 file changed, 6 insertions(+)
diff --git a/data/install-script/microsoft.com/windows-cmd-desktop.xml.in
b/data/install-script/microsoft.com/windows
the complexity of their code.
Fabiano Fidêncio (5):
install-script,windows,desktop: Do not set user avatar for win8+
install-script,windows,desktop: Don't harcode the script-disk value
install-script,windows,dekstop: Don't hardcode the target-disk value
install-script,windows,desktop: Prevent infinite
, let's add a condition to *not* call
windows.cmd from windows.cmd file.
Signed-off-by: Fabiano Fidêncio
---
data/install-script/microsoft.com/windows-cmd-desktop.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/install-script/microsoft.com/windows-cmd-desktop.xml.in
b
On Wed, Jun 5, 2019 at 9:45 AM Fabiano Fidêncio wrote:
>
> For scripts being used on Windows Vista+ the unattended installer can
> also be used via cdrom and not only via a floppy device.
>
> Signed-off-by: Fabiano Fidêncio
Self-nack! I just found out we explicitl
For scripts being used on Windows Vista+ the unattended installer can
also be used via cdrom and not only via a floppy device.
Signed-off-by: Fabiano Fidêncio
---
It's important to mention that this change is not going to break current
consumers of those scripts.
There are more changes to come
upport Fedora29 and Fedora30);
- Windows: Windows 7+
By taking this path we'll have an easier time to ensure that our
scripts are working and also reduce the maintainability of those.
Shall I go for this change?
Best Regards,
--
Fabiano Fidêncio
___
Lib
On Mon, May 27, 2019 at 10:59 AM Fabiano Fidêncio wrote:
>
> Signed-off-by: Fabiano Fidêncio
> ---
> .../dragonflybsd-5.4.3.xml.in | 23 +++
> .../dfly-x86_64-5.4.3_REL.iso.txt | 29 +++
> 2 files changed, 52 insertions
These two patches have been pushed already.
Fabiano Fidêncio (2):
fedora28: Update URLs after EOL
centos7: Comment out CentOS-7-x86_64-DVD.iso URL
data/os/centos.org/centos-7.0.xml.in | 2 ++
data/os/fedoraproject.org/fedora-28.xml.in | 14 +++---
2 files changed, 9
CentOS servers have been under attack and they decided to forbid access
to this ISO.
Signed-off-by: Fabiano Fidêncio
---
data/os/centos.org/centos-7.0.xml.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/data/os/centos.org/centos-7.0.xml.in
b/data/os/centos.org/centos-7.0.xml.in
index
Signed-off-by: Fabiano Fidêncio
---
data/os/fedoraproject.org/fedora-28.xml.in | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/data/os/fedoraproject.org/fedora-28.xml.in
b/data/os/fedoraproject.org/fedora-28.xml.in
index 339bb9f..095f4ee 100644
--- a/data/os
0
>
> ___
> Libosinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
Reviewed-by: Fabiano Fidêncio
Thanks for the contribution!
Best Regards,
--
Fabiano Fidêncio
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
> Libosinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
Reviewed-by: Fabiano Fidêncio
Thanks for the contribution!
Best Regards,
--
Fabiano Fidêncio
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
54
> Joliet with UCS level 3 found
> Rock Ridge signatures version 1 found
> --
> 2.21.0
>
> ___
> Libosinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
I'll do the change before pushing!
Thanks for the contribution!
Reviewed-by: Fabiano Fidêncio
--
Fabiano Fidêncio
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
Similarly to what's been done as part of 1df4c0dbede91, let's just unset
XDG_CONFIG_HOME environment variable in our tests, in case those were
externally set for some reason.
https://gitlab.com/libosinfo/osinfo-db-tools/issues/3
Signed-off-by: Fabiano Fidêncio
---
tests/test_osinfo_db_path.py
test_related ensures that an OS entry is not inheriting from itself (or
from another OS which would end up inheriting from itself), avoiding
them to have an infinite loop on libosinfo side.
Signed-off-by: Fabiano Fidêncio
---
tests/test_related.py | 12
tests/util.py | 5
This series fixes the infinite loop caused by a typo in openbsd-6.3
entry and also adds a test avoiding this issue to happen in the future.
Fabiano Fidêncio (2):
openbsd-6.3: Fix derives-from
tests: Add test_related
data/os/openbsd.org/openbsd-6.3.xml.in | 2 +-
tests/test_related.py
The OS derives from OpenBSD 6.2 and not 6.3. More than that, having a
distro deriving from itself will cause an infinite loop on osinfo-db
functions recurring on the derives-from field.
Signed-off-by: Fabiano Fidêncio
---
data/os/openbsd.org/openbsd-6.3.xml.in | 2 +-
1 file changed, 1
Otherwise ppc64 could also match ppc64le.
Signed-off-by: Fabiano Fidêncio
---
data/os/redhat.com/rhel-7.2.xml.in | 2 +-
data/os/redhat.com/rhel-7.3.xml.in | 2 +-
data/os/redhat.com/rhel-7.4.xml.in | 2 +-
data/os/redhat.com/rhel-7.5.xml.in | 2 +-
data/os/redhat.com/rhel-7.6.xml.in | 2 +-
5
The series cover:
- Anchoring ppc64 arch entries for treeinfo, so those do not match
ppc64le;
- Adding ppc64le resources (same as the ones for ppc64) for rhel-7;
- Adjusting rhel-8.0 resources to use ppc64le as arch, instead of using
ppc64 (as there are no ppc64 ISOs for rhel-8.0);
Fabiano
rhel-8.0 doesn't have any ppc64 media/tree. The correct architecture
name, matching with existent medias and trees for the os, is ppc64le.
Signed-off-by: Fabiano Fidêncio
---
data/os/redhat.com/rhel-8.0.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/os
Those are exactly the same as the ones used for ppc64.
Signed-off-by: Fabiano Fidêncio
---
data/os/redhat.com/rhel-7.2.xml.in | 15 +++
data/os/redhat.com/rhel-7.3.xml.in | 15 +++
data/os/redhat.com/rhel-7.4.xml.in | 15 +++
data/os/redhat.com/rhel-7.5
Signed-off-by: Fabiano Fidêncio
---
.../dragonflybsd-5.4.3.xml.in | 23 +++
.../dfly-x86_64-5.4.3_REL.iso.txt | 29 +++
2 files changed, 52 insertions(+)
create mode 100644 data/os/dragonflybsd.org/dragonflybsd-5.4.3.xml.in
create mode
On Mon, May 27, 2019 at 10:23 AM Pino Toscano wrote:
>
> - remove the prerelease status
> - add the release date
> - add the URLs of the ISOs
> - switch the tree URL to https
> - update the isodata test data
Reviewed-by
Signed-off-by: Fabiano Fidêncio
---
Pushed under test breakage rule
---
data/os/dragonflybsd.org/dragonflybsd-5.4.2.xml.in | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/data/os/dragonflybsd.org/dragonflybsd-5.4.2.xml.in
b/data/os/dragonflybsd.org/dragonflybsd-5.4.2
+
> data/os/suse.com/sles-12.4.xml.in | 65
> +++
> 2 files changed, 103 insertions(+)
> create mode 100644 data/os/suse.com/sled-12.4.xml.in
> create mode 100644 data/os/suse.com/sles-12.4.xml.
After the addition of sles/sled 12.4, let's update the unknown entries'
regular expression to match 12.5+.
*: https://www.redhat.com/archives/libosinfo/2019-May/msg00148.html
Fabiano Fidêncio (2):
sled-12-unknown: Update regex after 12.4 addition
sles-12-unknown: Update regex after 12.4
Signed-off-by: Fabiano Fidêncio
---
data/os/suse.com/sles-12-unknown.xml.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/data/os/suse.com/sles-12-unknown.xml.in
b/data/os/suse.com/sles-12-unknown.xml.in
index 0b69493..fe4b181 100644
--- a/data/os/suse.com/sles-12
Signed-off-by: Fabiano Fidêncio
---
data/os/suse.com/sled-12-unknown.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/data/os/suse.com/sled-12-unknown.xml.in
b/data/os/suse.com/sled-12-unknown.xml.in
index d3fb3bc..9df7b18 100644
--- a/data/os/suse.com/sled-12
em.
Before pushing the patches, tho, I'll also propose an update to the
unknown entries.
Last but not least, would be really nice to have the test files
(`isoinfo -d -i iso`) added to our osinfo-db tests.
So, consider those two patches Reviewed-by: Fabiano Fidêncio
and those will be pushed togeth
This is another case of FORWARD_NULL, due to the possibility of calling
unlink(NULL) in another piece of osinfo-db-import code;
Fabiano Fidêncio (1):
import: Don't call unlink(NULL) in _import_extract()
tools/osinfo-db-import.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.21.0
Signed-off-by: Fabiano Fidêncio
---
data/os/redhat.com/rhel-8.0.xml.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/data/os/redhat.com/rhel-8.0.xml.in
b/data/os/redhat.com/rhel-8.0.xml.in
index 2ba1ad1..157c498 100644
--- a/data/os/redhat.com/rhel-8.0.xml.in
+++ b/data/os/redhat.com/rhel
rhel-8.0 entry didn't have any codename set and rhel-8-unknown has been
using rhel-7's codename.
Fabiano Fidêncio (2):
rhel-8.0: Add codename (Ootpa)
rhel-8-unknown: Fix codename
data/os/redhat.com/rhel-8-unknown.xml.in | 2 +-
data/os/redhat.com/rhel-8.0.xml.in | 1 +
2 files changed
As suggested by Cole, let's keep just one implementation of
_parse_iso_date() (the most compatible one) and avoid diverging over
time.
Signed-off-by: Fabiano Fidêncio
---
tests/test_dates.py | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/tests/test_dates.py b
of ideas on how to proceed, thus I'd be
really happy to get some suggestions.
Best Regards,
--
Fabiano Fidêncio
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
On Tue, 2019-05-21 at 17:21 +0200, Pino Toscano wrote:
> datetime.date.fromisoformat() was introduced in Python 3.7, so
> provide
> an alternative implementation for it with older Python versions.
>
> Fixes commit 5da3b8fdd836a55a58365718e93d0372fcc2bf0b.
Reviewed-by: F
On Tue, 2019-05-21 at 15:34 +0200, Pino Toscano wrote:
> On Tuesday, May 21, 2019 2:39:37 PM CEST Fabiano Fidêncio wrote:
> > So, in the end, my suggestion is to add to this patches something
> > like:
> > ```
> > fidencio@laerte ~/src/upstream/osinfo-db $ git
On Tue, 2019-05-21 at 14:30 +0200, Fabiano Fidêncio wrote:
> On Tue, 2019-05-21 at 14:01 +0200, Pino Toscano wrote:
> > For each OS, check two things:
> > - release-date/eol-date are actually valid dates; this is needed
> > because
> > the schema just specifies the
On Tue, 2019-05-21 at 14:30 +0200, Fabiano Fidêncio wrote:
> On Tue, 2019-05-21 at 14:01 +0200, Pino Toscano wrote:
> > ---
> > tests/osinfo.py | 8
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/tests/osinfo.py b/tests/osinfo.py
On Tue, 2019-05-21 at 14:01 +0200, Pino Toscano wrote:
> ---
> tests/osinfo.py | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/tests/osinfo.py b/tests/osinfo.py
> index 3585f44..20c1866 100644
> --- a/tests/osinfo.py
> +++ b/tests/osinfo.py
> @@ -137,6 +137,14 @@ class
On Tue, 2019-05-21 at 14:01 +0200, Pino Toscano wrote:
> For each OS, check two things:
> - release-date/eol-date are actually valid dates; this is needed
> because
> the schema just specifies the regex, and it cannot detect invalid
> dates such as "2019-05-00" or 2019-05-40"
> - if both
On Tue, 2019-05-21 at 13:26 +0200, Pino Toscano wrote:
> *** LOOK, A BLURB HERE! ***
>
> Pino Toscano (3):
> openbsd: add missing
> openbsd: fill missing
> openbsd: fix of 4.3
Reviewed-by: Fabiano Fidêncio
I'll push those in a few, thanks for the contribut
This series fixes 2 issues found by either coverity or clang. Together
with the second fix, there's also a patch cleaning the code up a little
bit.
Fabiano Fidêncio (3):
db: Avoid dereference of null pointer
tree: Avoid use of memory after it's freed
tree: Cleanup
There's no need to pass neither the URL nor the cancellable to this
function as those can be taken directly from data.
Signed-off-by: Fabiano Fidêncio
---
osinfo/osinfo_tree.c | 27 ---
1 file changed, 8 insertions(+), 19 deletions(-)
diff --git a/osinfo/osinfo_tree.c b
st caller of osinfo_tree_create_from_location_async_helper(), as
its content is always going to be the same doesn't matter the treeinfo
format to be used with.
Signed-off-by: Fabiano Fidêncio
---
osinfo/osinfo_tree.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/osinfo/osinfo_tree.c
-off-by: Fabiano Fidêncio
---
osinfo/osinfo_db.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/osinfo/osinfo_db.c b/osinfo/osinfo_db.c
index b7da2b7..c4cd1e4 100644
--- a/osinfo/osinfo_db.c
+++ b/osinfo/osinfo_db.c
@@ -790,6 +790,7 @@ static gboolean compare_tree
Error: CLANG_WARNING:
osinfo-db-tools-1.5.0/tools/osinfo-db-validate.c:319:9: warning:
Potential leak of memory pointed to by 'files'
#g_printerr("%s\n", error->message);
#^
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-db-validate.c | 1 +
1 file changed
there is a missing assigment that would make
"err" not remain constant.
# 447| archive_write_free(arc);
# 448| if (err)
# 449|-> g_error_free(err);
# 450| return ret;
# 451| }
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-db-export.c | 3 ---
1 file changed, 3
unlink(*source_file);
# 182|
# 183| return ret;
Error: CLANG_WARNING:
osinfo-db-tools-1.5.0/tools/osinfo-db-import.c:181:9: warning: Null
pointer passed as an argument to a 'nonnull' parameter
#unlink(*source_file);
#^
Signed-off-by: Fabiano Fidêncio
---
tools/o
pointed to by "files";
Fabiano Fidêncio (3):
import: Don't call unlink(NULL)
export: Remove unused variable
validate: Don't leak "files"
tools/osinfo-db-export.c | 3 ---
tools/osinfo-db-import.c | 2 +-
tools/osinfo-db-validate.c | 1 +
3 files changed, 2 insert
Let's use a URL where the file names are not changing on every new
release.
Signed-off-by: Fabiano Fidêncio
---
Pushed under test breakage rule
---
data/os/debian.org/debian-9.xml.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/data/os/debian.org/debian-9.xml.in
GVfs requires the session bus i order to work properly, which means
`DBUS_SESSION_BUS_ADDRESS` has to be defined in the environment.
https://gitlab.com/libosinfo/libosinfo/issues/30
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-db-import.c | 6 ++
1 file changed, 6 insertions(+)
diff
GVfs requires the session bus i order to work properly, which means
`DBUS_SESSION_BUS_ADDRESS` has to be defined in the environment.
https://gitlab.com/libosinfo/libosinfo/issues/30
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-detect.c | 6 ++
1 file changed, 6 insertions(+)
diff
-export --help
Thanks to everyone who contributed to this release
Best Regards,
Fabiano Fidêncio
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
uot;treeinfo" files
- Explicitly set GVFS as a requirement in the project spec file
- Move osinfo-db related tests to osinfo-db project
Thanks to everyone who contributed to this release
Best Regards,
Fabiano Fidêncio
___
Libosinfo mailing list
Libos
sinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
Reviewed-by: Fabiano Fidêncio
--
Fabiano Fidêncio
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
.berrange.com :|
> |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
>
> ___
> Libosinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
Best Regards,
--
Fabiano Fidên
Let's add APIs for both adding a firmware to or retrieving the list of
firmwares from an OS.
Signed-off-by: Fabiano Fidêncio
---
osinfo/libosinfo.syms | 3 ++
osinfo/osinfo_os.c| 96 +++
osinfo/osinfo_os.h| 3 ++
3 files changed, 102 insertions
OsinfoFirmwareList has been created in order to represent a list of
firmwares supported by an OS, as an OS may support various firmwares
without any issue.
Signed-off-by: Fabiano Fidêncio
---
docs/reference/Libosinfo-docs.xml | 1 +
osinfo/Makefile.am| 2 +
osinfo
This series contains the machinery needed for loading, adding, and
retrieving information about firmware support of a specific OS.
The osinfo-db part of the series can be seen here:
https://www.redhat.com/archives/libosinfo/2019-May/msg00071.html
Fabiano Fidêncio (7):
firmware: Add
Signed-off-by: Fabiano Fidêncio
---
.gitignore| 1 +
tests/Makefile.am | 5 +
tests/test-firmwarelist.c | 209 ++
3 files changed, 215 insertions(+)
create mode 100644 tests/test-firmwarelist.c
diff --git a/.gitignore b/.gitignore
201 - 300 of 1627 matches
Mail list logo
