Re: [Libosinfo] [libosinfo PATCH v2 1/2] osinfo: Create an intermediate convenience library

2018-11-21 Thread Fabiano Fidêncio
On Wed, 2018-11-21 at 09:08 +, Daniel P. Berrangé wrote: > On Wed, Nov 21, 2018 at 09:44:47AM +0100, Christophe Fergeau wrote: > > Ok, 2 more comments actually, > > > > On Tue, Nov 20, 2018 at 03:11:23PM +0100, Fabiano Fidêncio wrote: > > > Let's create libosinfo-impl.la which is nothing else

Re: [Libosinfo] [libosinfo PATCH v2 1/2] osinfo: Create an intermediate convenience library

2018-11-21 Thread Christophe Fergeau
Hey, On Tue, Nov 20, 2018 at 03:11:23PM +0100, Fabiano Fidêncio wrote: > Let's create libosinfo-impl.la which is nothing else than > libosinfo-1.0.la without stripping out its non-public symbols. > > libosinfo-impl.la can be used to link directly against our tests (as > those may use private

Re: [Libosinfo] [libosinfo PATCH v2 1/2] osinfo: Create an intermediate convenience library

2018-11-21 Thread Christophe Fergeau
On Wed, Nov 21, 2018 at 09:08:05AM +, Daniel P. Berrangé wrote: > On Wed, Nov 21, 2018 at 09:44:47AM +0100, Christophe Fergeau wrote: > > > -nodist_libosinfo_1_0_la_SOURCES =\ > > > +nodist_libosinfo_impl_la_SOURCES = \ > > >osinfo_enum_types.c\ > > >

Re: [Libosinfo] [libosinfo PATCH v2 1/2] osinfo: Create an intermediate convenience library

2018-11-21 Thread Daniel P . Berrangé
On Wed, Nov 21, 2018 at 09:44:47AM +0100, Christophe Fergeau wrote: > Ok, 2 more comments actually, > > On Tue, Nov 20, 2018 at 03:11:23PM +0100, Fabiano Fidêncio wrote: > > Let's create libosinfo-impl.la which is nothing else than > > libosinfo-1.0.la without stripping out its non-public

Re: [Libosinfo] [libosinfo PATCH v2 1/2] osinfo: Create an intermediate convenience library

2018-11-21 Thread Christophe Fergeau
Ok, 2 more comments actually, On Tue, Nov 20, 2018 at 03:11:23PM +0100, Fabiano Fidêncio wrote: > Let's create libosinfo-impl.la which is nothing else than > libosinfo-1.0.la without stripping out its non-public symbols. > > libosinfo-impl.la can be used to link directly against our tests (as >

[Libosinfo] [libosinfo] build: Use EXTRA_..._DEPENDENCIES rather than _DEPENDENCIES

2018-11-21 Thread Christophe Fergeau
This allows us to use the dependencies automatically generated by automake while appending the additional one that we need. https://www.gnu.org/software/automake/manual/automake.html#index-EXTRA_005fmaude_005fDEPENDENCIES-1 « The EXTRA_*_DEPENDENCIES variable may be useful for cases where you