Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Thu, May 31, 2018 at 04:19:54PM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 3:35 PM, Christophe Fergeau > wrote: > > On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fidêncio wrote: > >> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau > >> wrote: > >> > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: > >> >> > If they are public, what happens in libosinfo if we try to set a > >> >> > non-existent parameter? In other word, should we consider this an > >> >> > API/ABI break, or are we fine with dropping it? > >> >> > >> >> We're totally fine dropping it. > >> >> If we try to set a non-existent parameter (or pattern) autoyast is > >> >> smart enough to not break the installation because of that. > >> > > >> > My worry was in libosinfo API, what happens to code using libosinfo and > >> > trying to set this config parameter? Is this going to cause problems? Or > >> > will it just be ignored? > >> > >> I see. About this, we don't actually set this parameter never ever. > >> It's been only internal so far. > > > > "we"? My question was more if hypothetical "unknown" libosinfo users > > could try to use that, and get failures after it gets removed. I agree > > it's very far fetched, I was just trying to assess the impact of this > > removal ;) > > > > "We" :-) > I meant, libosinfo doesn't even expose this option, never ever. Ah ok, I was not fully sure if tihs was the case or not, thanks for bearing with me. And sorry for spending time on something that did not need discussing! Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Thu, May 31, 2018 at 3:35 PM, Christophe Fergeau wrote: > On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fidêncio wrote: >> On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau >> wrote: >> > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: >> >> > If they are public, what happens in libosinfo if we try to set a >> >> > non-existent parameter? In other word, should we consider this an >> >> > API/ABI break, or are we fine with dropping it? >> >> >> >> We're totally fine dropping it. >> >> If we try to set a non-existent parameter (or pattern) autoyast is >> >> smart enough to not break the installation because of that. >> > >> > My worry was in libosinfo API, what happens to code using libosinfo and >> > trying to set this config parameter? Is this going to cause problems? Or >> > will it just be ignored? >> >> I see. About this, we don't actually set this parameter never ever. >> It's been only internal so far. > > "we"? My question was more if hypothetical "unknown" libosinfo users > could try to use that, and get failures after it gets removed. I agree > it's very far fetched, I was just trying to assess the impact of this > removal ;) > "We" :-) I meant, libosinfo doesn't even expose this option, never ever. May be the case, at some point in the future, that we'll need to expose it and leave it to the user decide whether they want or not to add some additional scripts to configure something post installation, That's not the case for now. > Christophe Thanks a lot for the review, Christophe! -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Thu, May 31, 2018 at 02:55:18PM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau > wrote: > > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: > >> > If they are public, what happens in libosinfo if we try to set a > >> > non-existent parameter? In other word, should we consider this an > >> > API/ABI break, or are we fine with dropping it? > >> > >> We're totally fine dropping it. > >> If we try to set a non-existent parameter (or pattern) autoyast is > >> smart enough to not break the installation because of that. > > > > My worry was in libosinfo API, what happens to code using libosinfo and > > trying to set this config parameter? Is this going to cause problems? Or > > will it just be ignored? > > I see. About this, we don't actually set this parameter never ever. > It's been only internal so far. "we"? My question was more if hypothetical "unknown" libosinfo users could try to use that, and get failures after it gets removed. I agree it's very far fetched, I was just trying to assess the impact of this removal ;) Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex
On Thu, May 31, 2018 at 02:57:14PM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 2:23 PM, Christophe Fergeau > wrote: > > On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fidêncio wrote: > >> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau > >> wrote: > >> > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: > >> >> The regex to match unknown openSUSE prereleases is becoming > >> >> bigger and harder to read. > >> >> > >> >> Basically, what it's doing is: > >> >> > >> >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9]) > >> >> - - - > >> >> | | || | > >> >> v v v| v > >> >> 15.1+ 16 20, 30, 50 - 90 v 43.0+ > >> >> .0, .1, ..., .9 > >> >> > >> >> I'm desconsidering both the 13.x series or older and 42.x series as > >> >> those are not going to have new releases anymore. > >> > > >> > "desconsidering"? Dropping? > >> > >> I'll change it to "Dropping" before pushing. > >> > >> > Note that > >> > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the > >> > door on another 42.x release "There are currently no plans to release an > >> > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but > >> > that's close enough. > >> > Are they really going to release 43.x in parallel to/after 15.x? > >> > >> No, they have no intention to release 43.x. I've talked to Richard > >> Brown about this during openSUSE conference last weekend and > >> explanation he gave me is that they're moving back to a number that > >> would match SLES. > >> The whole 42.x series was in order to totally distinguish between the > >> old base they had with the new shiny system that Leap was supposed to > >> be. > >> > >> So, they're now following 15.x ... if at some point SLES will have a > >> 16.x opensuse 16.x will come to the playground as well. > > > > Your regexp in the commit log and in your patch has a 43.x part, so this > > can be dropped. > > I see where the confusion came from. > So, if you don't mind I'd prefer to keep it there because the regex is > keep everything: > 15.1+, 16-41, NOT 42, 43-99 Ah ok, you want to match all version numbers which never corresponded to something which was released. Acked-by: Christophe Fergeau Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex
On Thu, May 31, 2018 at 2:23 PM, Christophe Fergeau wrote: > On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fidêncio wrote: >> On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau >> wrote: >> > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: >> >> The regex to match unknown openSUSE prereleases is becoming >> >> bigger and harder to read. >> >> >> >> Basically, what it's doing is: >> >> >> >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9]) >> >> - - - >> >> | | || | >> >> v v v| v >> >> 15.1+ 16 20, 30, 50 - 90 v 43.0+ >> >> .0, .1, ..., .9 >> >> >> >> I'm desconsidering both the 13.x series or older and 42.x series as >> >> those are not going to have new releases anymore. >> > >> > "desconsidering"? Dropping? >> >> I'll change it to "Dropping" before pushing. >> >> > Note that >> > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the >> > door on another 42.x release "There are currently no plans to release an >> > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but >> > that's close enough. >> > Are they really going to release 43.x in parallel to/after 15.x? >> >> No, they have no intention to release 43.x. I've talked to Richard >> Brown about this during openSUSE conference last weekend and >> explanation he gave me is that they're moving back to a number that >> would match SLES. >> The whole 42.x series was in order to totally distinguish between the >> old base they had with the new shiny system that Leap was supposed to >> be. >> >> So, they're now following 15.x ... if at some point SLES will have a >> 16.x opensuse 16.x will come to the playground as well. > > Your regexp in the commit log and in your patch has a 43.x part, so this > can be dropped. I see where the confusion came from. So, if you don't mind I'd prefer to keep it there because the regex is keep everything: 15.1+, 16-41, NOT 42, 43-99 > > Christophe If you have some strong feelings about this, then I'll drop it. -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Thu, May 31, 2018 at 2:24 PM, Christophe Fergeau wrote: > On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: >> > If they are public, what happens in libosinfo if we try to set a >> > non-existent parameter? In other word, should we consider this an >> > API/ABI break, or are we fine with dropping it? >> >> We're totally fine dropping it. >> If we try to set a non-existent parameter (or pattern) autoyast is >> smart enough to not break the installation because of that. > > My worry was in libosinfo API, what happens to code using libosinfo and > trying to set this config parameter? Is this going to cause problems? Or > will it just be ignored? I see. About this, we don't actually set this parameter never ever. It's been only internal so far. Sorry, just now I understood your question :-/ > > Christophe -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Thu, May 31, 2018 at 12:00:22PM +0200, Fabiano Fidêncio wrote: > > If they are public, what happens in libosinfo if we try to set a > > non-existent parameter? In other word, should we consider this an > > API/ABI break, or are we fine with dropping it? > > We're totally fine dropping it. > If we try to set a non-existent parameter (or pattern) autoyast is > smart enough to not break the installation because of that. My worry was in libosinfo API, what happens to code using libosinfo and trying to set this config parameter? Is this going to cause problems? Or will it just be ignored? Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex
On Thu, May 31, 2018 at 11:57:51AM +0200, Fabiano Fidêncio wrote: > On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau > wrote: > > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: > >> The regex to match unknown openSUSE prereleases is becoming > >> bigger and harder to read. > >> > >> Basically, what it's doing is: > >> > >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9]) > >> - - - > >> | | || | > >> v v v| v > >> 15.1+ 16 20, 30, 50 - 90 v 43.0+ > >> .0, .1, ..., .9 > >> > >> I'm desconsidering both the 13.x series or older and 42.x series as > >> those are not going to have new releases anymore. > > > > "desconsidering"? Dropping? > > I'll change it to "Dropping" before pushing. > > > Note that > > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the > > door on another 42.x release "There are currently no plans to release an > > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but > > that's close enough. > > Are they really going to release 43.x in parallel to/after 15.x? > > No, they have no intention to release 43.x. I've talked to Richard > Brown about this during openSUSE conference last weekend and > explanation he gave me is that they're moving back to a number that > would match SLES. > The whole 42.x series was in order to totally distinguish between the > old base they had with the new shiny system that Leap was supposed to > be. > > So, they're now following 15.x ... if at some point SLES will have a > 16.x opensuse 16.x will come to the playground as well. Your regexp in the commit log and in your patch has a 43.x part, so this can be dropped. Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [libosinfo][PATCH v2] tests: Add test-os-resources
Acked-by: Christophe Fergeau
On Fri, May 04, 2018 at 10:34:09PM +0200, Fabiano Fidêncio wrote:
> From: Fabiano Fidêncio
>
> test-os-resources has been written to avoid bug as having minimum
> resources greater than the recommended resources in osinfo-db.
>
> This problem was exposed by RHEL/CentOS data files, which caused some
> really bad UI effect in clientes using those two attributes (as GNOME
> Boxes).
>
> Signed-off-by: Fabiano Fidêncio
> ---
> tests/Makefile.am | 5 ++
> tests/test-os-resources.c | 184
> ++
> 2 files changed, 189 insertions(+)
> create mode 100644 tests/test-os-resources.c
>
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 7566d3c..06f81bf 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -17,6 +17,7 @@ check_PROGRAMS = \
> test-loader \
> test-isodetect \
> test-install-script \
> + test-os-resources \
> $(NULL)
>
> if HAVE_CURL
> @@ -111,6 +112,10 @@ test_install_script_LDADD = $(COMMON_LDADD)
> test_install_script_CFLAGS = $(COMMON_CFLAGS)
> test_install_script_SOURCES = test-install-script.c
>
> +test_os_resources_LDADD = $(COMMON_LDADD)
> +test_os_resources_CFLAGS = $(COMMON_CFLAGS)
> +test_os_resources_SOURCES = test-os-resources.c
> +
> TESTS = $(check_PROGRAMS) \
> $(NULL)
>
> diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c
> new file mode 100644
> index 000..f7a8039
> --- /dev/null
> +++ b/tests/test-os-resources.c
> @@ -0,0 +1,184 @@
> +/*
> + * Copyright (C) 2017 Fabiano Fidêncio
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation,
> + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> + *
> + * Authors:
> + * Fabiano Fidêncio
> + */
> +
> +#include
> +
> +#include
> +#include
> +
> +
> +static void test_n_cpus(OsinfoResources *minimum, OsinfoResources
> *recommended)
> +{
> +gint minimum_cpus, recommended_cpus;
> +
> +minimum_cpus = osinfo_resources_get_n_cpus(minimum);
> +recommended_cpus = osinfo_resources_get_n_cpus(recommended);
> +
> +if (recommended_cpus >= 0 && minimum_cpus >= 0)
> +g_assert_true(recommended_cpus >= minimum_cpus);
> +}
> +
> +
> +static void test_cpu(OsinfoResources *minimum, OsinfoResources *recommended)
> +{
> +gint64 minimum_cpu, recommended_cpu;
> +
> +minimum_cpu = osinfo_resources_get_cpu(minimum);
> +recommended_cpu = osinfo_resources_get_cpu(recommended);
> +
> +if (recommended_cpu >= 0 && minimum_cpu >= 0)
> +g_assert_true(recommended_cpu >= minimum_cpu);
> +}
> +
> +
> +static void test_ram(OsinfoResources *minimum, OsinfoResources *recommended)
> +{
> +gint64 minimum_ram, recommended_ram;
> +
> +minimum_ram = osinfo_resources_get_ram(minimum);
> +recommended_ram = osinfo_resources_get_ram(recommended);
> +
> +if (recommended_ram >= 0 && minimum_ram >= 0)
> +g_assert_true(recommended_ram >= minimum_ram);
> +}
> +
> +
> +static void test_storage(OsinfoResources *minimum, OsinfoResources
> *recommended)
> +{
> +gint64 minimum_storage, recommended_storage;
> +
> +minimum_storage = osinfo_resources_get_storage(minimum);
> +recommended_storage = osinfo_resources_get_storage(recommended);
> +
> +if (recommended_storage >= 0 && minimum_storage >= 0)
> +g_assert_true(recommended_storage >= minimum_storage);
> +}
> +
> +static void
> +test_minimum_recommended_resources(void)
> +{
> +OsinfoLoader *loader = osinfo_loader_new();
> +OsinfoDb *db = osinfo_loader_get_db(loader);
> +OsinfoOsList *oslist;
> +GList *oses;
> +GList *oses_it;
> +GError *error = NULL;
> +
> +g_assert_true(OSINFO_IS_LOADER(loader));
> +g_assert_true(OSINFO_IS_DB(db));
> +
> +osinfo_loader_process_default_path(loader, );
> +g_assert_no_error(error);
> +
> +oslist = osinfo_db_get_os_list(db);
> +oses = osinfo_list_get_elements(OSINFO_LIST(oslist));
> +
> +for (oses_it = oses; oses_it != NULL; oses_it = oses_it->next) {
> +OsinfoOs *os = oses->data;
> +OsinfoResourcesList *minimum_list, *recommended_list;
> +GList *minimum_resources, *recommended_resources;
> +GList *resources_it;
> +const gchar *minimum_arch, *recommended_arch;
> +
> +minimum_list =
Re: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata
On Thu, May 31, 2018 at 11:16 AM, Christophe Fergeau wrote: > Hey, > > Commented on some of the patches, but for the series, > > Acked-by: Christophe Fergeau Thanks for the review, I'll address your comments, push the patches and do a release later Today. > > On Sat, May 26, 2018 at 10:29:37PM +0200, Fabiano Fidêncio wrote: >> Signed-off-by: Fabiano Fidêncio >> --- >> .../openSUSE-Leap-15.0-DVD-x86_64.iso.txt | 29 >> ++ >> .../openSUSE-Leap-15.0-NET-x86_64.iso.txt | 29 >> ++ >> 2 files changed, 58 insertions(+) >> create mode 100644 >> tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt >> create mode 100644 >> tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt >> >> diff --git >> a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt >> b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt >> new file mode 100644 >> index 000..e89a0de >> --- /dev/null >> +++ >> b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt >> @@ -0,0 +1,29 @@ >> +CD-ROM is in ISO 9660 format >> +System id: LINUX >> +Volume id: openSUSE-Leap-15.0-DVD-x86_64267 >> +Volume set id: >> +Publisher id: SUSE LINUX GmbH >> +Data preparer id: KIWI - http://opensuse.github.com/kiwi >> +Application id: openSUSE-Leap-15.0-DVD-x86_64-Build267.2-Media >> +Copyright File id: >> +Abstract File id: >> +Bibliographic File id: >> +Volume set size is: 1 >> +Volume set sequence number is: 1 >> +Logical block size is: 2048 >> +Volume size is: 1912564 >> +El Torito VD version 1 found, boot catalog is in sector 20 >> +Joliet with UCS level 3 found >> +Rock Ridge signatures version 1 found >> +Eltorito validation header: >> +Hid 1 >> +Arch 0 (x86) >> +ID 'SUSE LINUX GmbH' >> +Key 55 AA >> +Eltorito defaultboot header: >> +Bootid 88 (bootable) >> +Boot media 0 (No Emulation Boot) >> +Load segment 0 >> +Sys type 0 >> +Nsect 4 >> +Bootoff 145C 5212 >> diff --git >> a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt >> b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt >> new file mode 100644 >> index 000..d6e6619 >> --- /dev/null >> +++ >> b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt >> @@ -0,0 +1,29 @@ >> +CD-ROM is in ISO 9660 format >> +System id: LINUX >> +Volume id: openSUSE-Leap-15.0-NET-x86_64267 >> +Volume set id: >> +Publisher id: SUSE LINUX GmbH >> +Data preparer id: KIWI - http://opensuse.github.com/kiwi >> +Application id: openSUSE-Leap-15.0-NET-x86_64-Build267.2-Media >> +Copyright File id: >> +Abstract File id: >> +Bibliographic File id: >> +Volume set size is: 1 >> +Volume set sequence number is: 1 >> +Logical block size is: 2048 >> +Volume size is: 60205 >> +El Torito VD version 1 found, boot catalog is in sector 20 >> +Joliet with UCS level 3 found >> +Rock Ridge signatures version 1 found >> +Eltorito validation header: >> +Hid 1 >> +Arch 0 (x86) >> +ID 'SUSE LINUX GmbH' >> +Key 55 AA >> +Eltorito defaultboot header: >> +Bootid 88 (bootable) >> +Boot media 0 (No Emulation Boot) >> +Load segment 0 >> +Sys type 0 >> +Nsect 4 >> +Bootoff FC8 4040 >> -- >> 2.14.3 >> >> ___ >> Libosinfo mailing list >> Libosinfo@redhat.com >> https://www.redhat.com/mailman/listinfo/libosinfo -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust upgrades/derives-from for leap 15.0
On Thu, May 31, 2018 at 11:11 AM, Christophe Fergeau wrote: > On Sat, May 26, 2018 at 10:29:41PM +0200, Fabiano Fidêncio wrote: >> Signed-off-by: Fabiano Fidêncio >> --- >> data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in >> b/data/os/opensuse.org/opensuse-unknown.xml.in >> index 195ea4a..1292372 100644 >> --- a/data/os/opensuse.org/opensuse-unknown.xml.in >> +++ b/data/os/opensuse.org/opensuse-unknown.xml.in >> @@ -8,8 +8,8 @@ >> <_vendor>openSUSE >> linux >> opensuse >> -http://opensuse.org/opensuse/42.2"/> >> -http://opensuse.org/opensuse/42.2"/> >> +http://opensuse.org/opensuse/15.0"/> >> +http://opensuse.org/opensuse/15.0"/> > > Huhu, 15.0 being newer than 42.2 is odd ;) > > Christophe Indeed :-) -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Thu, May 31, 2018 at 11:11 AM, Christophe Fergeau wrote: > On Sat, May 26, 2018 at 10:29:38PM +0200, Fabiano Fidêncio wrote: >> As we don't do anything in the second stage, we can just skip it >> entirely without any issues. >> >> Signed-off-by: Fabiano Fidêncio >> --- >> data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git >> a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in >> b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in >> index 6554eb6..537c266 100644 >> --- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in >> +++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in >> @@ -144,6 +144,7 @@ >> >> >> false >> +false > > Are these 'config:type' parameters something which is exposed to the > library user, right? Or Are they something purley internal? Those are public. They're used for specialized scripts, they're still supported we just never used it. It's going to work without issues with the Leap series. For the older ones, we don't even support express installation. > If they are public, what happens in libosinfo if we try to set a > non-existent parameter? In other word, should we consider this an > API/ABI break, or are we fine with dropping it? We're totally fine dropping it. If we try to set a non-existent parameter (or pattern) autoyast is smart enough to not break the installation because of that. > > Christophe -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex
On Thu, May 31, 2018 at 10:54 AM, Christophe Fergeau wrote: > On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: >> The regex to match unknown openSUSE prereleases is becoming >> bigger and harder to read. >> >> Basically, what it's doing is: >> >> (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9]) >> - - - >> | | || | >> v v v| v >> 15.1+ 16 20, 30, 50 - 90 v 43.0+ >> .0, .1, ..., .9 >> >> I'm desconsidering both the 13.x series or older and 42.x series as >> those are not going to have new releases anymore. > > "desconsidering"? Dropping? I'll change it to "Dropping" before pushing. > Note that > https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the > door on another 42.x release "There are currently no plans to release an > openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but > that's close enough. > Are they really going to release 43.x in parallel to/after 15.x? No, they have no intention to release 43.x. I've talked to Richard Brown about this during openSUSE conference last weekend and explanation he gave me is that they're moving back to a number that would match SLES. The whole 42.x series was in order to totally distinguish between the old base they had with the new shiny system that Leap was supposed to be. So, they're now following 15.x ... if at some point SLES will have a 16.x opensuse 16.x will come to the playground as well. > > Christophe > >> >> Also, (DVD|NET|Kubic) was introduced as this is the naming chosen for >> DVD or NET installation or whether it's a Kubic DVD installation. >> >> Signed-off-by: Fabiano Fidêncio >> --- >> data/os/opensuse.org/opensuse-unknown.xml.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in >> b/data/os/opensuse.org/opensuse-unknown.xml.in >> index 06ae67a..6a8a3b2 100644 >> --- a/data/os/opensuse.org/opensuse-unknown.xml.in >> +++ b/data/os/opensuse.org/opensuse-unknown.xml.in >> @@ -14,7 +14,7 @@ >> >> >> >> - >> openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD-x86_64 >> + >> openSUSE-Leap-(15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])-(DVD|NET|Kubic)-x86_64* >> LINUX >> SUSE LINUX GmbH >> >> -- >> 2.14.3 >> >> ___ >> Libosinfo mailing list >> Libosinfo@redhat.com >> https://www.redhat.com/mailman/listinfo/libosinfo -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [libosinfo][PATCH] opensuse: Add Leap 15.0 isodata
Hey, Commented on some of the patches, but for the series, Acked-by: Christophe Fergeau On Sat, May 26, 2018 at 10:29:37PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > .../openSUSE-Leap-15.0-DVD-x86_64.iso.txt | 29 > ++ > .../openSUSE-Leap-15.0-NET-x86_64.iso.txt | 29 > ++ > 2 files changed, 58 insertions(+) > create mode 100644 > tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt > create mode 100644 > tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt > > diff --git > a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt > b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt > new file mode 100644 > index 000..e89a0de > --- /dev/null > +++ > b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-DVD-x86_64.iso.txt > @@ -0,0 +1,29 @@ > +CD-ROM is in ISO 9660 format > +System id: LINUX > +Volume id: openSUSE-Leap-15.0-DVD-x86_64267 > +Volume set id: > +Publisher id: SUSE LINUX GmbH > +Data preparer id: KIWI - http://opensuse.github.com/kiwi > +Application id: openSUSE-Leap-15.0-DVD-x86_64-Build267.2-Media > +Copyright File id: > +Abstract File id: > +Bibliographic File id: > +Volume set size is: 1 > +Volume set sequence number is: 1 > +Logical block size is: 2048 > +Volume size is: 1912564 > +El Torito VD version 1 found, boot catalog is in sector 20 > +Joliet with UCS level 3 found > +Rock Ridge signatures version 1 found > +Eltorito validation header: > +Hid 1 > +Arch 0 (x86) > +ID 'SUSE LINUX GmbH' > +Key 55 AA > +Eltorito defaultboot header: > +Bootid 88 (bootable) > +Boot media 0 (No Emulation Boot) > +Load segment 0 > +Sys type 0 > +Nsect 4 > +Bootoff 145C 5212 > diff --git > a/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt > b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt > new file mode 100644 > index 000..d6e6619 > --- /dev/null > +++ > b/tests/isodata/opensuse/opensuse15.0/openSUSE-Leap-15.0-NET-x86_64.iso.txt > @@ -0,0 +1,29 @@ > +CD-ROM is in ISO 9660 format > +System id: LINUX > +Volume id: openSUSE-Leap-15.0-NET-x86_64267 > +Volume set id: > +Publisher id: SUSE LINUX GmbH > +Data preparer id: KIWI - http://opensuse.github.com/kiwi > +Application id: openSUSE-Leap-15.0-NET-x86_64-Build267.2-Media > +Copyright File id: > +Abstract File id: > +Bibliographic File id: > +Volume set size is: 1 > +Volume set sequence number is: 1 > +Logical block size is: 2048 > +Volume size is: 60205 > +El Torito VD version 1 found, boot catalog is in sector 20 > +Joliet with UCS level 3 found > +Rock Ridge signatures version 1 found > +Eltorito validation header: > +Hid 1 > +Arch 0 (x86) > +ID 'SUSE LINUX GmbH' > +Key 55 AA > +Eltorito defaultboot header: > +Bootid 88 (bootable) > +Boot media 0 (No Emulation Boot) > +Load segment 0 > +Sys type 0 > +Nsect 4 > +Bootoff FC8 4040 > -- > 2.14.3 > > ___ > Libosinfo mailing list > Libosinfo@redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust upgrades/derives-from for leap 15.0
On Sat, May 26, 2018 at 10:29:41PM +0200, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/os/opensuse.org/opensuse-unknown.xml.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in > b/data/os/opensuse.org/opensuse-unknown.xml.in > index 195ea4a..1292372 100644 > --- a/data/os/opensuse.org/opensuse-unknown.xml.in > +++ b/data/os/opensuse.org/opensuse-unknown.xml.in > @@ -8,8 +8,8 @@ > <_vendor>openSUSE > linux > opensuse > -http://opensuse.org/opensuse/42.2"/> > -http://opensuse.org/opensuse/42.2"/> > +http://opensuse.org/opensuse/15.0"/> > +http://opensuse.org/opensuse/15.0"/> Huhu, 15.0 being newer than 42.2 is odd ;) Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse, install-script: Skip second stage
On Sat, May 26, 2018 at 10:29:38PM +0200, Fabiano Fidêncio wrote: > As we don't do anything in the second stage, we can just skip it > entirely without any issues. > > Signed-off-by: Fabiano Fidêncio > --- > data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git > a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in > b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in > index 6554eb6..537c266 100644 > --- a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in > +++ b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in > @@ -144,6 +144,7 @@ > > > false > +false Are these 'config:type' parameters something which is exposed to the library user, right? Or Are they something purley internal? If they are public, what happens in libosinfo if we try to set a non-existent parameter? In other word, should we consider this an API/ABI break, or are we fine with dropping it? Christophe signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db][PATCH] opensuse-unknown: Adjust the volume-id regex
On Sat, May 26, 2018 at 10:29:43PM +0200, Fabiano Fidêncio wrote: > The regex to match unknown openSUSE prereleases is becoming > bigger and harder to read. > > Basically, what it's doing is: > > (15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9]) > - - - > | | || | > v v v| v > 15.1+ 16 20, 30, 50 - 90 v 43.0+ > .0, .1, ..., .9 > > I'm desconsidering both the 13.x series or older and 42.x series as > those are not going to have new releases anymore. "desconsidering"? Dropping? Note that https://en.opensuse.org/openSUSE:Roadmap does not entirely closes the door on another 42.x release "There are currently no plans to release an openSUSE Leap 42.4 aligned with the next service pack of SLE 12", but that's close enough. Are they really going to release 43.x in parallel to/after 15.x? Christophe > > Also, (DVD|NET|Kubic) was introduced as this is the naming chosen for > DVD or NET installation or whether it's a Kubic DVD installation. > > Signed-off-by: Fabiano Fidêncio > --- > data/os/opensuse.org/opensuse-unknown.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/os/opensuse.org/opensuse-unknown.xml.in > b/data/os/opensuse.org/opensuse-unknown.xml.in > index 06ae67a..6a8a3b2 100644 > --- a/data/os/opensuse.org/opensuse-unknown.xml.in > +++ b/data/os/opensuse.org/opensuse-unknown.xml.in > @@ -14,7 +14,7 @@ > > > > - > openSUSE-Leap-([1-9][4-9]\.[0-9]+|13\.[3-9])-DVD-x86_64 > + > openSUSE-Leap-(15\.[1-9]|(1[6-9]|[23]|[5-9])[0-9]\.[0-9]|4[3-9]\.[0-9])-(DVD|NET|Kubic)-x86_64* > LINUX > SUSE LINUX GmbH > > -- > 2.14.3 > > ___ > Libosinfo mailing list > Libosinfo@redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
