Re: [Libosinfo] [osinfo-db PATCH 2/5] Revert "centos7: Remove "upgrades" field"
On Wed, Jan 09, 2019 at 11:42:31AM +0100, Fabiano Fidêncio wrote: > The upgrade feature does *not* inidcate whether the upgrade path is > supported or not. It indicates that this realease is considered a newer > version than the listed versions. 'indicate', 'release' > > This reverts commit 335cd8c70e0edadaaa1b5aefa8f138b5839a9639. > > Signed-off-by: Fabiano Fidêncio > --- > data/os/centos.org/centos-7.0.xml.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/data/os/centos.org/centos-7.0.xml.in > b/data/os/centos.org/centos-7.0.xml.in > index c3f45a2..20422f2 100644 > --- a/data/os/centos.org/centos-7.0.xml.in > +++ b/data/os/centos.org/centos-7.0.xml.in > @@ -8,6 +8,7 @@ > <_vendor>CentOS > linux > centos > +http://centos.org/centos/6.5"/> Shouldn't it be latest centos 6 release though? For the revert, Acked-by: Christophe Fergeau as this can be done in another commit Christophe > http://redhat.com/rhel/7.6"/> > > 2014-07-07 > -- > 2.19.2 > > ___ > Libosinfo mailing list > Libosinfo@redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db-tools PATCH 1/5] README: Update download information
Let's point to https://libosinfo.org/download/ instead of pointing to pagure, as it could change again in the future. Signed-off-by: Fabiano Fidêncio --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index faeae52..411ceb2 100644 --- a/README +++ b/README @@ -9,9 +9,9 @@ developers in managing the database. osinfo-db-tools is Free Software and licenced under GPLv2+. -The latest official releases can be found at: +Information about the latest official releases can be found at: -https://releases.pagure.org/libosinfo +https://libosinfo.org/download/ Dependencies -- 2.19.2 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH 2/5] Revert "centos7: Remove "upgrades" field"
The upgrade feature does *not* inidcate whether the upgrade path is supported or not. It indicates that this realease is considered a newer version than the listed versions. This reverts commit 335cd8c70e0edadaaa1b5aefa8f138b5839a9639. Signed-off-by: Fabiano Fidêncio --- data/os/centos.org/centos-7.0.xml.in | 1 + 1 file changed, 1 insertion(+) diff --git a/data/os/centos.org/centos-7.0.xml.in b/data/os/centos.org/centos-7.0.xml.in index c3f45a2..20422f2 100644 --- a/data/os/centos.org/centos-7.0.xml.in +++ b/data/os/centos.org/centos-7.0.xml.in @@ -8,6 +8,7 @@ <_vendor>CentOS linux centos +http://centos.org/centos/6.5"/> http://redhat.com/rhel/7.6"/> 2014-07-07 -- 2.19.2 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [PATCH 0/5] Fixes for recently merged commits
This series has a few patches adapting/fixing/reverting issues caught by Daniel after the patches being already merged. All of those are trivial enough to be pushed directly. osinfo-db-tools: Fabiano Fidêncio (1): README: Update download information README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) osinfo-db: Fabiano Fidêncio (2): Revert "centos7: Remove "upgrades" field" README: Update download information README | 4 ++-- data/os/centos.org/centos-7.0.xml.in | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) libosinfo: Fabiano Fidêncio (2): README: Update download information loader: improve warning message from loader_check_id() README | 4 ++-- osinfo/osinfo_loader.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.19.2 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH 3/5] README: Update download information
Let's point to https://libosinfo.org/download/ instead of pointing to pagure, as it could change again in the future. Signed-off-by: Fabiano Fidêncio --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index 65804cf..f32c0c9 100644 --- a/README +++ b/README @@ -7,9 +7,9 @@ use with virtualization provisioning tools osinfo-db is Free Software and licenced under GPLv2+. -The latest official releases can be found at: +Information about the latest official releases can be found at: -https://releases.pagure.org/libosinfo/ +https://libosinfo.org/download/ Dependencies -- 2.19.2 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [libosinfo PATCH 5/5] loader: improve warning message from loader_check_id()
"should" needs to be changed to "must" as since commit 00f258a6be
libosinfo refuses to load non-compliant named files.
Signed-off-by: Fabiano Fidêncio
---
osinfo/osinfo_loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
index 372871e..8f7b2bf 100644
--- a/osinfo/osinfo_loader.c
+++ b/osinfo/osinfo_loader.c
@@ -554,7 +554,7 @@ static gboolean osinfo_loader_check_id(const gchar *relpath,
g_free(suffix);
if (!g_str_equal(extension ? reldir : relpath, name)) {
-g_warning("Entity %s should be in file %s not %s",
+g_warning("Entity %s must be in file %s not %s",
id, name, extension ? reldir : relpath);
goto cleanup;
}
--
2.19.2
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [libosinfo PATCH 4/5] README: Update download information
Let's point to https://libosinfo.org/download/ instead of pointing to pagure, as it could change again in the future. Signed-off-by: Fabiano Fidêncio --- README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README b/README index e27990f..e3d528c 100644 --- a/README +++ b/README @@ -11,9 +11,9 @@ common programming languages with demos for javascript (GJS/Seed) and python libosinfo is Free Software and licenced under LGPLv2+. -The latest official releases can be found at: +Information about the latest official releases can be found at: -https://releases.pagure.org/libosinfo/ +https://libosinfo.org/download/ Dependencies -- 2.19.2 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db PATCH] centos7: Remove "upgrades" field
On Wed, 2019-01-09 at 11:00 +0100, Fabiano Fidêncio wrote: > On Wed, 2019-01-09 at 09:54 +, Daniel P. Berrangé wrote: > > On Fri, Jan 04, 2019 at 01:39:50PM +0100, Fabiano Fidêncio wrote: > > > After a conversation with Fabian Arrotin, from CentOS project, > > > I've > > > learned that there's no supported upgrade from CentOS 6 to > > > CentOS7. > > > > > > Knowing that, let's just drop the "upgrades" field from centos7 > > > entry. > > > > The feature was not indicating whether the upgrade path > > is "supported" or not. It is indicating that this release is > > considered a newer version than the listed version. This allows > > applications to order releases, and will apply inheritance of > > settings. > > > > In addition, even if CentOS doesn't consider in-place upgrades > > supported, > > they are still possible. > > > > So I don't think removing this is right. > > Okay, I'll revert this patch. Just one note, inheritance (as it's implemented nowadays) applies in case of cloning/deriving from, not in case up "upgrading". If "upgrading" should be taken into consideration, we'd need to change our code. Best Regards, -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [libosinfo PATCH 1/6] README: Update download link
On Wed, 2019-01-09 at 09:56 +, Daniel P. Berrangé wrote: > On Thu, Jan 03, 2019 at 02:09:06PM +0100, Fabiano Fidêncio wrote: > > Let's point to pagure instead of referring to the already sunset > > fedorahosted. > > > > Signed-off-by: Fabiano Fidêncio > > --- > > README | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/README b/README > > index 1a0fa2e..b7bffb6 100644 > > --- a/README > > +++ b/README > > @@ -13,7 +13,7 @@ libosinfo is Free Software and licenced under > > LGPLv2+. > > > > The latest official releases can be found at: > > > > -https://fedorahosted.org/releases/l/i/libosinfo/ > > +https://releases.pagure.org/libosinfo/ > > We should point to https://libosinfo.org/download/ as pagure.org is > just the current site, which may change again in future. Right, I'll change this and push the patches (as trivial fixes) unless you want to review them. Best Regards, -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db PATCH] centos7: Remove "upgrades" field
On Wed, 2019-01-09 at 09:54 +, Daniel P. Berrangé wrote: > On Fri, Jan 04, 2019 at 01:39:50PM +0100, Fabiano Fidêncio wrote: > > After a conversation with Fabian Arrotin, from CentOS project, I've > > learned that there's no supported upgrade from CentOS 6 to CentOS7. > > > > Knowing that, let's just drop the "upgrades" field from centos7 > > entry. > > The feature was not indicating whether the upgrade path > is "supported" or not. It is indicating that this release is > considered a newer version than the listed version. This allows > applications to order releases, and will apply inheritance of > settings. > > In addition, even if CentOS doesn't consider in-place upgrades > supported, > they are still possible. > > So I don't think removing this is right. Okay, I'll revert this patch. Best Regards, -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [libosinfo PATCH] loader: refuse to load non-compliant named files
On Thu, Jan 03, 2019 at 03:56:27PM +0100, Fabiano Fidêncio wrote:
> There was a period of grace needed for backwards compatibility. After 3+
> years, we can safely remove the code instroduced as part of 09ae3cf09
> (which was released on 0.3.0).
>
> Signed-off-by: Fabiano Fidêncio
> ---
> osinfo/osinfo_loader.c | 15 +++
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
> index 77ca5ea..372871e 100644
> --- a/osinfo/osinfo_loader.c
> +++ b/osinfo/osinfo_loader.c
> @@ -523,6 +523,7 @@ static gboolean osinfo_loader_check_id(const gchar
> *relpath,
> gchar *reldir;
> gboolean extension;
> gsize i;
> +gboolean ret = FALSE;
>
> if (!relpath)
> return TRUE;
> @@ -555,17 +556,15 @@ static gboolean osinfo_loader_check_id(const gchar
> *relpath,
> if (!g_str_equal(extension ? reldir : relpath, name)) {
> g_warning("Entity %s should be in file %s not %s",
>id, name, extension ? reldir : relpath);
This needs to be changed to "must" instead of "should" since this is
now mandatory.
> -g_free(reldir);
> -g_free(name);
> -return TRUE; /* In future switch to FALSE to refuse
> - * to load non-compliant named files.
> - * Need a period of grace for backcompat
> - * first though... Switch ETA Jan 2017
> - */
> +goto cleanup;
> }
> +
> +ret = TRUE;
> +
> + cleanup:
> g_free(reldir);
> g_free(name);
> -return TRUE;
> +return ret;
> }
>
>
> --
> 2.19.2
>
> ___
> Libosinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
Regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [libosinfo PATCH 1/6] README: Update download link
On Thu, Jan 03, 2019 at 02:09:06PM +0100, Fabiano Fidêncio wrote: > Let's point to pagure instead of referring to the already sunset > fedorahosted. > > Signed-off-by: Fabiano Fidêncio > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index 1a0fa2e..b7bffb6 100644 > --- a/README > +++ b/README > @@ -13,7 +13,7 @@ libosinfo is Free Software and licenced under LGPLv2+. > > The latest official releases can be found at: > > -https://fedorahosted.org/releases/l/i/libosinfo/ > +https://releases.pagure.org/libosinfo/ We should point to https://libosinfo.org/download/ as pagure.org is just the current site, which may change again in future. Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db PATCH] centos7: Remove "upgrades" field
On Fri, Jan 04, 2019 at 01:39:50PM +0100, Fabiano Fidêncio wrote: > After a conversation with Fabian Arrotin, from CentOS project, I've > learned that there's no supported upgrade from CentOS 6 to CentOS7. > > Knowing that, let's just drop the "upgrades" field from centos7 entry. The feature was not indicating whether the upgrade path is "supported" or not. It is indicating that this release is considered a newer version than the listed version. This allows applications to order releases, and will apply inheritance of settings. In addition, even if CentOS doesn't consider in-place upgrades supported, they are still possible. So I don't think removing this is right. > > Signed-off-by: Fabiano Fidêncio > --- > data/os/centos.org/centos-7.0.xml.in | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/data/os/centos.org/centos-7.0.xml.in > b/data/os/centos.org/centos-7.0.xml.in > index 20422f2..c3f45a2 100644 > --- a/data/os/centos.org/centos-7.0.xml.in > +++ b/data/os/centos.org/centos-7.0.xml.in > @@ -8,7 +8,6 @@ > <_vendor>CentOS > linux > centos > -http://centos.org/centos/6.5"/> > http://redhat.com/rhel/7.6"/> > > 2014-07-07 > -- > 2.19.2 > > ___ > Libosinfo mailing list > Libosinfo@redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
