Re: [Libosinfo] [libosinfo PATCH] media: Make _supports_installer_sript() aware of media installers
I'd add a call to osinfo_media_supports_installer_script to
test_loaded_installer_script
Apart from this,
Acked-by: Christophe Fergeau
On Thu, Feb 07, 2019 at 08:39:17AM +0100, Fabiano Fidêncio wrote:
> Signed-off-by: Fabiano Fidêncio
> ---
> This has been written atop of
> https://www.redhat.com/archives/libosinfo/2019-February/msg00028.html
> ---
> osinfo/osinfo_media.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/osinfo/osinfo_media.c b/osinfo/osinfo_media.c
> index 6720736..9f77504 100644
> --- a/osinfo/osinfo_media.c
> +++ b/osinfo/osinfo_media.c
> @@ -1661,7 +1661,8 @@ gboolean
> osinfo_media_supports_installer_script(OsinfoMedia *media)
> os = osinfo_media_get_os(media);
> list = osinfo_os_get_install_script_list(os);
>
> -if (osinfo_list_get_length(OSINFO_LIST(list)) == 0) {
> +if (osinfo_list_get_length(OSINFO_LIST(list)) == 0 &&
> +osinfo_list_get_length(OSINFO_LIST(media->priv->scripts)) == 0) {
> ret = FALSE;
> goto cleanup;
> }
> --
> 2.20.1
>
> ___
> Libosinfo mailing list
> Libosinfo@redhat.com
> https://www.redhat.com/mailman/listinfo/libosinfo
signature.asc
Description: PGP signature
___
Libosinfo mailing list
Libosinfo@redhat.com
https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db PATCH 1/3] schema: Add installer to the media
On Wed, Feb 06, 2019 at 04:54:06PM +0100, Fabiano Fidêncio wrote: > Having the instsaller tied to the OS is something that has been shown s/instsaller/installer Apart from this, the series looks good to me, Acked-by: Christophe Fergeau > not optimal, unfortunately. > > An OS may have a few different medias and each media may support a > specific type of script or, even, not support an installer script at > all. With this in mind, let's have the installer scripts tied to the > medias themselves. > > Signed-off-by: Fabiano Fidêncio > --- > data/schema/osinfo.rng.in | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/data/schema/osinfo.rng.in b/data/schema/osinfo.rng.in > index 5e6f5e7..6fc03a1 100644 > --- a/data/schema/osinfo.rng.in > +++ b/data/schema/osinfo.rng.in > @@ -412,6 +412,11 @@ > > > > + > + > + > + > + > > > > -- > 2.20.1 > > ___ > Libosinfo mailing list > Libosinfo@redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo signature.asc Description: PGP signature ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db PATCH v2 02/13] ubuntu: Fix kernel path for 13.04 desktop ISOs
On Mon, Feb 11, 2019 at 11:40 AM Daniel P. Berrangé wrote: > > On Mon, Feb 11, 2019 at 09:43:44AM +0100, Fabiano Fidêncio wrote: > > Signed-off-by: Fabiano Fidêncio > > --- > > data/os/ubuntu.com/ubuntu-13.04.xml.in | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/data/os/ubuntu.com/ubuntu-13.04.xml.in > > b/data/os/ubuntu.com/ubuntu-13.04.xml.in > > index 07fe3ac..8e175d1 100644 > > --- a/data/os/ubuntu.com/ubuntu-13.04.xml.in > > +++ b/data/os/ubuntu.com/ubuntu-13.04.xml.in > > @@ -50,7 +50,7 @@ > > > > Ubuntu 13.04 i386 > > > > - casper/vmlinuz > > + casper/vmlinuz. > > Really ? A trailing "." ? Ops, no, this one is a typo and is on me. :-( Fixed locally already. > > >casper/initrd.lz > > > > > > @@ -58,7 +58,7 @@ > > > > Ubuntu 13.04 amd64 > > > > - casper/vmlinuz > > + casper/vmlinuz.efi > >casper/initrd.lz > > > > > > Regards, > Daniel > -- > |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o-https://fstop138.berrange.com :| > |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| > > ___ > Libosinfo mailing list > Libosinfo@redhat.com > https://www.redhat.com/mailman/listinfo/libosinfo -- Fabiano Fidêncio ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
Re: [Libosinfo] [osinfo-db PATCH v2 02/13] ubuntu: Fix kernel path for 13.04 desktop ISOs
On Mon, Feb 11, 2019 at 09:43:44AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/os/ubuntu.com/ubuntu-13.04.xml.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/data/os/ubuntu.com/ubuntu-13.04.xml.in > b/data/os/ubuntu.com/ubuntu-13.04.xml.in > index 07fe3ac..8e175d1 100644 > --- a/data/os/ubuntu.com/ubuntu-13.04.xml.in > +++ b/data/os/ubuntu.com/ubuntu-13.04.xml.in > @@ -50,7 +50,7 @@ > > Ubuntu 13.04 i386 > > - casper/vmlinuz > + casper/vmlinuz. Really ? A trailing "." ? >casper/initrd.lz > > > @@ -58,7 +58,7 @@ > > Ubuntu 13.04 amd64 > > - casper/vmlinuz > + casper/vmlinuz.efi >casper/initrd.lz > > Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :| ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 13/13] ubuntu: Fix initrd path for 19.04 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-19.04.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-19.04.xml.in b/data/os/ubuntu.com/ubuntu-19.04.xml.in index 73c4c4e..b7fe87c 100644 --- a/data/os/ubuntu.com/ubuntu-19.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-19.04.xml.in @@ -46,7 +46,7 @@ Ubuntu 19.04(.\d)? amd64 casper/vmlinuz - casper/initrd.lz + casper/initrd http://cdimage.ubuntu.com/ubuntu-server/daily/current/disco-server-arm64.iso -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 12/13] ubuntu: Fix initrd path for 18.10 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-18.10.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-18.10.xml.in b/data/os/ubuntu.com/ubuntu-18.10.xml.in index 1086541..da77bba 100644 --- a/data/os/ubuntu.com/ubuntu-18.10.xml.in +++ b/data/os/ubuntu.com/ubuntu-18.10.xml.in @@ -55,7 +55,7 @@ Ubuntu 18.10(.\d)? amd64 casper/vmlinuz - casper/initrd.lz + casper/initrd http://cdimage.ubuntu.com/ubuntu/releases/18.10/release/ubuntu-18.10-server-arm64.iso -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 07/13] ubuntu: Fix kernel path for 15.10 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-15.10.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-15.10.xml.in b/data/os/ubuntu.com/ubuntu-15.10.xml.in index 4ef334b..dea49b3 100644 --- a/data/os/ubuntu.com/ubuntu-15.10.xml.in +++ b/data/os/ubuntu.com/ubuntu-15.10.xml.in @@ -59,7 +59,7 @@ Ubuntu 15.10(.\d)? amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 03/13] ubuntu: Fix kernel path for 13.10 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-13.10.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-13.10.xml.in b/data/os/ubuntu.com/ubuntu-13.10.xml.in index ae03f0b..ee33b79 100644 --- a/data/os/ubuntu.com/ubuntu-13.10.xml.in +++ b/data/os/ubuntu.com/ubuntu-13.10.xml.in @@ -58,7 +58,7 @@ Ubuntu 13.10 amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 09/13] ubuntu: Fix kernel path for 16.10 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-16.10.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-16.10.xml.in b/data/os/ubuntu.com/ubuntu-16.10.xml.in index ea0b64d..1a0e16b 100644 --- a/data/os/ubuntu.com/ubuntu-16.10.xml.in +++ b/data/os/ubuntu.com/ubuntu-16.10.xml.in @@ -59,7 +59,7 @@ Ubuntu 16.10(.\d)? amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 10/13] ubuntu: Fix kernel path for 17.04 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-17.04.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-17.04.xml.in b/data/os/ubuntu.com/ubuntu-17.04.xml.in index 7b7ca59..0b9028f 100644 --- a/data/os/ubuntu.com/ubuntu-17.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-17.04.xml.in @@ -73,7 +73,7 @@ Ubuntu 17.04(.\d)? amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 11/13] ubuntu: Fix kernel path for 17.10 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-17.10.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-17.10.xml.in b/data/os/ubuntu.com/ubuntu-17.10.xml.in index 1aae23f..8532586 100644 --- a/data/os/ubuntu.com/ubuntu-17.10.xml.in +++ b/data/os/ubuntu.com/ubuntu-17.10.xml.in @@ -51,7 +51,7 @@ Ubuntu 17.10(.\d)? amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 06/13] ubuntu: Fix kernel path for 15.04 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-15.04.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-15.04.xml.in b/data/os/ubuntu.com/ubuntu-15.04.xml.in index 35acaf7..c440be2 100644 --- a/data/os/ubuntu.com/ubuntu-15.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-15.04.xml.in @@ -59,7 +59,7 @@ Ubuntu 15.04(.\d)? amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 02/13] ubuntu: Fix kernel path for 13.04 desktop ISOs
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-13.04.xml.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/os/ubuntu.com/ubuntu-13.04.xml.in b/data/os/ubuntu.com/ubuntu-13.04.xml.in index 07fe3ac..8e175d1 100644 --- a/data/os/ubuntu.com/ubuntu-13.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-13.04.xml.in @@ -50,7 +50,7 @@ Ubuntu 13.04 i386 - casper/vmlinuz + casper/vmlinuz. casper/initrd.lz @@ -58,7 +58,7 @@ Ubuntu 13.04 amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 05/13] ubuntu: Fix kernel path for 14.10 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-14.10.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-14.10.xml.in b/data/os/ubuntu.com/ubuntu-14.10.xml.in index 4c71132..e4c2217 100644 --- a/data/os/ubuntu.com/ubuntu-14.10.xml.in +++ b/data/os/ubuntu.com/ubuntu-14.10.xml.in @@ -59,7 +59,7 @@ Ubuntu 14.10(.\d)? amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 08/13] ubuntu: Fix kernel path for 16.04 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-16.04.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-16.04.xml.in b/data/os/ubuntu.com/ubuntu-16.04.xml.in index 3752ac4..ccc0c62 100644 --- a/data/os/ubuntu.com/ubuntu-16.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-16.04.xml.in @@ -59,7 +59,7 @@ Ubuntu 16.04(.\d)? LTS amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 04/13] ubuntu: Fix kernel path for 14.04 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-14.04.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-14.04.xml.in b/data/os/ubuntu.com/ubuntu-14.04.xml.in index 36a3773..ea361e2 100644 --- a/data/os/ubuntu.com/ubuntu-14.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-14.04.xml.in @@ -59,7 +59,7 @@ Ubuntu 14.04(.\d)? LTS amd64 - casper/vmlinuz + casper/vmlinuz.efi casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
[Libosinfo] [osinfo-db PATCH v2 01/13] ubuntu: Fix initrd path for 11.04 desktop ISO
Signed-off-by: Fabiano Fidêncio --- data/os/ubuntu.com/ubuntu-11.04.xml.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/os/ubuntu.com/ubuntu-11.04.xml.in b/data/os/ubuntu.com/ubuntu-11.04.xml.in index c0640fc..c9985be 100644 --- a/data/os/ubuntu.com/ubuntu-11.04.xml.in +++ b/data/os/ubuntu.com/ubuntu-11.04.xml.in @@ -65,7 +65,7 @@ LINUX casper/vmlinuz - casper/initrd.img + casper/initrd.lz -- 2.20.1 ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listinfo/libosinfo
