On Tue, Jun 18, 2019 at 9:24 PM Cole Robinson wrote:
>
> On 6/18/19 1:10 PM, Fabiano Fidêncio wrote:
> > On Mon, Jun 17, 2019 at 11:32 PM Cole Robinson wrote:
> >>
> >> On 6/13/19 7:48 AM, Fabiano Fidêncio wrote:
> >>> Let's add the avatar disk template, which considers that the avatar file
>
On 6/18/19 3:06 PM, Fabiano Fidêncio wrote:
> This patch series, together with some small bug fixes/clean-ups, tries
> to improve target, script, and avatar disks in a way that apps do not
> actually have to set them up.
>
> The changes do not break the current state as, if set, those disks are
>
On 6/18/19 1:10 PM, Fabiano Fidêncio wrote:
> On Mon, Jun 17, 2019 at 11:32 PM Cole Robinson wrote:
>>
>> On 6/13/19 7:48 AM, Fabiano Fidêncio wrote:
>>> Let's add the avatar disk template, which considers that the avatar file
>>> is stored together with the install scripts files, so we don't
This patch series, together with some small bug fixes/clean-ups, tries
to improve target, script, and avatar disks in a way that apps do not
actually have to set them up.
The changes do not break the current state as, if set, those disks are
going to be used.
With those changes, a lot of logic
Splitting centos & rhel script, done in 538ca137c, was not exactly the
best idea as it increased the maintenance for pretty much no gain.
With that in mind, let's merge back the scripts keeping the centos
specific bits conditionally added as part of the templates.
Signed-off-by: Fabiano Fidêncio
Let's add a target-disk template so we actually can use what apps set as
target-disk, instead of using a hardcoded path to /dev/vda.
With this change we keep not requiring the apps to set this value.
Signed-off-by: Fabiano Fidêncio
---
.../opensuse-autoyast-desktop.xml.in | 21
repo-oss template has been generating an empy extra space before the URL
it returns, which may break unattended installations.
Signed-off-by: Fabiano Fidêncio
---
.../install-script/opensuse.org/opensuse-autoyast-desktop.xml.in | 1 -
Although we only support unattended installations for Red Hat Enterprise
Linux 6 (or newer), let's fix the condition for using virtio as the
target disk.
Unlike suggested in the previous condition, virtio-block has only been
added to Red Hat Enterprise Linux 5.6 (and not 5.0).
Signed-off-by:
Although we only support unattended installations for CentOS 6 (or
newer), let's fix the condition for using virtio as the target disk.
Unlike suggested in the previous condition, virtio-block has only been
added to CentOS 5.6 (and not 5.0).
Signed-off-by: Fabiano Fidêncio
---
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../centos.org/centos-kickstart-desktop.xml.in | 14 --
.../centos.org/centos-kickstart-jeos.xml.in|
Let's add the script disk template so we don't actually require the apps
to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../silverblue-kickstart-desktop.xml.in | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff
Let's add a target-disk template so we actually can use what apps set
as target-disk, instead of using a hardcoded path to /dev/vda.
With this change we keep not requiring the apps to set this value.
Signed-off-by: Fabiano Fidêncio
---
.../silverblue-kickstart-desktop.xml.in | 15
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../redhat.com/rhel-kickstart-desktop.xml.in | 14 --
.../redhat.com/rhel-kickstart-jeos.xml.in |
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
autopart usage has been introduced in commit 81beb9970 and, since then,
there's no need keep the rootfs and bootfs templates.
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in | 22 ---
1 file changed, 22 deletions(-)
diff --git
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
Let's improve the script disk template so we don't actually require the
apps to set it (but, if they do, the value set will be used).
Signed-off-by: Fabiano Fidêncio
---
.../fedora-kickstart-desktop.xml.in | 17 +++--
.../fedora-kickstart-jeos.xml.in| 17
Let's use virtio as target-disk in case a target-disk is not set by the
apps. We can safely do this as we support unattended installation for
Ubuntu since its 12.04 release and virtio support has been added on 9.04.
Signed-off-by: Fabiano Fidêncio
---
Let's add the avatar disk template, which considers that the avatar file
is stored together with the install scripts files, so we don't actually
require the apps to set it (but, if they do, the value set will be
used).
Signed-off-by: Fabiano Fidêncio
---
20 matches
Mail list logo
