Suggestion to close this list

2020-07-16 Thread Daniel P . Berrangé
This list does not have a significant amount of traffic on it since we switched to using merge requests. - A handful of patches mistakenly sent to the list instead of merge request - A couple of release announcements - A couple of design discussions GitLab has the ability to attach release

Re: State "bios" firmware support for OSes

2020-05-26 Thread Daniel P . Berrangé
On Tue, May 26, 2020 at 04:05:05PM +0200, Felipe Borges wrote: > Hi everyone, > > We recently landed EFI support in GNOME Boxes where we create guests > with "firmware = efi" by default when libosinfo reports that the OS > supports it. This has worked great except for the regression with >

Re: Using gitlab labels for issues and MRs

2020-05-18 Thread Daniel P . Berrangé
On Mon, May 18, 2020 at 09:08:35AM +0200, Pino Toscano wrote: > On Thursday, 14 May 2020 17:49:55 CEST Daniel P. Berrangé wrote: > > For libvirt I figured it was useful to distinguish different types of > > request too > > > > - bug - undesirable behaviour > >

Re: Using gitlab labels for issues and MRs

2020-05-14 Thread Daniel P . Berrangé
On Thu, May 14, 2020 at 05:28:29PM +0200, Pino Toscano wrote: > Hi, > > now that we've been using gitlab as primary source for issues and merge > requests, maybe we can start using labels to categorize them. > I never used them myself, so personally it would be a small thing to > learn;

Re: [PATCH] NetBSD 9.0 data

2020-04-06 Thread Daniel P . Berrangé
Hi Vicente, Thanks for your patch below. We have switched over to using GitLab merge requests for patch submissions and review. Would you mind re-submitting your patch there: https://gitlab.com/libosinfo/osinfo-db/-/merge_requests On Fri, Apr 03, 2020 at 09:45:01PM -0300, Vicente Chaves de

Re: [Libosinfo] [PATCH] force a UTF-8 locale for python3 to avoid broken ascii codec

2019-09-06 Thread Daniel P . Berrangé
On Thu, Sep 05, 2019 at 07:40:54PM +0200, Andrea Bolognani wrote: > On Thu, 2019-09-05 at 18:19 +0100, Daniel P. Berrangé wrote: > > On Thu, Sep 05, 2019 at 07:08:27PM +0200, Fabiano Fidêncio wrote: > > > It seems to happen because both debian & fedora (30+) contai

Re: [Libosinfo] [PATCH] force a UTF-8 locale for python3 to avoid broken ascii codec

2019-09-05 Thread Daniel P . Berrangé
On Thu, Sep 05, 2019 at 07:08:27PM +0200, Fabiano Fidêncio wrote: > On Wed, Mar 27, 2019 at 10:57 AM Daniel P. Berrangé > wrote: > > > > The python3 ascii codec violates POSIX C locale requirements by not being > > 8-bit clean in its text handling. It raises an error f

Re: [Libosinfo] [libosinfo PATCH v2 0/3] CI breakage fixes

2019-07-17 Thread Daniel P . Berrangé
On Wed, Jul 17, 2019 at 02:24:47PM +0200, Fabiano Fidêncio wrote: > Those patches (partially) the breakage caused on virt-manager's tests > caught by libvirt-jenkins-ci. Wonder if there's anything we can add to libosinfo tests tat would catchthis sooner > > There's still an issue happening,

Re: [Libosinfo] [libosinfo PATCH v2 3/3] tree: cleanup on any error & return on _create_from_location_async_helper()

2019-07-17 Thread Daniel P . Berrangé
r_returned' failed. > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_tree.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt

Re: [Libosinfo] [libosinfo PATCH v2 2/3] tree: goto cleanup on any error, on on_content_read()

2019-07-17 Thread Daniel P . Berrangé
_task_return_error: assertion 'task->ever_returned' failed. > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-htt

Re: [Libosinfo] [libosinfo PATCH v2 2/2] tools, install-script: Deprecate --config

2019-07-10 Thread Daniel P . Berrangé
changed, 7 insertions(+) Reviewed-by: Daniel P. Berrangé > > diff --git a/tools/osinfo-install-script.c b/tools/osinfo-install-script.c > index a525645..f756ba3 100644 > --- a/tools/osinfo-install-script.c > +++ b/tools/osinfo-install-script.c > @@ -85,6 +85,12 @@ st

Re: [Libosinfo] [libosinfo PATCH v2 1/2] tools, install-script: Add --config-file (-f) option

2019-07-10 Thread Daniel P . Berrangé
all-script.c | 103 +- > 1 file changed, 102 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :

Re: [Libosinfo] [libosinfo PATCH 2/2] tools, install-script: Do not accept user & admin password via --config

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 10:27:20AM +0200, Fabiano Fidêncio wrote: > As passing user & admin password via command line is a low impact CVE, > let's error out when it's done and advertise the users to use > --config-file instead. > > Signed-off-by: Fabiano Fidêncio > --- >

Re: [Libosinfo] [libosinfo PATCH 1/2] tools, install-script: Add --config-file (-f) option

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 10:27:19AM +0200, Fabiano Fidêncio wrote: > Let's add a new option so users can set their config from a file, > instead of directly passing the values via command-line. > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c | 100

Re: [Libosinfo] [libosinfo PATCH 0/7] Drop GVFS dependency in favour of libsoup

2019-07-02 Thread Daniel P . Berrangé
On Mon, Jul 01, 2019 at 07:51:52PM -0400, Cole Robinson wrote: > On 6/27/19 8:56 AM, Fabiano Fidêncio wrote: > > Let's rely on libsoup in order to to http://, https://, and ftp:// > > requests. > > > > By doing this, GVFS (more specifically, gvfs-http) won't be dragged as > > a dependency, which

Re: [Libosinfo] [osinfo-db-tools PATCH 2/8] Add support to meson build system

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 07:18:58PM +0200, Fabiano Fidêncio wrote: > On Thu, Jun 20, 2019 at 7:01 PM Daniel P. Berrangé > wrote: > > > > On Thu, Jun 20, 2019 at 05:21:21PM +0200, Fabiano Fidêncio wrote: > > > diff --git a/meson.build b/meson.build > > > new

Re: [Libosinfo] [osinfo-db-tools PATCH 2/8] Add support to meson build system

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 07:10:54PM +0200, Fabiano Fidêncio wrote: > On Thu, Jun 20, 2019 at 7:05 PM Daniel P. Berrangé > wrote: > > > > On Thu, Jun 20, 2019 at 06:42:29PM +0200, Pavel Hrdina wrote: > > > Few more notes that I've noticed: > > > > > &g

Re: [Libosinfo] [osinfo-db-tools PATCH 1/8] tools: Don't import config.h

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 07:03:44PM +0200, Fabiano Fidêncio wrote: > On Thu, Jun 20, 2019 at 6:51 PM Daniel P. Berrangé > wrote: > > > > On Thu, Jun 20, 2019 at 05:21:20PM +0200, Fabiano Fidêncio wrote: > > > As config.h is not used, at all, in osinfo-db-tools, let's

Re: [Libosinfo] [osinfo-db-tools PATCH 7/8] meson: Add ninja syntax-check

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 05:21:26PM +0200, Fabiano Fidêncio wrote: > Let's take advantage of that we can run `make syntax-check` without the > need of having a Makefile around and add a `ninja syntax-check` target > that ends up calling `make syntax-check`. It feels a little odd to be doing this

Re: [Libosinfo] [osinfo-db-tools PATCH 6/8] Support `make syntax-check` without Makefile

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 05:21:25PM +0200, Fabiano Fidêncio wrote: > A few dirty hacks have been done in GNUmakefile, cfg.mk, and maint.mk in > order to support running `make syntax-check` without having to have a > Makefile around. > > GNUmakefile: set srcdir & top_srcdir and remove the parts

Re: [Libosinfo] [osinfo-db-tools PATCH 5/8] Drop autotools support

2019-06-20 Thread Daniel P . Berrangé
lete mode 100644 m4/libosinfo-compile-warnings.m4 > delete mode 100644 m4/manywarnings.m4 > delete mode 100644 m4/warnings.m4 > delete mode 100644 po/Makevars > delete mode 100644 tests/Makefile.am > delete mode 100644 tools/Makefile.am Reviewed-by: Daniel P. Berrangé R

Re: [Libosinfo] [osinfo-db-tools PATCH 4/8] prepare-release: Adapt to use meson

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 05:21:23PM +0200, Fabiano Fidêncio wrote: > Let's adapt the prepare-release script to use meson build system instead > of autotools. > > This change has been tested and is working fine on Fedora 30+. > > Signed-off-by: Fabiano Fidêncio > --- > prepare-release.sh | 83

Re: [Libosinfo] [osinfo-db-tools PATCH 3/8] spec: Adapt to use meson

2019-06-20 Thread Daniel P . Berrangé
gt; osinfo-db-tools.spec.in | 17 ++--- > 2 files changed, 13 insertions(+), 18 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fs

Re: [Libosinfo] [osinfo-db-tools PATCH 2/8] Add support to meson build system

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 06:42:29PM +0200, Pavel Hrdina wrote: > Few more notes that I've noticed: > > - There is a regression, with meson we no longer have generated RPM > spec files in tarball. Yep, that's desirable so users can do "rpmbuild -ta TARBALL", though note only the native

Re: [Libosinfo] [osinfo-db-tools PATCH 2/8] Add support to meson build system

2019-06-20 Thread Daniel P . Berrangé
On Thu, Jun 20, 2019 at 05:21:21PM +0200, Fabiano Fidêncio wrote: > Meson build system is a way simpler and easier to understand build > system that can provide (with some work-arounds here and there) the same > functionalities currently available with our current build system > (autotools). > >

Re: [Libosinfo] [osinfo-db-tools PATCH 1/8] tools: Don't import config.h

2019-06-20 Thread Daniel P . Berrangé
ate.c | 2 -- > 7 files changed, 3 insertions(+), 12 deletions(-) Reviewed-by: Daniel P. Berrangé if you improve the commit message Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop1

Re: [Libosinfo] Handling `http://` calls with sudo/su

2019-05-22 Thread Daniel P . Berrangé
On Wed, May 22, 2019 at 11:00:04AM +0200, Fabiano Fidêncio wrote: > People, > > https://gitlab.com/libosinfo/libosinfo/issues/30 brought up an > interesting fact that I wasn't aware of and may have some negative > impact on libosinfo consumers. > > Basically, GVfs requires access to the session

Re: [Libosinfo] how to submit patch

2019-05-08 Thread Daniel P . Berrangé
On Wed, May 08, 2019 at 06:31:08PM +0800, Liwei Ge wrote: > Hi, All > > I want to submit a patch to add some os xml files. > > If there a standard format or template to follow for reviewing ? > > Or just need attach the patch file ? Either send patches to this mailing list, or send a pull

Re: [Libosinfo] Libosinfo tools, could you help me to have a better understanding of those?

2019-05-03 Thread Daniel P . Berrangé
On Fri, May 03, 2019 at 04:24:44PM +0200, Fabiano Fidêncio wrote: > People, > > As part of libosinfo, we have a few tools: osinfo-detect, osinfo- > install-script, and osinfo-query. > > About osinfo-detect, it seems clear that the intetion of the tools is > to detect whether we're able to

Re: [Libosinfo] [osinfo-db PATCH v2 5/8] debian: Update s for all releases

2019-04-18 Thread Daniel P . Berrangé
xml.in | 2 +- > data/os/debian.org/debian-4.xml.in | 2 +- > data/os/debian.org/debian-5.xml.in | 2 +- > data/os/debian.org/debian-6.xml.in | 2 +- > data/os/debian.org/debian-7.xml.in | 2 +- > data/os/debian.org/debian-8.xml.in | 2 +- > data/os/debian.org/debian-9.x

Re: [Libosinfo] [osinfo-db PATCH v2 4/8] debian: Fix for Debian testing

2019-04-18 Thread Daniel P . Berrangé
ttps://www.debian.org/devel/testing > > Signed-off-by: Andrea Bolognani > --- > data/os/debian.org/debian-testing.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.fli

Re: [Libosinfo] [osinfo-db PATCH v2 3/8] debian: Add s for all releases

2019-04-18 Thread Daniel P . Berrangé
| 1 + > data/os/debian.org/debian-5.xml.in | 1 + > data/os/debian.org/debian-6.xml.in | 1 + > data/os/debian.org/debian-7.xml.in | 1 + > data/os/debian.org/debian-8.xml.in | 1 + > data/os/debian.org/debian-9.xml.in | 1 + > 14 files changed, 14 insertio

Re: [Libosinfo] [osinfo-db PATCH v2 8/8] debian: Update s for several releases

2019-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2019 at 10:02:19AM +0200, Andrea Bolognani wrote: > To match the version number. > > Signed-off-by: Andrea Bolognani > --- > I'm pretty sure this is a backwards-incompatible change and thus not > suitable for merging, but I'm not familiar enough with libosinfo to > be able to say

Re: [Libosinfo] [osinfo-db PATCH 2/7] ubuntu: Include in

2019-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2019 at 07:23:40PM +0200, Andrea Bolognani wrote: > On Wed, 2019-04-17 at 17:58 +0100, Daniel P. Berrangé wrote: > > On Wed, Apr 17, 2019 at 06:38:55PM +0200, Andrea Bolognani wrote: > > > Actually, the above is not quite correct: even if an application >

Re: [Libosinfo] [osinfo-db PATCH 2/7] ubuntu: Include in

2019-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2019 at 04:45:21PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 17, 2019 at 05:24:28PM +0200, Andrea Bolognani wrote: > > Ubuntu releases are often referred to by their codename, so > > it makes sense to include it when displaying information to > > the

Re: [Libosinfo] [osinfo-db PATCH 2/7] ubuntu: Include in

2019-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2019 at 05:24:28PM +0200, Andrea Bolognani wrote: > Ubuntu releases are often referred to by their codename, so > it makes sense to include it when displaying information to > the user. IME people talking about Ubuntu rarely mention the second word in the codename, so I think we

Re: [Libosinfo] [osinfo-db PATCH 4/7] debian: Add s for all releases

2019-04-17 Thread Daniel P . Berrangé
| 1 + > data/os/debian.org/debian-5.xml.in | 1 + > data/os/debian.org/debian-6.xml.in | 1 + > data/os/debian.org/debian-7.xml.in | 1 + > data/os/debian.org/debian-8.xml.in | 1 + > data/os/debian.org/debian-9.xml.in | 1 + > 14 files changed, 14 insertio

Re: [Libosinfo] [osinfo-db PATCH 6/7] macosx: Add s for all releases

2019-04-17 Thread Daniel P . Berrangé
apple.com/macosx-10.2.xml.in | 1 + > data/os/apple.com/macosx-10.3.xml.in | 1 + > data/os/apple.com/macosx-10.4.xml.in | 1 + > data/os/apple.com/macosx-10.5.xml.in | 1 + > data/os/apple.com/macosx-10.6.xml.in | 1 + > data/os/apple.com/macosx-10.7.xml.in | 1 + > 8 files changed,

Re: [Libosinfo] [osinfo-db PATCH 1/7] ubuntu19.04: Fix

2019-04-17 Thread Daniel P . Berrangé
ndrea Bolognani > --- > data/os/ubuntu.com/ubuntu-19.04.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) With commit messge fixes Reviewed-by: Daniel P. Berrangé > > diff --git a/data/os/ubuntu.com/ubuntu-19.04.xml.in > b/data/os/ubuntu.com/ubuntu-19.04.xml.i

[Libosinfo] [PATCH] configure: fix non-portable shell test syntax

2019-04-16 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for "make syntax-check" configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 1f29468..f3139f2 100644 --- a/configure.ac +++ b/configure.ac @@ -32,7 +32

Re: [Libosinfo] [libosinfo PATCH 0/3] Make osinfo-detect aware of trees' os variants

2019-04-12 Thread Daniel P . Berrangé
t the os to the detected tree > media,image,tree: Avoid critical errors when getting the os variants > osinfo-detect: Be aware of tree's os variants Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: htt

Re: [Libosinfo] [libosinfo PATCH 3/3] osinfo-detect: Be aware of tree's os variants

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 10:19:54AM +0200, Fabiano Fidêncio wrote: > In the same way done for medias, make the tree detection aware of > os-variants. > > https://gitlab.com/libosinfo/libosinfo/issues/25 > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-detect.c | 30

Re: [Libosinfo] [libosinfo PATCH 1/3] db: Set the os to the detected tree

2019-04-12 Thread Daniel P . Berrangé
On Fri, Apr 12, 2019 at 10:19:52AM +0200, Fabiano Fidêncio wrote: > When detecting a tree, let's also its OS. word missing ? > > https://gitlab.com/libosinfo/libosinfo/issues/25 > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_db.c | 4 +++- >

Re: [Libosinfo] [osinfo-db PATCH] test: conftest: Set LC_ALL

2019-03-29 Thread Daniel P . Berrangé
) > > locale.setlocale(locale.LC_CTYPE, 'en_US.UTF-8') > > > > # Default to --log-level=info if not otherwise specified > > > > Yeah that's what I came up with too. But I don't understand all the > issues at play so I'll let Dan give the review, CCd Reviewed-b

Re: [Libosinfo] [PATCH osinfo-db 3/3] tests: conftest: set locale in test code

2019-03-29 Thread Daniel P . Berrangé
On Fri, Mar 29, 2019 at 11:48:50AM -0400, Cole Robinson wrote: > On 3/29/19 5:52 AM, Daniel P. Berrangé wrote: > > On Thu, Mar 28, 2019 at 04:55:34PM -0400, Cole Robinson wrote: > >> This fixes the locale setup with direct pytest-3 invocations > >> > &

Re: [Libosinfo] [PATCH osinfo-db 3/3] tests: conftest: set locale in test code

2019-03-29 Thread Daniel P . Berrangé
On Thu, Mar 28, 2019 at 04:55:34PM -0400, Cole Robinson wrote: > This fixes the locale setup with direct pytest-3 invocations > > Signed-off-by: Cole Robinson > --- > Makefile | 2 +- > tests/conftest.py | 4 > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [Libosinfo] [PATCH osinfo-db 3/3] tests: conftest: set locale in test code

2019-03-29 Thread Daniel P . Berrangé
On Thu, Mar 28, 2019 at 04:55:34PM -0400, Cole Robinson wrote: > This fixes the locale setup with direct pytest-3 invocations > > Signed-off-by: Cole Robinson > --- > Makefile | 2 +- > tests/conftest.py | 4 > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [Libosinfo] [libosinfo PATCH 4/8] db: Deal with "unknown" tree architectures

2019-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2019 at 12:24:26PM +0100, Fabiano Fidêncio wrote: > https://gitlab.com/libosinfo/libosinfo/issues/20 Commit messages should be self-contained, fully describing why that are doing what they're doing & why. It is fine to include a bug URL, but the commit message should expect that

[Libosinfo] [PATCH] force a UTF-8 locale for python3 to avoid broken ascii codec

2019-03-27 Thread Daniel P . Berrangé
ned-off-by: Daniel P. Berrangé --- Pushed as a CI build fix for FreeBSD distros Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c63cb6e..9d7f109 100644 --- a/Makefile +++ b/Makefile @@ -123,4 +123,4 @@ update-po: done ch

Re: [Libosinfo] [osinfo-db-tools PATCH] Add a git-publish configuration file

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 06:15:06PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitpublish Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [Libosinfo] [osinfo-db PATCH] Add a git-publish configuration file

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 06:13:12PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitpublish Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [Libosinfo] [libosinfo PATCH] Add a git-publish configuration file

2019-03-26 Thread Daniel P . Berrangé
On Tue, Mar 26, 2019 at 06:11:45PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > .gitpublish | 4 > 1 file changed, 4 insertions(+) > create mode 100644 .gitpublish Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

[Libosinfo] [osinfo-db PATCH] Only use pytest --log-level arg if it is supported

2019-03-26 Thread Daniel P . Berrangé
Older versions of pytest don't have the --log-level arg Signed-off-by: Daniel P. Berrangé --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 254b7af..c63cb6e 100644 --- a/Makefile +++ b/Makefile @@ -34,6 +34,8 @@ ZANATA = zanata

Re: [Libosinfo] osinfo_entity param vs gobject property

2019-03-11 Thread Daniel P . Berrangé
On Fri, Mar 08, 2019 at 01:43:45PM -0500, Cole Robinson wrote: > I'm a bit confused about the suggested way to extend bits of the > libosinfo API. Here's my current understanding: > > We have osinfo_entity*param* functions. This is used internally to store > basically all XML string field data.

Re: [Libosinfo] [PATCH libosinfo 2/2] Remove emacs 'Local variables' annotations

2019-03-07 Thread Daniel P . Berrangé
On Wed, Mar 06, 2019 at 03:30:41PM -0500, Cole Robinson wrote: > On 3/4/19 5:08 AM, Daniel P. Berrangé wrote: > > On Sat, Mar 02, 2019 at 06:35:18PM -0500, Cole Robinson wrote: > >> No other virt projects have annotations like this, plus IMO > >> .editorconfig handl

Re: [Libosinfo] [PATCH libosinfo 2/2] Remove emacs 'Local variables' annotations

2019-03-04 Thread Daniel P . Berrangé
On Sat, Mar 02, 2019 at 06:35:18PM -0500, Cole Robinson wrote: > No other virt projects have annotations like this, plus IMO > .editorconfig handles this in a much nicer way and more flexible > way. Ditch them .editorconfig requires users to install extra packages to work. If we want to remove

Re: [Libosinfo] [libosinfo PATCH] tests: Add identify_media() tests

2019-03-01 Thread Daniel P . Berrangé
> create mode 100644 tests/dbdata/os/libosinfo.org/test-db-media.xml Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://

Re: [Libosinfo] [libosinfo PATCH] syms: Add "global" to 1.4.0 symbols

2019-03-01 Thread Daniel P . Berrangé
On Fri, Mar 01, 2019 at 10:37:42AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > osinfo/libosinfo.syms | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flick

Re: [Libosinfo] [osinfo-db PATCH 0/3] Fixes for Windows JeOS installations

2019-02-18 Thread Daniel P . Berrangé
xt > windows,unattend: Fix group name > > .../microsoft.com/windows-unattend-jeos.xml.in| 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) If whitespace in the first patch is fixed Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [Libosinfo] [osinfo-db PATCH v2 02/13] ubuntu: Fix kernel path for 13.04 desktop ISOs

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 09:43:44AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/os/ubuntu.com/ubuntu-13.04.xml.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/data/os/ubuntu.com/ubuntu-13.04.xml.in >

Re: [Libosinfo] [osinfo-db PATCH 2/3] windows, unattend: Set password as plain text

2019-02-06 Thread Daniel P . Berrangé
On Wed, Feb 06, 2019 at 12:40:32PM +0100, Fabiano Fidêncio wrote: > On Wed, Feb 6, 2019 at 10:13 AM Daniel P. Berrangé > wrote: > > > > On Tue, Feb 05, 2019 at 08:40:35PM +0100, Fabiano Fidêncio wrote: > > > Signed-off-by: Fabiano Fidêncio > > > --- >

Re: [Libosinfo] [osinfo-db PATCH 2/3] windows, unattend: Set password as plain text

2019-02-06 Thread Daniel P . Berrangé
On Tue, Feb 05, 2019 at 08:40:35PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/install-script/microsoft.com/windows-unattend-jeos.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Libosinfo] [libosinfo PATCH 2/2] tests: abort() in case curl misbehaves

2019-02-04 Thread Daniel P . Berrangé
--- > tests/test-imageuris.c | 9 + > tests/test-mediauris.c | 9 + > tests/test-treeuris.c | 9 + > 3 files changed, 27 insertions(+) Reviewed-by: Daniel P. Berrangé There's probably a case to be made for merging these three tests into one test file as they dup

Re: [Libosinfo] [libosinfo PATCH 1/2] tests: Avoid re-using the curl handler on URIs tests

2019-02-04 Thread Daniel P . Berrangé
s/test-treeuris.c | 38 ++ > 3 files changed, 54 insertions(+), 58 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-ht

[Libosinfo] [PATCH] tests: add one test case per OS tested

2019-02-04 Thread Daniel P . Berrangé
ress information. An added benefit is that it is possible to now run tests for individual OS by passing the -p argument. Signed-off-by: Daniel P. Berrangé --- tests/test-imageuris.c | 62 ++--- tests/test-mediauris.c | 63 +++--- tests/

Re: [Libosinfo] [libosinfo PATCH 11/11] test-os: Add basic test for resources

2019-01-24 Thread Daniel P . Berrangé
+ > 1 file changed, 53 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [Libosinfo] [libosinfo PATCH] tools: Remove a reference to fedorahosted.org

2019-01-24 Thread Daniel P . Berrangé
by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [Libosinfo] [libosinfo PATCH 10/11] os: Make get_resources_*_without_inheritance() static

2019-01-24 Thread Daniel P . Berrangé
nfo_os_private.h | 41 - > 3 files changed, 4 insertions(+), 47 deletions(-) > delete mode 100644 osinfo/osinfo_os_private.h Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: htt

Re: [Libosinfo] [libosinfo PATCH 09/11] loader: Deal with network-install resources

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:18PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_loader.c | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [Libosinfo] [libosinfo PATCH 08/11] os: Deal with network-install resources

2019-01-24 Thread Daniel P . Berrangé
ibosinfo.syms | 2 ++ > osinfo/osinfo_os.c | 60 > ++ > osinfo/osinfo_os.h | 2 ++ > osinfo/osinfo_os_private.h | 1 + > 4 files changed, 65 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, D

Re: [Libosinfo] [libosinfo PATCH 07/11] test-os: Fix typo in resources tests

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:16PM +0100, Fabiano Fidêncio wrote: > osinfo_os_get_recommended_resources -> osinfo_os_get_maximum_resources > > Signed-off-by: Fabiano Fidêncio > --- > tests/test-os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-b

Re: [Libosinfo] [libosinfo PATCH 06/11] loader: Fix typo when loading maximum resources

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:15PM +0100, Fabiano Fidêncio wrote: > osinfo_os_add_recommended_resources -> osinfo_os_add_maximum_resources > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-b

Re: [Libosinfo] [libosinfo PATCH 05/11] os: Make get_maximum_resources() aware of inheritance

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:14PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_os.c | 21 +++-- > osinfo/osinfo_os_private.h | 1 + > 2 files changed, 20 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berr

Re: [Libosinfo] [libosinfo PATCH 04/11] os: Group get_*_resources() together

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:13PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_os.c | 65 > +++--- > 1 file changed, 32 insertions(+), 33 deletions(-) Reviewed-by: Daniel P. Berrangé

Re: [Libosinfo] [libosinfo PATCH 03/11] os: Remove extra line from _get_recommended_resources()

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:12PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_os.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/phot

Re: [Libosinfo] [libosinfo PATCH 02/11] os: Fix typos in resources methods

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:11PM +0100, Fabiano Fidêncio wrote: > methos -> method > *private! -> *private*! > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_os.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé R

Re: [Libosinfo] [osinfo-db PATCH 01/11] schema: Add network-install resources

2019-01-24 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 08:28:10PM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > data/schema/osinfo.rng.in | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://ww

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 04:52:59PM +0100, Martin Sivak wrote: > > IOW there should not be any distinction between the way we deal > > with a general purpose profile for a guest OS, from the way we > > deal with an SAP or Oracle optimized profile for a guest OS. I > > would consider it a big

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 03:54:17PM +0100, Martin Sivak wrote: > > So we can > > have some profiles that are generic best practice for the guest + > > hypervisor combination. > > I probably still do not understand where is the line between osinfo a > profiles then. What you are talking about

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 03:16:26PM +0100, Martin Sivak wrote: > > My view on what profiles are for differs from this. In particular > > I do *not* consider the profiles to be application specific. > > Oh, I think we are talking about different applications. > > I agree all management products

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 03:19:26PM +0100, Martin Sivak wrote: > Hi, > > > I consider profiles to be a way of expressing the best practice > > recommendations for configuring a virtual machine to satisfy some > > declared scenario. > > I agree here. > > > This covers data that is specific to a

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 02:56:44PM +0100, Martin Sivak wrote: > > - Revisit Features/Timers after having a clear idea about the Profiles > > work started by Martin Kletzander. > > > > Does that sound like a deal? > > Except the workload profiles are trying to solve a different thing > there

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Tue, Jan 22, 2019 at 12:23:54PM +0100, Fabiano Fidêncio wrote: > On Tue, Jan 22, 2019 at 12:14 PM Daniel P. Berrangé > wrote: > > > > On Mon, Jan 21, 2019 at 03:22:06PM +0100, Fabiano Fidêncio wrote: > > > People, > > > > > > I'd like to start a d

Re: [Libosinfo] RFC: Add clock/timers info in osinfo-db

2019-01-22 Thread Daniel P . Berrangé
On Mon, Jan 21, 2019 at 03:22:06PM +0100, Fabiano Fidêncio wrote: > People, > > I'd like to start a discussion here as this topic is not as simple as > it looks like. > > My first idea would be to have something like: > > > tickpolicy="catchup|delay|discard|merge"

Re: [Libosinfo] [libosinfo PATCH v2 00/12] Add support for Guest Features

2019-01-16 Thread Daniel P . Berrangé
On Fri, Jan 11, 2019 at 03:48:19PM +0100, Fabiano Fidêncio wrote: > Add basic support for Guest Features such as: > - acpi If the guest supports PCI, then it supports ACPI too. If the guest does not support ACPI there is no harm in exposing ACPI anyway, as the guest will just ignore it. If this

Re: [Libosinfo] [libosinfo PATCH] loader: refuse to load non-compliant named files

2019-01-09 Thread Daniel P . Berrangé
On Thu, Jan 03, 2019 at 03:56:27PM +0100, Fabiano Fidêncio wrote: > There was a period of grace needed for backwards compatibility. After 3+ > years, we can safely remove the code instroduced as part of 09ae3cf09 > (which was released on 0.3.0). > > Signed-off-by: Fabiano Fidêncio > --- >

Re: [Libosinfo] [libosinfo PATCH 1/6] README: Update download link

2019-01-09 Thread Daniel P . Berrangé
On Thu, Jan 03, 2019 at 02:09:06PM +0100, Fabiano Fidêncio wrote: > Let's point to pagure instead of referring to the already sunset > fedorahosted. > > Signed-off-by: Fabiano Fidêncio > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README >

Re: [Libosinfo] [osinfo-db PATCH] centos7: Remove "upgrades" field

2019-01-09 Thread Daniel P . Berrangé
On Fri, Jan 04, 2019 at 01:39:50PM +0100, Fabiano Fidêncio wrote: > After a conversation with Fabian Arrotin, from CentOS project, I've > learned that there's no supported upgrade from CentOS 6 to CentOS7. > > Knowing that, let's just drop the "upgrades" field from centos7 entry. The feature

Re: [Libosinfo] [libosinfo PATCH v3 5/5] tools, install-script: Add "installation-source" parameter

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 09:25:07AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c | 15 +++ > 1 file changed, 15 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [Libosinfo] [libosinfo PATCH v3 4/5] test-install-script: Cover _(get|set)_installation_source()

2018-12-20 Thread Daniel P . Berrangé
On Thu, Dec 20, 2018 at 09:25:06AM +0100, Fabiano Fidêncio wrote: > Signed-off-by: Fabiano Fidêncio > --- > tests/test-install-script.c | 24 > 1 file changed, 24 insertions(+) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange

Re: [Libosinfo] [libosinfo PATCH v3 3/5] install-script: Add _(get|set)_installation_source()

2018-12-20 Thread Daniel P . Berrangé
ged, 71 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-ht

Re: [Libosinfo] [libosinfo PATCH v3 2/5] test-install-script: Cover _(get|set)_preferred_injection_method()

2018-12-20 Thread Daniel P . Berrangé
ewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagra

Re: [Libosinfo] [libosinfo PATCH v3 1/5] install-script: Add _(get|set)_preferred_injection_method()

2018-12-20 Thread Daniel P . Berrangé
nd-line. > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/libosinfo.syms | 3 ++ > osinfo/osinfo_install_script.c | 89 ++ > osinfo/osinfo_install_script.h | 4 ++ > 3 files changed, 96 insertions(+) Reviewed-by: Daniel P. Berrang

Re: [Libosinfo] [libosinfo PATCH v2 6/6] media: Check whether PPC ISOs are bootable

2018-12-20 Thread Daniel P . Berrangé
-by: Fabiano Fidêncio > --- > osinfo/osinfo_media.c | 291 +- > osinfo/osinfo_media.h | 3 +- > 2 files changed, 287 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [Libosinfo] [libosinfo PATCH v2 3/6] media: Use G_STATIC_ASSERT()

2018-12-20 Thread Daniel P . Berrangé
t; 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

Re: [Libosinfo] [libosinfo PATCH v2 2/6] media: Use better naming for goto labels

2018-12-20 Thread Daniel P . Berrangé
t; 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-phot

[Libosinfo] [PATCH] osinfo-db-import: fix loading of local files

2018-12-20 Thread Daniel P . Berrangé
the protocol. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix tools/osinfo-db-import.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/osinfo-db-import.c b/tools/osinfo-db-import.c index 91a7125..920f71b 100644 --- a/tools/osinfo-db-import.c +++ b/tools

Re: [Libosinfo] [libosinfo PATCH v2 1/5] install-script: Add _(get|set)_preferred_injection_method()

2018-12-19 Thread Daniel P . Berrangé
On Wed, Dec 19, 2018 at 11:02:47AM +, Daniel P. Berrangé wrote: > On Mon, Dec 17, 2018 at 08:10:57PM +0100, Fabiano Fidêncio wrote: > > Those new methods are going to be used to tell the install-scripts > > whether the injection-method that's going to be used is. We ha

Re: [Libosinfo] [libosinfo PATCH v2 1/5] install-script: Add _(get|set)_preferred_injection_method()

2018-12-19 Thread Daniel P . Berrangé
On Mon, Dec 17, 2018 at 08:10:57PM +0100, Fabiano Fidêncio wrote: > Those new methods are going to be used to tell the install-scripts > whether the injection-method that's going to be used is. We have to do > so as the command-line may be different depending on the > injection-method used, for

Re: [Libosinfo] [osinfo-db-tools PATCH v5 3/3] import: Introduce "--latest" option

2018-12-19 Thread Daniel P . Berrangé
> > Signed-off-by: Fabiano Fidêncio > --- > About json-glib, no specific version is required! :-) > --- > configure.ac | 1 + > osinfo-db-tools.spec.in | 1 + > tools/Makefile.am| 3 + > tools/osinfo-db-import.c | 153

  1   2   >