On Fri 2018-02-23 14:53:14 +0100, Tim Rühsen wrote:
> On 02/23/2018 01:22 PM, Daniel Kahn Gillmor wrote:
>> well, bumping the SONAME also means that it's a "library transition",
>> which means that everything which builds against libpsl. Gratuitous
>> library transitions make the buildd maintainer
On 02/23/2018 01:22 PM, Daniel Kahn Gillmor wrote:
> On Fri 2018-02-23 12:57:09 +0100, Tim Rühsen wrote:
>> Well, adding or removing a flag *is* a change of the interface. Not
>> clear here if 'interface' means 'function'. From a logical point of
>> understanding it could be anything changing the b
On Fri 2018-02-23 12:57:09 +0100, Tim Rühsen wrote:
> Well, adding or removing a flag *is* a change of the interface. Not
> clear here if 'interface' means 'function'. From a logical point of
> understanding it could be anything changing the behavior of the library
> *or* the application. That mean
Regarding the SONAME bump...
# 4. If any interfaces have been added, removed, or changed since the
last update, increment current, and set revision to 0.
Well, adding or removing a flag *is* a change of the interface. Not
clear here if 'interface' means 'function'. From a logical point of
under
Hi Daniel,
thanks for your thorough review, shame on me !
I relied very much on the test suite - I remembered it as pretty
complete, but it didn't catch the wrong code.
Improved the test suite to stumble over the bad code and fixed the psl.c
accordingly.
More comments follow inline...
On 02
Hi Tim--
Thanks for this new version of libpsl!
On Thu 2018-02-22 10:31:24 +0100, Tim Rühsen wrote:
> this release comes with a new function flag PSL_TYPE_NO_STAR_RULE to be
> used with psl_is_public_suffix2().
> It disables the PSL 'prevailing star rule' and thus returns false for
> TLDs tha
