Re: [PATCH] Refactor installer::sorter

2012-02-16 Thread Tim Retout
On 15 February 2012 21:58, Tim Retout t...@retout.co.uk wrote: subroutines, and replaced the third with a Schwartzian Transform (which might be overkill for this case, but I need to check the callers). Yeah, I've woken up and benchmarked this, and the complexity just makes it slower compared

[PUSHED] Refactor installer::sorter

2012-02-16 Thread Michael Meeks
Hi Tim, On Wed, 2012-02-15 at 21:58 +, Tim Retout wrote: Here are a few patches related to installer::sorter. I've tried to keep them low-risk, because much of the code is called during Windows builds, which I'm not yet testing. Thanks ! :-) One thing I do when I hack this stuff,

Re: [PUSHED] Refactor installer::sorter

2012-02-16 Thread Markus Mohrhard
Hello tim, I added a unit test for the remaining sort function, but I haven't tried to plug it in to the build system or anything.  I tried to adapt the standard license header template to Perl comments.        Oh - interesting. So I think this might be our first perl unit test ever ;-)  

Refactor installer::sorter

2012-02-15 Thread Tim Retout
Hi! Here are a few patches related to installer::sorter. I've tried to keep them low-risk, because much of the code is called during Windows builds, which I'm not yet testing. I think the sort algorithm used currently in installer::sorter must be equivalent to bubble sort; in any case, I