Re: [PUSHED] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-05-23 Thread Thorsten Behrens
Pierre-André Jacquod wrote: So here the patch... Thanks for a review and an ack before I push it. Looks good, thanks a lot - pushed it right away. Cheers, -- Thorsten pgpph39MLsIeY.pgp Description: PGP signature ___ LibreOffice mailing list

Re: [PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-05-18 Thread Pierre-André Jacquod
Hello, On 05/03/2012 11:30 AM, Thorsten Behrens wrote: So what I suggest is a more defensive fix (or some larger review across the code is in order): make GetLineArrow() return the B2DPolyPolygon right away, and have *that one* be empty (i.e. not a Since I do not intend to become a specialist

Re: [PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-05-03 Thread Thorsten Behrens
Pierre-André Jacquod wrote: back again after a while. Hi Pierre-André, welcome back! :) It happens that basegfx::GetLineArrow(...) (also defined within msdffimp.cxx, line 1102) does not create a valid polygon when eLineEnd has the value mso_lineNoEnd... In the switch(eLineEnd), this goes

[PATCH] Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-04-30 Thread Pierre-André Jacquod
Hello, back again after a while. On 02/15/2012 11:30 AM, Thorsten Behrens wrote: Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to chase down why in the first place the ppt import creates polygons with empty sub-paths, that looks like a worthwhile

input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, I have quickly investigated the crash in fdo#45779 when saving an impress document. The reason of the crash is in basegfx/inc/basegfx/point/b2dpoint.hxx (line 82) where this is called: 2DPoint::B2DPoint (this=0xbfffc850, rPoint=...) : B2DTuple(rPoint) (from back-trace) It

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Thorsten Behrens
Pierre-André Jacquod wrote: B2DTuple(const B2DTuple rTup) ... Here you dereference the null pointer, which crash. Ok, the basic attitude would be to let B2DTuple be Null-pointer consistent: (checking that rTup is not NULL), but is it really a good idea? Hi Pierre-André, no, what's

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Thorsten Behrens
Or should I look higher in the hierarchy, saying that a NULL point in a B2DPolygon has nothing to do and disallow it ? Yes, the calling code somehow accesses invalid elements. Let me have a look. Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you like, would be cool to

Re: input for fdo#45779 from a basegfx knowledgeable person needed

2012-02-15 Thread Pierre-André Jacquod
hello, Fixed with d37abad97d72bae0fd0269de12e94c7a7d3fd7e1 - but, if you thanks import creates polygons with empty sub-paths, that looks like a worthwhile optimization - code is around filter/source/msfilter/msdffimp.cxx probably. as soon as I have more spare time, I will have a try.