[Libreoffice] AUTO: AUTO: Away from office (returning 11/05/2010)

2010-10-30 Thread Scott Denham
I am out of the office until 11/05/2010. I am at a conference, with intermittent access to email. Note: This is an automated response to your message LibreOffice Digest, Vol 2, Issue 262 sent on 10/30/10 2:27:48. This is the only notification you will receive while this person is away.

[Libreoffice] [PATCH] emacs.el: Replace all mentions of OOo with LO

2010-10-30 Thread Tim Retout
Hello, world! This is a naive replacement of OpenOffice.org with LibreOffice in emacs.el in the build repository. Will patches sent with git send-email be accepted? Also, this and any future patches I send will of course be under LGPLv3+/MPL. Thanks, -- Tim Retout t...@retout.co.uk From

Re: [Libreoffice] Writer compatibility dialog options

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 12:34 +0200, Cor Nouws wrote: Hi Ron, Ron Faile wrote (30-10-10 02:36) All, I'm working on updating the documentation for Writer. Noticed that on the Options - LibreOffice Writer - Compatibility dialog, some options have OpenOffice.org 1.1 in the name. LibO 3.3

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 17:08 +0200, Gert Faller wrote: Hi, a first try on that. Excellent, these are little mini-optimizations and they all help. Not sure if I let the original source (for control) Nah, don't bother keeping the old content as a comment, we can look at the git history to see

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Gert Faller
Selon Caolán McNamara caol...@redhat.com: You have two typos in there however, i.e. - com.sun.star.chart.BarDiagram + com.sun.star.chart.BarDiagra - com.sun.star.chart2.ScatterChartType + com.sun.star.chart2.ScatterChartTyp in those two cases the trailing letter of the original string

[Libreoffice] [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in starmath

2010-10-30 Thread Jani Monoses
Hello, This changes the only occurrence in writer/starmath. The wiki entry does not mention it, but should UNOOUSTRING::createFromAscii (not OUString) be replaced as well? There are two of that in starmath Jani From da30daf2c9cf9d1f19da7b674a8896fc5fa6e453 Mon Sep 17 00:00:00 2001 From: Jani

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 18:16 +0200, Gert Faller wrote: I've got 2388 files with 'createFromAscii'. That's a lot. The wiki says that this macro is 'faster'. Does it mean at running time ? Yes, ever so slightly, sal/inc/rtl/ustring.hxx has OUString::createFromAscii in it, and that calls

Re: [Libreoffice] [PATCH] cppcheck Common realloc mistake

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 17:26 +0200, Gert Faller wrote: Hi, The two cppcheck warnings in 'libs-core' about 'realloc'. Not sure about that : what to do on NULL ? There are others, for example in : 'sdk/odk/source/unoapploader/unx/unoapploader.c' but with 'exit(EXIT_FAILURE)' on NULL. Hmm,

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Gert Faller
OK, thanks. Now, this only works when you can compute the length of the string at compile time, i.e. its a string literal, so OUString::createFromAscii(foo) can be trivially replaced, while OUString::createFromAscii(pSomething) should be left alone. C. Yes, of course, I was just

Re: [Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

2010-10-30 Thread Jesús Corrius
On Sat, Oct 30, 2010 at 10:35 PM, Gert Faller gertfal...@aliceadsl.fr wrote: OK, thanks. Now, this only works when you can compute the length of the string at compile time, i.e. its a string literal, so OUString::createFromAscii(foo) can be trivially replaced, while

[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro bis

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 22:23 +0200, Gert Faller wrote: Hi, here are some more of them. Great, thanks. Looking at this createFromAscii_4.patch reminds me of something else. Nothing to do with you, the code was this way already, but rtl::OUString foo =

[Libreoffice] [PUSHED] Re: [PATCH] Include header file

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 21:04 +0300, Jani Monoses wrote: Just like the other .cxx files in starmath, make this one include unomodel.hxx and get the definition of the A2OU macro from there instead of redefining it. Doesn't hurt, so pushed, thanks. Looking at the A2OU define I see that it's just

[Libreoffice] [PUSHED] Re: [PATCH] EasyHack RTL_CONSTASCII_USTRINGPARAM in starmath

2010-10-30 Thread Caolán McNamara
On Sat, 2010-10-30 at 21:01 +0300, Jani Monoses wrote: Hello, This changes the only occurrence in writer/starmath. Thanks, Hmm, an empty string. I wonder why it using ::createFromAscii for the empty string case. I suggest that... +_GetNamespaceMap().Add( OUString(),

[Libreoffice] [PATCH] (bootstrap) Internal separation of options of configure

2010-10-30 Thread Niko Rönkkö
MPL 1.1 / GPLv3+ / LGPLv3+ From e7d71554ce70c6082853fcbeb528e62e3398028b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niko=20R=C3=B6nkk=C3=B6?= ron...@iki.fi Date: Sat, 30 Oct 2010 22:36:57 +0300 Subject: [PATCH] (bootstrap) Internal separation of options of configure Grouped inner Optional Features

Re: [Libreoffice] Bug Triage Process

2010-10-30 Thread Caolán McNamara
On Thu, 2010-10-21 at 04:36 -0600, Muthu Subramanian wrote: Hi, I wrote a simple wiki for bug triage process, http://wiki.documentfoundation.org/BugTriage as a starting point. This would help anyone who is looking at doing bug triage for the LibreOffice bugzilla. Looks good, I'd like to